From 1ce88254078ad30749122446a528a4d1c737061f Mon Sep 17 00:00:00 2001 From: Murtaza Patrawala <34130764+murtaza98@users.noreply.github.com> Date: Mon, 28 Feb 2022 19:20:48 +0530 Subject: [PATCH] Regression: Server crashing if Voip credentials are invalid (#24646) --- server/services/voip/service.ts | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/server/services/voip/service.ts b/server/services/voip/service.ts index 2ba093791ba..3e780d61df3 100644 --- a/server/services/voip/service.ts +++ b/server/services/voip/service.ts @@ -47,14 +47,22 @@ export class VoipService extends ServiceClassInternal implements IVoipService { async init(): Promise { this.logger.info('Starting VoIP service'); - await this.commandHandler.initConnection(CommandType.AMI); - this.logger.info('VoIP service started'); + try { + await this.commandHandler.initConnection(CommandType.AMI); + this.logger.info('VoIP service started'); + } catch (err) { + this.logger.error('Error initializing VOIP service', err); + } } async stop(): Promise { this.logger.info('Stopping VoIP service'); - await this.commandHandler.stop(); - this.logger.info('VoIP service stopped'); + try { + this.commandHandler.stop(); + this.logger.info('VoIP service stopped'); + } catch (err) { + this.logger.error('Error stopping VoIP service', err); + } } getServerConfigData(type: ServerType): IVoipCallServerConfig | IVoipManagementServerConfig {