fix: Always broadcast deleted message (#36683)

Co-authored-by: Douglas Fabris <27704687+dougfabris@users.noreply.github.com>

.changeset/gentle-months-kick.md

@@ -0,0 +1,5 @@
+---
+'@rocket.chat/meteor': patch
+---
+
+Fixes an issue where deleted messages remain visible until a manual page refresh when "Message removed" is hidden in hidden system messages settings.

apps/meteor/server/lib/systemMessage/hideSystemMessage.ts

@@ -4,8 +4,10 @@ export const isMutedUnmuted = (messageType: string): boolean => {
 	return messageType === 'user-muted' || messageType === 'user-unmuted';
 };
 
+export const isMessageRemoved = (messageType: string): boolean => messageType === 'rm';
+
 export const shouldHideSystemMessage = (messageType: MessageTypesValues, hideSystemMessage?: MessageTypesValues[]): boolean => {
-	if (!hideSystemMessage?.length) {
+	if (!hideSystemMessage?.length || isMessageRemoved(messageType)) {
 		return false;
 	}
 

apps/meteor/tests/unit/server/lib/systemMessage/hideSystemMessage.spec.ts

@@ -40,6 +40,11 @@ describe('hideSystemMessage', () => {
 			expect(result).to.be.false;
 		});
 
+		it('should return false if message type is of deleted message', async () => {
+			const result = shouldHideSystemMessage('rm', undefined);
+			expect(result).to.be.false;
+		});
+
 		it('should return false if hidden system messages are undefined', async () => {
 			const result = shouldHideSystemMessage('user-muted', undefined);
 			expect(result).to.be.false;