Code review fixes

* Client-side showUserInfo is no longer cleared
* Server-side now handles empty messages
* Added error message if username or message are empty

packages/rocketchat-slashcommands-msg/client.coffee

@@ -1,14 +1,3 @@
-RocketChat.slashCommands.add 'msg', (command, params, item) ->
-	trimmedParams = params.trim()
-
-	username = trimmedParams.slice(0, trimmedParams.indexOf(' '))
-
-	if username is ''
-		return
-	username = username.replace('@', '')
-
-	if Session.get('showUserInfo') is username
-		Session.set('showUserInfo', null)
-,
+RocketChat.slashCommands.add 'msg', null,
 	description: TAPi18n.__ 'Direct_message_someone'
 	params: '@username <message>'

packages/rocketchat-slashcommands-msg/i18n/de.i18n.json

@@ -1,4 +1,5 @@
 {
+  "Direct_message_someone" : "Jemandem eine private Nachricht schicken",
   "Username_doesnt_exist" : "Der Benutzername `%s` existiert nicht.",
-  "Direct_message_someone" : "Jemandem eine private Nachricht schicken"
+  "Username_and_message_must_not_be_empty" : "Benutzername und Nachricht dürfen nicht leer sein."
 }

packages/rocketchat-slashcommands-msg/i18n/en.i18n.json

@@ -1,4 +1,5 @@
 {
+  "Direct_message_someone" : "Direct message someone",
   "Username_doesnt_exist" : "The username `%s` doesn't exist.",
-  "Direct_message_someone" : "Direct message someone"
+  "Username_and_message_must_not_be_empty" : "Username and message must not be empty."
 }

packages/rocketchat-slashcommands-msg/server.coffee

@@ -8,28 +8,35 @@ class Msg
 			return
 
 		trimmedParams = params.trim()
+		separator = trimmedParams.indexOf(' ')
 
-		usernameOrig = trimmedParams.slice(0, trimmedParams.indexOf(' '))
-		message = trimmedParams.slice(trimmedParams.indexOf(' ') + 1)
-
-		username = usernameOrig.replace('@', '')
+		user = Meteor.users.findOne Meteor.userId()
 
-		if username is ''
+		if separator is -1
+			RocketChat.Notifications.notifyUser Meteor.userId(), 'message', {
+				_id: Random.id()
+				rid: item.rid
+				ts: new Date
+				msg: TAPi18n.__('Username_and_message_must_not_be_empty', null, user.language)
+			}
 			return
 
-		user = Meteor.users.findOne Meteor.userId()
-		msgUser = RocketChat.models.Users.findOneByUsername username
+		message = trimmedParams.slice(separator + 1)
+
+		targetUsernameOrig = trimmedParams.slice(0, separator)
+		targetUsername = targetUsernameOrig.replace('@', '')
+		targetUser = RocketChat.models.Users.findOneByUsername targetUsername
 
-		if not msgUser?
+		if not targetUser?
 			RocketChat.Notifications.notifyUser Meteor.userId(), 'message', {
 				_id: Random.id()
 				rid: item.rid
 				ts: new Date
-				msg: TAPi18n.__('Username_doesnt_exist', { postProcess: 'sprintf', sprintf: [ usernameOrig ] }, user.language)
+				msg: TAPi18n.__('Username_doesnt_exist', { postProcess: 'sprintf', sprintf: [ targetUsernameOrig ] }, user.language)
 			}
 			return
 
-		rid = Meteor.call 'createDirectMessage', username
+		rid = Meteor.call 'createDirectMessage', targetUsername
 		msgObject = { _id: Random.id(), rid: rid.rid, msg: message}
 		Meteor.call 'sendMessage', msgObject