Regression: Waiting_queue setting not being applied due to missing module key (#23531)

pull/23332/head^2
Kevin Aleman 5 years ago committed by GitHub
parent 54a0fba4c0
commit 45a5d1f869
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 4
      app/settings/server/SettingsRegistry.ts
  2. 2
      ee/app/livechat-enterprise/server/hooks/afterTakeInquiry.js
  3. 2
      ee/app/livechat-enterprise/server/hooks/beforeRoutingChat.js
  4. 2
      ee/app/livechat-enterprise/server/hooks/onCloseLivechat.js
  5. 3
      ee/app/livechat-enterprise/server/settings.ts

@ -120,7 +120,7 @@ export class SettingsRegistry {
try {
validateSetting(settingFromCode._id, settingFromCode.type, settingFromCode.value);
} catch (e) {
IS_DEVELOPMENT && SystemLogger.error(`Invalid setting code ${ _id }: ${ e.message }`);
IS_DEVELOPMENT && SystemLogger.error(`Invalid setting code ${ _id }: ${ (e as Error).message }`);
}
const isOverwritten = settingFromCode !== settingOverwritten;
@ -144,7 +144,7 @@ export class SettingsRegistry {
try {
validateSetting(settingFromCode._id, settingFromCode.type, settingStored?.value);
} catch (e) {
IS_DEVELOPMENT && SystemLogger.error(`Invalid setting stored ${ _id }: ${ e.message }`);
IS_DEVELOPMENT && SystemLogger.error(`Invalid setting stored ${ _id }: ${ (e as Error).message }`);
}
return;
}

@ -1,5 +1,5 @@
import { callbacks } from '../../../../../app/callbacks';
import { settings } from '../../../../../app/settings';
import { settings } from '../../../../../app/settings/server';
import { debouncedDispatchWaitingQueueStatus } from '../lib/Helper';
import { cbLogger } from '../lib/logger';

@ -1,5 +1,5 @@
import { callbacks } from '../../../../../app/callbacks';
import { settings } from '../../../../../app/settings';
import { settings } from '../../../../../app/settings/server';
import { LivechatInquiry } from '../../../../../app/models/server';
import { dispatchInquiryPosition } from '../lib/Helper';
import { allowAgentSkipQueue } from '../../../../../app/livechat/server/lib/Helper';

@ -1,5 +1,5 @@
import { callbacks } from '../../../../../app/callbacks';
import { settings } from '../../../../../app/settings';
import { settings } from '../../../../../app/settings/server';
import { debouncedDispatchWaitingQueueStatus } from '../lib/Helper';
import { RoutingManager } from '../../../../../app/livechat/server/lib/RoutingManager';
import { LivechatEnterprise } from '../lib/LivechatEnterprise';

@ -79,6 +79,9 @@ export const createSettings = (): void => {
i18nLabel: 'Waiting_queue',
enterprise: true,
invalidValue: false,
modules: [
'livechat-enterprise',
],
enableQuery: omnichannelEnabledQuery,
});

Loading…
Cancel
Save