diff --git a/packages/rocketchat-channel-settings/client/stylesheets/channel-settings.less b/packages/rocketchat-channel-settings/client/stylesheets/channel-settings.less index dd0c5736ea0..fdf1328624e 100644 --- a/packages/rocketchat-channel-settings/client/stylesheets/channel-settings.less +++ b/packages/rocketchat-channel-settings/client/stylesheets/channel-settings.less @@ -6,6 +6,9 @@ > div { position: relative; font-size: 0; + label { + font-weight: 300; + } } } } @@ -17,24 +20,21 @@ } .current-setting { font-size: 14px; - display: inline-block; width: calc(~"100% - 38px"); - } - .icon-pencil { display: inline-block; - font-size: 12px; - width: 20px; - vertical-align: top; + vertical-align: middle; + min-height: 20px; } .editing { padding-right: 80px; font-size: 14px; + margin: -2px 0 -1px -9px; } .buttons { position: absolute; - top: 1px; - bottom: 1px; - right: 1px; + top: -1px; + bottom: 0; + right: 10px; border-radius: 0 4px 4px 0; background: black; .button { @@ -43,6 +43,10 @@ } .button.edit { padding: 8px; + font-size: 12px; + vertical-align: middle; + display: inline-block; + visibility: hidden; } .submit { margin-top: 30px; @@ -50,6 +54,28 @@ } [data-edit] { cursor: pointer; + margin-top: 3px; + } + .boolean { + font-size: 0; + > label { + width: calc(~"100% - 45px"); + display: inline-block; + vertical-align: middle; + } + .setting-block { + width: 40px; + display: inline-block; + vertical-align: middle; + margin-left: -5px; + } + } + .setting-block { + &:hover { + .button.edit { + visibility: visible; + } + } } } } diff --git a/packages/rocketchat-channel-settings/client/views/channelSettings.coffee b/packages/rocketchat-channel-settings/client/views/channelSettings.coffee index 54a846a21bf..929aea7f630 100644 --- a/packages/rocketchat-channel-settings/client/views/channelSettings.coffee +++ b/packages/rocketchat-channel-settings/client/views/channelSettings.coffee @@ -11,6 +11,9 @@ Template.channelSettings.helpers valueOf: (obj, key) -> return obj?[key] + isTextInput: (value) -> + return value == 'text' or value == 'markdown' + showSetting: (setting, room) -> if setting.showInDirect is false return room.t isnt 'd' @@ -82,6 +85,13 @@ Template.channelSettings.events t.editing.set($(e.currentTarget).data('edit')) setTimeout (-> t.$('input.editing').focus().select()), 100 + 'change [type="radio"]': (e, t) -> + t.editing.set($(e.currentTarget).attr('name')) + + 'change [type="checkbox"]': (e, t) -> + t.editing.set($(e.currentTarget).attr('name')) + t.saveSetting() + 'click .cancel': (e, t) -> e.preventDefault() t.editing.set() @@ -203,11 +213,12 @@ Template.channelSettings.onCreated -> @saveSetting = => room = ChatRoom.findOne @data?.rid field = @editing.get() + console.log('FIELD', field) if @settings[field].type is 'select' value = @$(".channel-settings form [name=#{field}]:checked").val() else if @settings[field].type is 'boolean' - value = @$(".channel-settings form [name=#{field}]:checked").val() is 'true' + value = @$(".channel-settings form [name=#{field}]:checked").val() is 'on' else value = @$(".channel-settings form [name=#{field}]").val() diff --git a/packages/rocketchat-channel-settings/client/views/channelSettings.html b/packages/rocketchat-channel-settings/client/views/channelSettings.html index d2e1052869c..566fcc8d637 100644 --- a/packages/rocketchat-channel-settings/client/views/channelSettings.html +++ b/packages/rocketchat-channel-settings/client/views/channelSettings.html @@ -11,14 +11,14 @@ {{#if $value.canView room}} {{#let value=(valueOf room $key)}} -