[FIX] Omnichannel status being changed on page refresh (#23587)

* fix omnichannel status being changed on page refresh

* rename key missing

* Remove duplicated function from models

app/livechat/server/business-hour/AbstractBusinessHour.ts

@@ -47,7 +47,7 @@ export abstract class AbstractBusinessHourBehavior {
 	}
 
 	async changeAgentActiveStatus(agentId: string, status: string): Promise<any> {
-		return this.UsersRepository.setLivechatStatus(agentId, status);
+		return this.UsersRepository.setLivechatStatusIf(agentId, status, { livechatStatusSystemModified: true }, { livechatStatusSystemModified: true });
 	}
 }
 

app/livechat/server/lib/Livechat.js

@@ -40,6 +40,7 @@ import { normalizeTransferredByData, parseAgentCustomFields, updateDepartmentAge
 import { Apps, AppEvents } from '../../../apps/server';
 import { businessHourManager } from '../business-hour';
 import notifications from '../../../notifications/server/lib/Notifications';
+import { Users as UsersRaw } from '../../../models/server/raw';
 
 const logger = new Logger('Livechat');
 
@@ -886,6 +887,12 @@ export const Livechat = {
 		return user;
 	},
 
+	setUserStatusLivechatIf(userId, status, condition, fields) {
+		const user = Promise.await(UsersRaw.setLivechatStatusIf(userId, status, condition, fields));
+		callbacks.runAsync('livechat.setUserStatusLivechat', { userId, status });
+		return user;
+	},
+
 	cleanGuestHistory(_id) {
 		const guest = LivechatVisitors.findOneById(_id);
 		if (!guest) {

app/livechat/server/startup.js

@@ -62,5 +62,5 @@ Meteor.startup(async () => {
 		RoutingManager.setMethodNameAndStartQueue(value);
 	});
 
-	Accounts.onLogout(({ user }) => user?.roles?.includes('livechat-agent') && !user?.roles?.includes('bot') && Livechat.setUserStatusLivechat(user._id, 'not-available'));
+	Accounts.onLogout(({ user }) => user?.roles?.includes('livechat-agent') && !user?.roles?.includes('bot') && Livechat.setUserStatusLivechatIf(user._id, 'not-available', {}, { livechatStatusSystemModified: true }));
 });

app/models/server/models/Users.js

@@ -262,6 +262,7 @@ export class Users extends Base {
 		const update = {
 			$set: {
 				statusLivechat: status,
+				livechatStatusSystemModified: false,
 			},
 		};
 

app/models/server/raw/Users.js

@@ -259,14 +259,16 @@ export class UsersRaw extends BaseRaw {
 		return result.value;
 	}
 
-	setLivechatStatus(userId, status) { // TODO: Create class Agent
+	setLivechatStatusIf(userId, status, conditions = {}, extraFields = {}) { // TODO: Create class Agent
 		const query = {
 			_id: userId,
+			...conditions,
 		};
 
 		const update = {
 			$set: {
 				statusLivechat: status,
+				...extraFields,
 			},
 		};