[FIX] Error when re-installing an App (#17789)

* Fix wrong method call on app installation

* Update subscription check to take cancelled state into account
pull/15932/head
Douglas Gubert 5 years ago committed by GitHub
parent ed620717c7
commit 5c530d0be6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 3
      app/apps/client/admin/appManage.js
  2. 7
      app/apps/client/admin/helpers.js

@ -405,7 +405,8 @@ Template.appManage.events({
_app.set('working', true);
try {
const { status } = await Apps.updateApp(appId, _app.get('marketplaceVersion'));
const method = _app.get('installed') ? 'updateApp' : 'installApp';
const { status } = await Apps[method](appId, _app.get('marketplaceVersion'));
warnStatusChange(_app.get('name'), status);
} catch (error) {
handleAPIError(error);

@ -19,6 +19,11 @@ const appErroredStatuses = [
AppStatus.INVALID_LICENSE_DISABLED,
];
const subscriptionActiveStatuses = [
'trialing',
'active',
];
export const handleAPIError = (error) => {
console.error(error);
const message = (error.xhr && error.xhr.responseJSON && error.xhr.responseJSON.error) || error.message;
@ -298,7 +303,7 @@ export const appButtonProps = ({
};
}
const canTrial = purchaseType === 'subscription' && !subscriptionInfo.status;
const canTrial = purchaseType === 'subscription' && !subscriptionActiveStatuses.includes(subscriptionInfo.status);
if (canTrial) {
return {
action: 'purchase',

Loading…
Cancel
Save