Prevent reevaluate `Meteor.userId()`

9 years ago · 66e8c508f6
parent 43035dd0ef
commit 66e8c508f6
1 changed files with 3 additions and 2 deletions
--- a/server/methods/setUserPassword.js
+++ b/server/methods/setUserPassword.js
@ -2,13 +2,14 @@ Meteor.methods({
 	setUserPassword(password) {
 		check(password, String);

-		if (!Meteor.userId()) {
+		const userId = Meteor.userId();
+
+		if (!userId) {
 			throw new Meteor.Error('error-invalid-user', 'Invalid user', {
 				method: 'setUserPassword'
 			});
 		}

-		const userId = Meteor.userId();
 		const user = RocketChat.models.Users.findOneById(userId);

 		if (user && user.requirePasswordChange !== true) {