diff --git a/.changeset/two-planes-call.md b/.changeset/two-planes-call.md new file mode 100644 index 00000000000..9408c05d624 --- /dev/null +++ b/.changeset/two-planes-call.md @@ -0,0 +1,5 @@ +--- +'@rocket.chat/meteor': patch +--- + +Fixes an issue where users table headers are being displayed when there's no results diff --git a/apps/meteor/client/views/admin/users/UsersTable/UsersTable.tsx b/apps/meteor/client/views/admin/users/UsersTable/UsersTable.tsx index 68b78046251..d8e5615105a 100644 --- a/apps/meteor/client/views/admin/users/UsersTable/UsersTable.tsx +++ b/apps/meteor/client/views/admin/users/UsersTable/UsersTable.tsx @@ -159,7 +159,6 @@ const UsersTable = ({ return ( <> - {isLoading && ( {headers} @@ -168,7 +167,6 @@ const UsersTable = ({ )} - {isError && ( )} @@ -184,7 +182,7 @@ const UsersTable = ({ /> )} - {isSuccess && !!users && ( + {isSuccess && users.length > 0 && ( <> {headers} diff --git a/apps/meteor/client/views/admin/users/UsersTable/__snapshots__/UsersTable.spec.tsx.snap b/apps/meteor/client/views/admin/users/UsersTable/__snapshots__/UsersTable.spec.tsx.snap index db5a31c2c0e..11736ec158c 100644 --- a/apps/meteor/client/views/admin/users/UsersTable/__snapshots__/UsersTable.spec.tsx.snap +++ b/apps/meteor/client/views/admin/users/UsersTable/__snapshots__/UsersTable.spec.tsx.snap @@ -1528,242 +1528,6 @@ exports[`renders NoResults without crashing 1`] = ` -
-
-
-
-
-
-
- - - - - - - - - -
-
- Name - - - - -
-
-
- Username - - - - -
-
-
- Actions -
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
`;