From 78e95abaa0cd7f8be02d1d827783cd268a7f2fc0 Mon Sep 17 00:00:00 2001 From: Guilherme Gazzo Date: Wed, 20 Mar 2024 00:04:21 -0300 Subject: [PATCH] test: fix Default rooms flaky (#32033) --- apps/meteor/tests/e2e/administration.spec.ts | 14 +++++++++----- apps/meteor/tests/e2e/page-objects/admin.ts | 2 +- 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/apps/meteor/tests/e2e/administration.spec.ts b/apps/meteor/tests/e2e/administration.spec.ts index 2a359bd47f5..dcfb8537318 100644 --- a/apps/meteor/tests/e2e/administration.spec.ts +++ b/apps/meteor/tests/e2e/administration.spec.ts @@ -104,8 +104,12 @@ test.describe.parallel('administration', () => { await poAdmin.inputSearchRooms.type(targetChannel); await poAdmin.getRoomRow(targetChannel).click(); await poAdmin.defaultLabel.click(); - await poAdmin.btnSave.click(); - + + await test.step('should close contextualbar after saving', async () => { + await poAdmin.btnSave.click(); + await expect(poAdmin.page).toHaveURL(new RegExp('/admin/rooms$')); + }); + await poAdmin.getRoomRow(targetChannel).click(); await expect(poAdmin.defaultInput).toBeChecked(); }); @@ -137,13 +141,13 @@ test.describe.parallel('administration', () => { test.describe('Mailer', () => { test.beforeEach(async ({ page }) => { await page.goto('/admin/mailer'); - }) + }); test('should not have any accessibility violations', async ({ makeAxeBuilder }) => { const results = await makeAxeBuilder().analyze(); expect(results.violations).toEqual([]); - }) - }) + }); + }); test.describe('Settings', () => { test.describe('General', () => { diff --git a/apps/meteor/tests/e2e/page-objects/admin.ts b/apps/meteor/tests/e2e/page-objects/admin.ts index 519b15f0cc0..b036fa33957 100644 --- a/apps/meteor/tests/e2e/page-objects/admin.ts +++ b/apps/meteor/tests/e2e/page-objects/admin.ts @@ -3,7 +3,7 @@ import type { Locator, Page } from '@playwright/test'; import { AdminFlextab } from './fragments/admin-flextab'; export class Admin { - private readonly page: Page; + public readonly page: Page; readonly tabs: AdminFlextab;