"description":"The improvement modify `server_url` and `user_id` params into `serverURL` and `userId` more suitable to our camelCase pattern. Also converts the webdav methods into .ts helping us to prevent issues in the next modal rewrites efforts.",
"contributors":[
"dougfabris"
]
},
{
"pr":"23875",
"title":"Chore: update docker image base to latest node 12 patch",
"userLogin":"debdutdeb",
"contributors":[
"debdutdeb",
"sampaiodiego",
"web-flow"
]
},
{
"pr":"24007",
"title":"[IMPROVE] Replace SortListItem and CreateListItem with ListItem",
"userLogin":"juliajforesti",
"contributors":[
"juliajforesti",
"ggazzo"
]
},
{
"pr":"23912",
"title":"[NEW] Show Omnichannel room icon based on source definition",
"userLogin":"AllanPazRibeiro",
"milestone":"4.3.0",
"contributors":[
"AllanPazRibeiro",
"ggazzo",
"d-gubert",
"web-flow"
]
},
{
"pr":"23925",
"title":"[NEW][APPS] Add new email event for apps",
"userLogin":"d-gubert",
"description":"Introduces a new event called before an email is sent by the Mailer. Apps can intercept and modify the email that will be sent, or even prevent it from being sent altogether. For more details, check https://github.com/RocketChat/Rocket.Chat.Apps-engine/pull/461/files#diff-301e8a58164edbf315da2a43c4923f153dbc909573de1e60aa9f730f7488ac82",
"milestone":"4.3.0",
"contributors":[
"d-gubert"
]
},
{
"pr":"19640",
"title":"[FIX] Changes on department agents should mark form as dirty",
"userLogin":"rafaelblink",
"milestone":"4.3.0",
"contributors":[
"rafaelblink",
"web-flow",
"gabriellsh",
"renatobecker",
"dougfabris"
]
},
{
"pr":"23904",
"title":"[FIX] Jitsi call already ended",
"userLogin":"Aman-Maheshwari",
"description":"- Fix Jitsi timeout update -- which caused the \"Jitsi call already ended\" error when trying to join a call some time after its creation;",
"contributors":[
"Aman-Maheshwari",
"yash-rajpal"
]
},
{
"pr":"23939",
"title":"[NEW][EE] Introduce fallback department support",
"userLogin":"KevLehman",
"milestone":"4.3.0",
"contributors":[
"KevLehman"
]
},
{
"pr":"23959",
"title":"[FIX] teams.leave client usage",
"userLogin":"dougfabris",
"milestone":"4.3.0",
"contributors":[
"dougfabris"
]
},
{
"pr":"23679",
"title":"[NEW][APPS] Allow Rocket.Chat Apps to register custom action buttons",
"userLogin":"d-gubert",
"description":"Add an action button manager that allows apps to register custom action buttons that trigger interaction callbacks in them",
"milestone":"4.3.0",
"contributors":[
"d-gubert",
"web-flow"
]
},
{
"pr":"23843",
"title":"[NEW][APPS] Allow apps to open contextual bar",
"userLogin":"thassiov",
"description":"Opens a contextual bar using app ui interactions (`CONTEXTUAL_BAR_OPEN`)\r\n\r\nhttps://user-images.githubusercontent.com/733282/146704076-d2d115f2-6ca6-4ed0-b450-81be580889a4.mp4",
"milestone":"4.3.0",
"contributors":[
"thassiov"
]
},
{
"pr":"23786",
"title":"Chore: Enable prefer-optional-chain ESLint rule for TypeScript files",
"userLogin":"tassoevan",
"description":"> Code is bad. It rots. It requires periodic maintenance. It has bugs that need to be found. New features mean old code has to be adapted.\r\n> The more code you have, the more places there are for bugs to hide. The longer checkouts or compiles take. The longer it takes a new employee to make sense of your system. If you have to refactor there's more stuff to move around.\r\n> Furthermore, more code often means less flexibility and functionality. This is counter-intuitive, but a lot of times a simple, elegant solution is faster and more general than the plodding mess of code produced by a programmer of lesser talent.\r\n> Code is produced by engineers. To make more code requires more engineers. Engineers have n^2 communication costs, and all that code they add to the system, while expanding its capability, also increases a whole basket of costs.\r\n> You should do whatever possible to increase the productivity of individual programmers in terms of the expressive power of the code they write. Less code to do the same thing (and possibly better). Less programmers to hire. Less organizational communication costs.\r\n\r\n— <cite>[Rich Skrenta][1]</cite>\r\n\r\nMixing two problem domains in code is prone to errors. In this small example\r\n\r\n```ts\r\ndeclare const y: { z: unknown } | undefined;\r\n\r\nconst x = y && y.z;\r\n```\r\n\r\nwe're (1) checking the nullity of `y` and (2) attributing `y.z` to `x`, where (2) is _clearly_ the main problem we're solving with code. The optional chaining is a good technique to handle nullity as a mere implementation detail:\r\n\r\n```ts\r\ndeclare const y: { z: unknown } | undefined;\r\n\r\nconst x = y?.z;\r\n```\r\n\r\nAttributing `y.z` to `x` is more easily readable than the nullity check of `y`.\r\n\r\nThis PR aims to add `@typescript-eslint/prefer-optional-chain` rule to ESlint configuration at warning level.",
"contributors":[
"tassoevan",
"sampaiodiego",
"web-flow"
]
},
{
"pr":"23996",
"title":"Chore: Remove the `mobile-download-file` permission",
"userLogin":"matheusbsilva137",
"description":"- Remove the `mobile-download-file` permission and its descriptions.",
"contributors":[
"matheusbsilva137"
]
},
{
"pr":"23823",
"title":"[FIX] LDAP Sync doing nothing when set to only import new users.",
"title":"[FIX] Broken links present in some languages",
"userLogin":"aswinidev",
"contributors":[
"aswinidev"
]
},
{
"pr":"23846",
"title":"Chore: added last login to users.list",
"userLogin":"ostjen",
"contributors":[
"ostjen"
]
},
{
"pr":"23574",
"title":"[FIX] Email notifications settings not being honored on new DMs",
"userLogin":"ostjen",
"contributors":[
"ostjen",
"web-flow",
"sampaiodiego"
]
},
{
"pr":"23805",
"title":"[FIX] Headers already sent error when user data download is disabled",
"userLogin":"sampaiodiego",
"description":"When using the export message tool when trying to download the file using the link sent via email if the feature \"Export User Data\" is disabled an error was being thrown causing the request to halt.\r\n\r\nThis is the error shown in the logs:\r\n```\r\n=== UnHandledPromiseRejection ===\r\nError [ERR_HTTP_HEADERS_SENT] [ERR_HTTP_HEADERS_SENT]: Cannot set headers after they are sent to the client\r\n at ServerResponse.setHeader (_http_outgoing.js:530:11)\r\n at ServerResponse.res.setHeader (/app/bundle/programs/server/npm/node_modules/meteor/simple_json-routes/node_modules/connect/lib/patch.js:134:22)\r\n at app/user-data-download/server/exportDownload.js:14:7\r\n at /app/bundle/programs/server/npm/node_modules/meteor/promise/node_modules/meteor-promise/fiber_pool.js:43:40 {\r\n code: 'ERR_HTTP_HEADERS_SENT'\r\n}\r\n---------------------------------\r\nErrors like this can cause oplog processing errors.\r\nSetting EXIT_UNHANDLEDPROMISEREJECTION will cause the process to exit allowing your service to automatically restart the process\r\nFuture node.js versions will automatically exit the process\r\n=================================\r\n```",
"contributors":[
"sampaiodiego"
]
},
{
"pr":"23991",
"title":"i18n: Language update from LingoHub 🤖 on 2021-12-20Z",
"userLogin":"lingohub[bot]",
"contributors":[
null
]
},
{
"pr":"23901",
"title":"[FIX] broken `Word Placement Anywhere` and `Run on edits` toggles in integration page",
"userLogin":"aswinidev",
"milestone":"4.3.0",
"contributors":[
"aswinidev"
]
},
{
"pr":"23973",
"title":"[FIX] OTR not working",
"userLogin":"gabriellsh",
"description":"A rule on the user notification streamer was changed recently, and the check for writing on the streamer was wrong. Changed it to allow all logged users.",
"milestone":"4.3.0",
"contributors":[
"gabriellsh"
]
},
{
"pr":"23833",
"title":"[FIX] Add missing .png to clipboard uploaded file name",
"userLogin":"dougfabris",
"milestone":"4.3.0",
"contributors":[
"dougfabris",
"gabriellsh"
]
},
{
"pr":"23974",
"title":"Chore: Use only LivechatTriggerRaw model",
"userLogin":"sampaiodiego",
"contributors":[
"sampaiodiego"
]
},
{
"pr":"23948",
"title":"[FIX] Missing edit icon in sequential thread messages",
"title":"[FIX] Removing Edit message from messageBox on room changed",
"userLogin":"yash-rajpal",
"description":"Removing edit message from messageBox and local storage on messageBox destroyed.",
"milestone":"4.3.0",
"contributors":[
"yash-rajpal"
]
},
{
"pr":"23945",
"title":"[IMPROVE] Allow e-mail channel to be used without default department.",
"userLogin":"cauefcr",
"description":"Due to a missing condition in the e-mail input processing, Rocket.Chat was unable to receive e-mails from e-mail channels that did not have a default department.",
"contributors":[
"cauefcr",
"murtaza98",
"web-flow"
]
},
{
"pr":"23466",
"title":"Bump mailparser from 3.2.0 to 3.4.0",
"userLogin":"dependabot[bot]",
"contributors":[
"dependabot[bot]",
"web-flow"
]
},
{
"pr":"23853",
"title":"Bump thehanimo/pr-title-checker from 1.2 to 1.3.4",
"title":"[FIX] Popover position for arabic languages",
"userLogin":"yash-rajpal",
"milestone":"4.3.0",
"contributors":[
"yash-rajpal"
]
},
{
"pr":"23347",
"title":"[FIX] creating room with federated member",
"userLogin":"qwertiko",
"milestone":"4.2.2",
"contributors":[
"qwertiko",
"web-flow"
]
},
{
"pr":"23930",
"title":"i18n: Language update from LingoHub 🤖 on 2021-12-13Z",
"userLogin":"lingohub[bot]",
"contributors":[
null
]
},
{
"pr":"21025",
"title":"[NEW][APPS] Possibility to set room closer via Apps LivechatBridge.closeRoom",
"userLogin":"cuonghuunguyen",
"description":"Add an optional param named `closer` into `LivechatBridge.closeRoom` so that it will be possible to close the room and send a close room message with the correct room closer.\r\nIf the param is not passed, use the room visitor as the room closer.",
"contributors":[
null,
"d-gubert"
]
},
{
"pr":"23860",
"title":"[FIX] Custom status doesn't update properly",
"userLogin":"dougfabris",
"contributors":[
"dougfabris",
"gabriellsh"
]
},
{
"pr":"23921",
"title":"Bump cookie-parser from 1.4.5 to 1.4.6 in /ee/server/services",
"userLogin":"dependabot[bot]",
"contributors":[
"dependabot[bot]",
"web-flow"
]
},
{
"pr":"23914",
"title":"Chore: Fix hasRole warning",
"userLogin":"sampaiodiego",
"contributors":[
"sampaiodiego"
]
},
{
"pr":"23922",
"title":"Chore: Update pino deps",
"userLogin":"sampaiodiego",
"contributors":[
"sampaiodiego"
]
},
{
"pr":"23689",
"title":"Bump path-parse from 1.0.6 to 1.0.7",
"userLogin":"dependabot[bot]",
"contributors":[
"dependabot[bot]",
"web-flow"
]
},
{
"pr":"23526",
"title":"Bump @rocket.chat/string-helpers from 0.29.0 to 0.30.1 in /ee/server/services",
"userLogin":"dependabot[bot]",
"contributors":[
"dependabot[bot]",
"web-flow"
]
},
{
"pr":"23289",
"title":"Bump pm2 from 5.1.1 to 5.1.2 in /ee/server/services",
"userLogin":"dependabot[bot]",
"contributors":[
"dependabot[bot]",
"web-flow"
]
},
{
"pr":"23913",
"title":"Chore: Update Livechat",
"userLogin":"MartinSchoeler",
"milestone":"4.2.1",
"contributors":[
"MartinSchoeler"
]
},
{
"pr":"23908",
"title":"[FIX] Translations for App Select Settings not working",
"userLogin":"murtaza98",
"description":"Derived from PR https://github.com/RocketChat/Rocket.Chat/pull/19238",
"contributors":[
"murtaza98"
]
},
{
"pr":"23848",
"title":"[FIX] DMs being created with username instead of user's name",
"description":"- Improves the \"Message Erasure Type\" setting's description by providing more details regarding the expected behavior of each option (\"Keep Messages and User Name\", \"Delete All Messages\" and \"Remove link between user and messages\");\r\n- Remove outdated translations (for this setting's description).",
"contributors":[
"matheusbsilva137"
]
},
{
"pr":"23796",
"title":"[FIX] Segmentation fault on CentOS 7 due to outdated `sharp`",
"userLogin":"tassoevan",
"description":"Upgrades `sharp` to avoid a segmentation fault on CentOS 7 during startup related to `sharp.node` being loaded via `process.dlopen()`.\r\n\r\nSuggested as a fix for versions `4.0.x` and `4.1.x`.",
"title":"[FIX] Fix no message size limit for method sendMessageLivechat",
"userLogin":"cuonghuunguyen",
"contributors":[
null
]
},
{
"pr":"23791",
"title":"[FIX] Modal keeps state if reset too fast.",
"userLogin":"gabriellsh",
"description":"~Queued updates so the Modal has a chance to close.~\r\nUsed a random key to ensure modal doesn't keep it's state.",
"milestone":"4.3.0",
"contributors":[
"gabriellsh"
]
},
{
"pr":"23877",
"title":"Regression: Missing padding in popover with custom template",
"userLogin":"dougfabris",
"description":"",
"contributors":[
"dougfabris"
]
},
{
"pr":"23873",
"title":"i18n: Language update from LingoHub 🤖 on 2021-12-06Z",
"userLogin":"lingohub[bot]",
"contributors":[
null,
"sampaiodiego"
]
},
{
"pr":"23861",
"title":"[FIX] Wrong button for non trial apps",
"userLogin":"rique223",
"description":"This PR solves a bug on the marketplace that was happening with WhatsApp where it was displaying a trial button even though it didn't have a free trial period. The new verification I've added checks if the app is subscription-based and then checks if it has 0 trial days in all of its tiers. If it does, it shows a subscribe button. If it doesn't, it displays a trial button. Also, I've exposed the itsEnterpriseOnly flag as an extra measure in the case of apps like Facebook Messenger that are enterprise-only and consequently should show the subscribe button. \r\nBefore:\r\n \r\nAfter:\r\n",
"milestone":"4.2.1",
"contributors":[
"rique223"
]
},
{
"pr":"23859",
"title":"[FIX] Error when creating an inactive user in admin panel",
"userLogin":"matheusbsilva137",
"description":"- Fix `usersInRole` array used to send email to activate a user.",
"milestone":"4.2.1",
"contributors":[
"matheusbsilva137"
]
},
{
"pr":"23822",
"title":"Chore: Create script to add new migrations",
"userLogin":"KevLehman",
"description":"- Create NPM script to add new migrations\r\n- TODO: Infer next migration number from file list",
"contributors":[
"KevLehman"
]
},
{
"pr":"23215",
"title":"[FIX] Add CSP to authorize auto-close of CAS login window",
"userLogin":"goyome",
"description":"Add the hash of the JS inside the page that won't close ( window.close(); )",
"milestone":"4.1.0",
"contributors":[
"goyome",
"pierre-lehnen-rc",
"web-flow"
]
},
{
"pr":"23831",
"title":"[FIX] Missing custom user status ellipsis",
- **APPS:** Add new email event for apps ([#23925](https://github.com/RocketChat/Rocket.Chat/pull/23925))
Introduces a new event called before an email is sent by the Mailer. Apps can intercept and modify the email that will be sent, or even prevent it from being sent altogether. For more details, check https://github.com/RocketChat/Rocket.Chat.Apps-engine/pull/461/files#diff-301e8a58164edbf315da2a43c4923f153dbc909573de1e60aa9f730f7488ac82
- **APPS:** Allow apps to open contextual bar ([#23843](https://github.com/RocketChat/Rocket.Chat/pull/23843))
Opens a contextual bar using app ui interactions (`CONTEXTUAL_BAR_OPEN`)
- **APPS:** Possibility to set room closer via Apps LivechatBridge.closeRoom ([#21025](https://github.com/RocketChat/Rocket.Chat/pull/21025))
Add an optional param named `closer` into `LivechatBridge.closeRoom` so that it will be possible to close the room and send a close room message with the correct room closer.
If the param is not passed, use the room visitor as the room closer.
- **EE:** Introduce fallback department support ([#23939](https://github.com/RocketChat/Rocket.Chat/pull/23939))
- Show Omnichannel room icon based on source definition ([#23912](https://github.com/RocketChat/Rocket.Chat/pull/23912))
### 🚀 Improvements
- Allow e-mail channel to be used without default department. ([#23945](https://github.com/RocketChat/Rocket.Chat/pull/23945))
Due to a missing condition in the e-mail input processing, Rocket.Chat was unable to receive e-mails from e-mail channels that did not have a default department.
- Improves the "Message Erasure Type" setting's description by providing more details regarding the expected behavior of each option ("Keep Messages and User Name", "Delete All Messages" and "Remove link between user and messages");
- Remove outdated translations (for this setting's description).
The improvement modify `server_url` and `user_id` params into `serverURL` and `userId` more suitable to our camelCase pattern. Also converts the webdav methods into .ts helping us to prevent issues in the next modal rewrites efforts.
### 🐛 Bug fixes
- Add CSP to authorize auto-close of CAS login window ([#23215](https://github.com/RocketChat/Rocket.Chat/pull/23215) by [@goyome](https://github.com/goyome))
Add the hash of the JS inside the page that won't close ( window.close(); )
- Add missing .png to clipboard uploaded file name ([#23833](https://github.com/RocketChat/Rocket.Chat/pull/23833))
- broken `Word Placement Anywhere` and `Run on edits` toggles in integration page ([#23901](https://github.com/RocketChat/Rocket.Chat/pull/23901) by [@aswinidev](https://github.com/aswinidev))
- Broken links present in some languages ([#23987](https://github.com/RocketChat/Rocket.Chat/pull/23987) by [@aswinidev](https://github.com/aswinidev))
- Changes on department agents should mark form as dirty ([#19640](https://github.com/RocketChat/Rocket.Chat/pull/19640) by [@rafaelblink](https://github.com/rafaelblink))
- creating room with federated member ([#23347](https://github.com/RocketChat/Rocket.Chat/pull/23347) by [@qwertiko](https://github.com/qwertiko))
- Custom emoji route in admin ([#23882](https://github.com/RocketChat/Rocket.Chat/pull/23882) by [@sidmohanty11](https://github.com/sidmohanty11))
- Custom status doesn't update properly ([#23860](https://github.com/RocketChat/Rocket.Chat/pull/23860))
- DMs being created with username instead of user's name ([#23848](https://github.com/RocketChat/Rocket.Chat/pull/23848))
- Email notifications settings not being honored on new DMs ([#23574](https://github.com/RocketChat/Rocket.Chat/pull/23574))
- Error when creating an inactive user in admin panel ([#23859](https://github.com/RocketChat/Rocket.Chat/pull/23859))
- Fix `usersInRole` array used to send email to activate a user.
- Fix no message size limit for method sendMessageLivechat ([#23558](https://github.com/RocketChat/Rocket.Chat/pull/23558))
- Headers already sent error when user data download is disabled ([#23805](https://github.com/RocketChat/Rocket.Chat/pull/23805))
When using the export message tool when trying to download the file using the link sent via email if the feature "Export User Data" is disabled an error was being thrown causing the request to halt.
This is the error shown in the logs:
```
=== UnHandledPromiseRejection ===
Error [ERR_HTTP_HEADERS_SENT] [ERR_HTTP_HEADERS_SENT]: Cannot set headers after they are sent to the client
at ServerResponse.setHeader (_http_outgoing.js:530:11)
at ServerResponse.res.setHeader (/app/bundle/programs/server/npm/node_modules/meteor/simple_json-routes/node_modules/connect/lib/patch.js:134:22)
at app/user-data-download/server/exportDownload.js:14:7
at /app/bundle/programs/server/npm/node_modules/meteor/promise/node_modules/meteor-promise/fiber_pool.js:43:40 {
code: 'ERR_HTTP_HEADERS_SENT'
}
---------------------------------
Errors like this can cause oplog processing errors.
Setting EXIT_UNHANDLEDPROMISEREJECTION will cause the process to exit allowing your service to automatically restart the process
Future node.js versions will automatically exit the process
=================================
```
- Jitsi call already ended ([#23904](https://github.com/RocketChat/Rocket.Chat/pull/23904) by [@Aman-Maheshwari](https://github.com/Aman-Maheshwari) & [@yash-rajpal](https://github.com/yash-rajpal))
- Fix Jitsi timeout update -- which caused the "Jitsi call already ended" error when trying to join a call some time after its creation;
- LDAP Sync doing nothing when set to only import new users. ([#23823](https://github.com/RocketChat/Rocket.Chat/pull/23823))
- Missing custom user status ellipsis ([#23831](https://github.com/RocketChat/Rocket.Chat/pull/23831))
- Modal keeps state if reset too fast. ([#23791](https://github.com/RocketChat/Rocket.Chat/pull/23791))
~Queued updates so the Modal has a chance to close.~
Used a random key to ensure modal doesn't keep it's state.
- OTR not working ([#23973](https://github.com/RocketChat/Rocket.Chat/pull/23973))
A rule on the user notification streamer was changed recently, and the check for writing on the streamer was wrong. Changed it to allow all logged users.
- Popover position for arabic languages ([#23888](https://github.com/RocketChat/Rocket.Chat/pull/23888) by [@yash-rajpal](https://github.com/yash-rajpal))
- Removing Edit message from messageBox on room changed ([#23910](https://github.com/RocketChat/Rocket.Chat/pull/23910) by [@yash-rajpal](https://github.com/yash-rajpal))
Removing edit message from messageBox and local storage on messageBox destroyed.
- Segmentation fault on CentOS 7 due to outdated `sharp` ([#23796](https://github.com/RocketChat/Rocket.Chat/pull/23796))
Upgrades `sharp` to avoid a segmentation fault on CentOS 7 during startup related to `sharp.node` being loaded via `process.dlopen()`.
Suggested as a fix for versions `4.0.x` and `4.1.x`.
- Translations for App Select Settings not working ([#23908](https://github.com/RocketChat/Rocket.Chat/pull/23908))
Derived from PR https://github.com/RocketChat/Rocket.Chat/pull/19238
- Wrong button for non trial apps ([#23861](https://github.com/RocketChat/Rocket.Chat/pull/23861))
This PR solves a bug on the marketplace that was happening with WhatsApp where it was displaying a trial button even though it didn't have a free trial period. The new verification I've added checks if the app is subscription-based and then checks if it has 0 trial days in all of its tiers. If it does, it shows a subscribe button. If it doesn't, it displays a trial button. Also, I've exposed the itsEnterpriseOnly flag as an extra measure in the case of apps like Facebook Messenger that are enterprise-only and consequently should show the subscribe button.
- Bump @rocket.chat/string-helpers from 0.29.0 to 0.30.1 in /ee/server/services ([#23526](https://github.com/RocketChat/Rocket.Chat/pull/23526) by [@dependabot[bot]](https://github.com/dependabot[bot]))
- Bump cookie-parser from 1.4.5 to 1.4.6 in /ee/server/services ([#23921](https://github.com/RocketChat/Rocket.Chat/pull/23921) by [@dependabot[bot]](https://github.com/dependabot[bot]))
- Bump mailparser from 3.2.0 to 3.4.0 ([#23466](https://github.com/RocketChat/Rocket.Chat/pull/23466) by [@dependabot[bot]](https://github.com/dependabot[bot]))
- Bump path-parse from 1.0.6 to 1.0.7 ([#23689](https://github.com/RocketChat/Rocket.Chat/pull/23689) by [@dependabot[bot]](https://github.com/dependabot[bot]))
- Bump pm2 from 5.1.1 to 5.1.2 in /ee/server/services ([#23289](https://github.com/RocketChat/Rocket.Chat/pull/23289) by [@dependabot[bot]](https://github.com/dependabot[bot]))
- Bump thehanimo/pr-title-checker from 1.2 to 1.3.4 ([#23853](https://github.com/RocketChat/Rocket.Chat/pull/23853) by [@dependabot[bot]](https://github.com/dependabot[bot]))
- Chore: added last login to users.list ([#23846](https://github.com/RocketChat/Rocket.Chat/pull/23846))
- Chore: Enable prefer-optional-chain ESLint rule for TypeScript files ([#23786](https://github.com/RocketChat/Rocket.Chat/pull/23786))
> Code is bad. It rots. It requires periodic maintenance. It has bugs that need to be found. New features mean old code has to be adapted.
> The more code you have, the more places there are for bugs to hide. The longer checkouts or compiles take. The longer it takes a new employee to make sense of your system. If you have to refactor there's more stuff to move around.
> Furthermore, more code often means less flexibility and functionality. This is counter-intuitive, but a lot of times a simple, elegant solution is faster and more general than the plodding mess of code produced by a programmer of lesser talent.
> Code is produced by engineers. To make more code requires more engineers. Engineers have n^2 communication costs, and all that code they add to the system, while expanding its capability, also increases a whole basket of costs.
> You should do whatever possible to increase the productivity of individual programmers in terms of the expressive power of the code they write. Less code to do the same thing (and possibly better). Less programmers to hire. Less organizational communication costs.
— <cite>[Rich Skrenta][1]</cite>
Mixing two problem domains in code is prone to errors. In this small example
```ts
declare const y: { z: unknown } | undefined;
const x = y && y.z;
```
we're (1) checking the nullity of `y` and (2) attributing `y.z` to `x`, where (2) is _clearly_ the main problem we're solving with code. The optional chaining is a good technique to handle nullity as a mere implementation detail:
```ts
declare const y: { z: unknown } | undefined;
const x = y?.z;
```
Attributing `y.z` to `x` is more easily readable than the nullity check of `y`.
This PR aims to add `@typescript-eslint/prefer-optional-chain` rule to ESlint configuration at warning level.
- Add markdown to custom fields in user Info ([#20947](https://github.com/RocketChat/Rocket.Chat/pull/20947))
- Add markdown to custom fields in user Info ([#20947](https://github.com/RocketChat/Rocket.Chat/pull/20947) by [@yash-rajpal](https://github.com/yash-rajpal))
- **ENTERPRISE:** Omnichannel Monitors can't forward chats to departments that they are not supervising ([#22142](https://github.com/RocketChat/Rocket.Chat/pull/22142))
- Adding Custom Fields to show on user info check ([#20955](https://github.com/RocketChat/Rocket.Chat/pull/20955))
- Adding Custom Fields to show on user info check ([#20955](https://github.com/RocketChat/Rocket.Chat/pull/20955) by [@yash-rajpal](https://github.com/yash-rajpal))
The setting custom fields to show under user info was not being used when rendering fields in user info. This pr adds those checks and only renders the fields mentioned under in admin -> accounts -> Custom Fields to Show in User Info.
- Adding permission 'add-team-channel' for Team Channels Contextual bar ([#21591](https://github.com/RocketChat/Rocket.Chat/pull/21591))
- Adding permission 'add-team-channel' for Team Channels Contextual bar ([#21591](https://github.com/RocketChat/Rocket.Chat/pull/21591) by [@yash-rajpal](https://github.com/yash-rajpal))
Added 'add-team-channel' permission to the 2 buttons in team channels contextual bar, for adding channels to teams.
- Adding retentionEnabledDefault check before showing warning message ([#20692](https://github.com/RocketChat/Rocket.Chat/pull/20692))
- Adding retentionEnabledDefault check before showing warning message ([#20692](https://github.com/RocketChat/Rocket.Chat/pull/20692) by [@yash-rajpal](https://github.com/yash-rajpal))
Added check for retentionEnabledDefault before showing prune warning message.
@ -3078,7 +3373,7 @@
}
```
- Visibility of burger menu on certain width ([#20736](https://github.com/RocketChat/Rocket.Chat/pull/20736))
- Visibility of burger menu on certain width ([#20736](https://github.com/RocketChat/Rocket.Chat/pull/20736) by [@yash-rajpal](https://github.com/yash-rajpal))
Burger was not visible on a certain width, specifically between 600 to 780. if width is more than 780px sidebar is shown, if less than 600 then burger icon was shown. But it wasn't shown between 600px to 780 px.
It was because for showing burger icon we were only checking for `isMobile` which is lenght only less than 600. So i added one more check for condition if length is less than 780 px.
- Checking 'start-discussion' Permission for MessageBox Actions ([#21564](https://github.com/RocketChat/Rocket.Chat/pull/21564))
- Checking 'start-discussion' Permission for MessageBox Actions ([#21564](https://github.com/RocketChat/Rocket.Chat/pull/21564) by [@yash-rajpal](https://github.com/yash-rajpal))
Permissions 'start-discussion-other-user' and 'start-discussion' are checked everywhere before letting anyone start any discussions, this permission check was missing for message box actions, so added it.
- Add missing `unreads` field to `users.info` REST endpoint ([#20905](https://github.com/RocketChat/Rocket.Chat/pull/20905))
- Added hideUnreadStatus check before showing unread messages on roomList ([#20867](https://github.com/RocketChat/Rocket.Chat/pull/20867))
- Added hideUnreadStatus check before showing unread messages on roomList ([#20867](https://github.com/RocketChat/Rocket.Chat/pull/20867) by [@yash-rajpal](https://github.com/yash-rajpal))
Added hide unread counter check, if the show unread messages is turned off, now unread messages badge won't be shown to user.
@ -4361,7 +4656,7 @@
- Replace wrong field description on Room Information panel ([#21395](https://github.com/RocketChat/Rocket.Chat/pull/21395) by [@rafaelblink](https://github.com/rafaelblink))
- Reply count of message is decreased after a message from thread is deleted ([#19977](https://github.com/RocketChat/Rocket.Chat/pull/19977))
- Reply count of message is decreased after a message from thread is deleted ([#19977](https://github.com/RocketChat/Rocket.Chat/pull/19977) by [@yash-rajpal](https://github.com/yash-rajpal))
The reply count now is decreased if a message from a thread is deleted.
@ -4578,7 +4873,7 @@
- Regression: When only 'teams' type is provided, show only rooms with teamMain on `rooms.adminRooms` endpoint ([#21322](https://github.com/RocketChat/Rocket.Chat/pull/21322))
- Close Call contextual bar after starting jitsi call. ([#21004](https://github.com/RocketChat/Rocket.Chat/pull/21004))
- Close Call contextual bar after starting jitsi call. ([#21004](https://github.com/RocketChat/Rocket.Chat/pull/21004) by [@yash-rajpal](https://github.com/yash-rajpal))
After jitsi call is started, if the call is started in a new window then we should close contextual tab bar.
So, when 'YES' is pressed on modal, we call handleClose function if openNewWindow is true, as call doesn't starts on tab bar, it starts on new window.
@ -4712,16 +5007,19 @@
- Missing spaces on attachment ([#21020](https://github.com/RocketChat/Rocket.Chat/pull/21020))
- Stopping Jitsi reload ([#20973](https://github.com/RocketChat/Rocket.Chat/pull/20973) by [@yash-rajpal](https://github.com/yash-rajpal))
The Function where Jitsi call is started gets called many times due to `room.usernames` dep of useMemo, this dep triggers reloading of this function many times.
- Added auto-focus for better user-experience. ([#19954](https://github.com/RocketChat/Rocket.Chat/pull/19954) by [@Darshilp326](https://github.com/Darshilp326))
- Added disable button check for send invite button ([#20337](https://github.com/RocketChat/Rocket.Chat/pull/20337))
- Added disable button check for send invite button ([#20337](https://github.com/RocketChat/Rocket.Chat/pull/20337) by [@yash-rajpal](https://github.com/yash-rajpal))
Added Disable check for send invite button. If the text field is empty button would be disabled, and after any valid email is filled, button would get enabled
- Added key prop, removing unwanted warnings ([#20473](https://github.com/RocketChat/Rocket.Chat/pull/20473) by [@yash-rajpal](https://github.com/yash-rajpal))
Removes warnings listed on the issue
- Added Markdown links to custom status. ([#20470](https://github.com/RocketChat/Rocket.Chat/pull/20470))
- Added Markdown links to custom status. ([#20470](https://github.com/RocketChat/Rocket.Chat/pull/20470) by [@yash-rajpal](https://github.com/yash-rajpal))
Added markdown links to user's custom status.
@ -4804,7 +5102,7 @@
It brings more flexibility, allowing us to use different hooks and different components for each header
- Check Livechat message length through REST API endpoint ([#20366](https://github.com/RocketChat/Rocket.Chat/pull/20366))
- Check Livechat message length through REST API endpoint ([#20366](https://github.com/RocketChat/Rocket.Chat/pull/20366) by [@yash-rajpal](https://github.com/yash-rajpal))
Added checks for message length for livechat message api, it shouldn't exceed specified character limit.
@ -4853,21 +5151,21 @@
Added tooltips to "Expand" and "Follow Message"/"Unfollow Message" in ThreadView for coherency.
- Added Bio Structure for UserCard, rendering Skeleton View on loading Instead of [Object][Object] ([#20305](https://github.com/RocketChat/Rocket.Chat/pull/20305))
- Added Bio Structure for UserCard, rendering Skeleton View on loading Instead of [Object][Object] ([#20305](https://github.com/RocketChat/Rocket.Chat/pull/20305) by [@yash-rajpal](https://github.com/yash-rajpal))
Added Bio Structure for rendering Skeleton View on loading UserCard.
- Added check for view admin permission page ([#20403](https://github.com/RocketChat/Rocket.Chat/pull/20403))
- Added check for view admin permission page ([#20403](https://github.com/RocketChat/Rocket.Chat/pull/20403) by [@yash-rajpal](https://github.com/yash-rajpal))
Admin Permission page was visible to all, if you add admin/permissions after the base url. This should not be visible to all user, only people with certain permissions should be able to see this page.
I am also able to see permissions page for open workspace of Rocket chat.
- Adding the accidentally deleted tag template, used by other templates ([#20772](https://github.com/RocketChat/Rocket.Chat/pull/20772))
- Adding the accidentally deleted tag template, used by other templates ([#20772](https://github.com/RocketChat/Rocket.Chat/pull/20772) by [@yash-rajpal](https://github.com/yash-rajpal))
Adding back accidentally deleted tag Template.
- Admin cannot clear user details like bio or nickname ([#20785](https://github.com/RocketChat/Rocket.Chat/pull/20785))
- Admin cannot clear user details like bio or nickname ([#20785](https://github.com/RocketChat/Rocket.Chat/pull/20785) by [@yash-rajpal](https://github.com/yash-rajpal))
When the API users.update is called to update user data, it passes data to saveUser function. Here before saving data like bio or nickname we are checking if they are available or not. If data is available then we are saving it, but we are not doing anything when data isn't available.
@ -4875,13 +5173,13 @@
- Admin Panel pages not visible in Safari ([#20912](https://github.com/RocketChat/Rocket.Chat/pull/20912))
- Announcement with multiple lines fixed. ([#20381](https://github.com/RocketChat/Rocket.Chat/pull/20381))
- Announcement with multiple lines fixed. ([#20381](https://github.com/RocketChat/Rocket.Chat/pull/20381) by [@yash-rajpal](https://github.com/yash-rajpal))
Announcements with multiple lines used to break UI for announcements bar. Fixed it by replacing all break lines in announcement with empty space (" ") . The announcement modal would work as usual and show all break lines.
- Atlassian Crowd login with 2FA enabled ([#20834](https://github.com/RocketChat/Rocket.Chat/pull/20834))
- Attachment download from title fixed ([#20585](https://github.com/RocketChat/Rocket.Chat/pull/20585))
- Attachment download from title fixed ([#20585](https://github.com/RocketChat/Rocket.Chat/pull/20585) by [@yash-rajpal](https://github.com/yash-rajpal))
Added target = '_self' to attachment link, this seems to fix the problem, without this attribute, error page is displayed.
- Fix Empty highlighted words field ([#20329](https://github.com/RocketChat/Rocket.Chat/pull/20329))
- Fix Empty highlighted words field ([#20329](https://github.com/RocketChat/Rocket.Chat/pull/20329) by [@yash-rajpal](https://github.com/yash-rajpal))
Able to Empty the highlighted text field in preferences
@ -5028,7 +5326,7 @@
- Add a new setting ("Add Reply-To header") in the Email settings' page to control when the Reply-To header is used in e-mail notifications;
- The new setting is turned off (`false` value) by default.
- New Integration page was not being displayed ([#20670](https://github.com/RocketChat/Rocket.Chat/pull/20670))
- New Integration page was not being displayed ([#20670](https://github.com/RocketChat/Rocket.Chat/pull/20670) by [@yash-rajpal](https://github.com/yash-rajpal))
- Notification worker stopping on error ([#20605](https://github.com/RocketChat/Rocket.Chat/pull/20605))
- Attachment download from title fixed ([#20585](https://github.com/RocketChat/Rocket.Chat/pull/20585))
- Attachment download from title fixed ([#20585](https://github.com/RocketChat/Rocket.Chat/pull/20585) by [@yash-rajpal](https://github.com/yash-rajpal))
Added target = '_self' to attachment link, this seems to fix the problem, without this attribute, error page is displayed.
Made user avatar change buttons to be descriptive of what they do.
- Tooltip added for Kebab menu on chat header ([#20116](https://github.com/RocketChat/Rocket.Chat/pull/20116))
- Tooltip added for Kebab menu on chat header ([#20116](https://github.com/RocketChat/Rocket.Chat/pull/20116) by [@yash-rajpal](https://github.com/yash-rajpal))
Added the missing Tooltip for kebab menu on chat header.
Users can be removed from channels without any error message.
- Added context check for closing active tabbar for member-list ([#20228](https://github.com/RocketChat/Rocket.Chat/pull/20228))
- Added context check for closing active tabbar for member-list ([#20228](https://github.com/RocketChat/Rocket.Chat/pull/20228) by [@yash-rajpal](https://github.com/yash-rajpal))
When we click on a username and then click on see user's full profile, a tab gets active and shows us the user's profile, the problem occurs when the tab is still active and we try to see another user's profile. In this case, tabbar gets closed.
To resolve this, added context check for closing action of active tabbar.
- Added Margin between status bullet and status label ([#20199](https://github.com/RocketChat/Rocket.Chat/pull/20199))
- Added Margin between status bullet and status label ([#20199](https://github.com/RocketChat/Rocket.Chat/pull/20199) by [@yash-rajpal](https://github.com/yash-rajpal))
Added Margins between status bullet and status label
@ -5547,7 +5845,7 @@
After changes made on https://github.com/RocketChat/Rocket.Chat/pull/19931, the `Livechat.RegisterGuest` method started removing properties from the visitor inappropriately. The properties that did not receive value were removed from the object.
Those changes were made to support the new Contact Form, but now the form has its own method to deal with Contact data so those changes are no longer necessary.
- Markdown added for Header Room topic ([#20021](https://github.com/RocketChat/Rocket.Chat/pull/20021))
- Markdown added for Header Room topic ([#20021](https://github.com/RocketChat/Rocket.Chat/pull/20021) by [@yash-rajpal](https://github.com/yash-rajpal))
With the new 3.10.0 version update the Links in topic section below room name were not working, for more info refer issue #20018
Guilherme Gazzo
3 years ago