Regression: UserCard "See full profile" link broken (#19941)

pull/19948/head
Douglas Fabris 4 years ago committed by GitHub
parent bf26a705ca
commit 8fc42cbeef
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 8
      app/threads/client/components/ThreadComponent.tsx
  2. 4
      app/ui/client/views/app/lib/getCommonRoomEvents.js
  3. 3
      client/components/UserCard.js

@ -68,7 +68,7 @@ const ThreadComponent: FC<{
const channelRoute = useRoute(roomTypes.getConfig(room.t).route.name);
const threadMessage = useThreadMessage(mid);
const open = useTabBarOpenUserInfo();
const openUserInfo = useTabBarOpenUserInfo();
const ref = useRef<Element>(null);
const uid = useUserId();
@ -107,7 +107,7 @@ const ThreadComponent: FC<{
following,
subscription,
rid: room._id,
openProfileTab: open,
tabBar: { openUserInfo },
}));
useEffect(() => {
@ -122,10 +122,10 @@ const ThreadComponent: FC<{
following,
subscription,
rid: room._id,
openProfileTab: open,
tabBar: { openUserInfo },
};
});
}, [following, jump, open, room._id, subscription, threadMessage]);
}, [following, jump, openUserInfo, room._id, subscription, threadMessage]);
useEffect(() => {
if (!ref.current || !viewData.mainMessage) {

@ -208,7 +208,7 @@ export const getCommonRoomEvents = () => ({
target: e.currentTarget,
open: (e) => {
e.preventDefault();
instance.data.openProfileTab(username);
instance.data.tabBar.openUserInfo(username);
},
});
}
@ -309,7 +309,7 @@ export const getCommonRoomEvents = () => ({
target: e.currentTarget,
open: (e) => {
e.preventDefault();
instance.data.openProfileTab(username);
instance.data.tabBar.openUserInfo(username);
},
});
}

@ -36,9 +36,8 @@ const Roles = ({ children }) => <Info rcx-user-card__roles m='neg-x2' flexWrap='
{children}
</Info>;
const Role = ({ children }) => <Box m='x2'><Tag
const Role = ({ children }) => <Box m='x2' fontScale='c2'><Tag
disabled
fontScale='c2'
children={children}
/></Box>;

Loading…
Cancel
Save