regression: `saveGuest` triggering app events for invalid visitor ids (#31037)

pull/31034/head^2
Kevin Aleman 3 years ago committed by GitHub
parent dd3ecd6f18
commit 9045c0d09b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 6
      apps/meteor/app/livechat/server/lib/LivechatTyped.ts

@ -1343,6 +1343,12 @@ class LivechatClass {
async saveGuest(guestData: Pick<ILivechatVisitor, '_id' | 'name' | 'livechatData'> & { email?: string; phone?: string }, userId: string) {
const { _id, name, email, phone, livechatData = {} } = guestData;
const visitor = await LivechatVisitors.findOneById(_id, { projection: { _id: 1 } });
if (!visitor) {
throw new Error('error-invalid-visitor');
}
this.logger.debug({ msg: 'Saving guest', guestData });
const updateData: {
name?: string | undefined;

Loading…
Cancel
Save