From 90e81fa8799b1b2357636d8b0048d37f78aa94d3 Mon Sep 17 00:00:00 2001
From: Douglas Fabris <devfabris@gmail.com>
Date: Tue, 19 Dec 2023 11:41:39 -0300
Subject: [PATCH] regression: `PageHeader` back button must be an `IconButton`
 (#31266)

---
 .../client/components/Page/PageHeader.tsx     |  8 ++-----
 .../views/admin/emailInbox/EmailInboxPage.tsx | 14 +++++-------
 .../views/admin/import/NewImportPage.tsx      |  9 +-------
 .../views/admin/import/PrepareImportPage.tsx  |  9 +-------
 .../incoming/EditIncomingWebhook.tsx          |  5 +----
 .../outgoing/EditOutgoingWebhook.tsx          |  5 +----
 .../history/OutgoingWebhookHistoryPage.tsx    |  8 +++----
 .../views/admin/oauthApps/OAuthAppsPage.tsx   | 22 ++++++++-----------
 .../departments/EditDepartment.tsx            | 15 ++++---------
 .../cannedResponses/CannedResponseEdit.tsx    | 16 +++++++-------
 10 files changed, 36 insertions(+), 75 deletions(-)

diff --git a/apps/meteor/client/components/Page/PageHeader.tsx b/apps/meteor/client/components/Page/PageHeader.tsx
index e955ac20a52..25d20381e52 100644
--- a/apps/meteor/client/components/Page/PageHeader.tsx
+++ b/apps/meteor/client/components/Page/PageHeader.tsx
@@ -1,4 +1,4 @@
-import { Box, Button } from '@rocket.chat/fuselage';
+import { Box, IconButton } from '@rocket.chat/fuselage';
 import { HeaderToolbox, useDocumentTitle } from '@rocket.chat/ui-client';
 import { useLayout, useTranslation } from '@rocket.chat/ui-contexts';
 import type { FC, ComponentProps, ReactNode } from 'react';
@@ -35,14 +35,10 @@ const PageHeader: FC<PageHeaderProps> = ({ children = undefined, title, onClickB
 						<BurgerMenu />
 					</HeaderToolbox>
 				)}
+				{onClickBack && <IconButton small mie={8} icon='arrow-back' onClick={onClickBack} title={t('Back')} />}
 				<Box is='h1' fontScale='h2' flexGrow={1} data-qa-type='PageHeader-title'>
 					{title}
 				</Box>
-				{onClickBack && (
-					<Button icon='back' onClick={onClickBack}>
-						{t('Back')}
-					</Button>
-				)}
 				{children}
 			</Box>
 		</Box>
diff --git a/apps/meteor/client/views/admin/emailInbox/EmailInboxPage.tsx b/apps/meteor/client/views/admin/emailInbox/EmailInboxPage.tsx
index 97078208b09..12eb42cf789 100644
--- a/apps/meteor/client/views/admin/emailInbox/EmailInboxPage.tsx
+++ b/apps/meteor/client/views/admin/emailInbox/EmailInboxPage.tsx
@@ -1,5 +1,5 @@
 import { Button } from '@rocket.chat/fuselage';
-import { useRoute, useRouteParameter, useTranslation } from '@rocket.chat/ui-contexts';
+import { useRouteParameter, useRouter, useTranslation } from '@rocket.chat/ui-contexts';
 import type { ReactElement } from 'react';
 import React from 'react';
 
@@ -10,21 +10,17 @@ import EmailInboxTable from './EmailInboxTable';
 
 const EmailInboxPage = (): ReactElement => {
 	const t = useTranslation();
+	const router = useRouter();
+
 	const id = useRouteParameter('_id');
 	const context = useRouteParameter('context');
-	const emailInboxRoute = useRoute('admin-email-inboxes');
 
 	return (
 		<Page flexDirection='row'>
 			<Page>
-				<PageHeader title={t('Email_Inboxes')}>
-					{context && (
-						<Button icon='back' onClick={(): void => emailInboxRoute.push({})}>
-							{t('Back')}
-						</Button>
-					)}
+				<PageHeader title={t('Email_Inboxes')} onClickBack={context ? () => router.navigate('/admin/email-inboxes') : undefined}>
 					{!context && (
-						<Button primary onClick={(): void => emailInboxRoute.push({ context: 'new' })}>
+						<Button primary onClick={() => router.navigate('/admin/email-inboxes/new')}>
 							{t('New_Email_Inbox')}
 						</Button>
 					)}
diff --git a/apps/meteor/client/views/admin/import/NewImportPage.tsx b/apps/meteor/client/views/admin/import/NewImportPage.tsx
index 44771e44f65..82422c1f27c 100644
--- a/apps/meteor/client/views/admin/import/NewImportPage.tsx
+++ b/apps/meteor/client/views/admin/import/NewImportPage.tsx
@@ -44,10 +44,6 @@ function NewImportPage() {
 
 	const formatMemorySize = useFormatMemorySize();
 
-	const handleBackToImportsButtonClick = () => {
-		router.navigate('/admin/import');
-	};
-
 	const handleImporterKeyChange = (importerKey: Key) => {
 		if (typeof importerKey !== 'string') {
 			return;
@@ -189,11 +185,8 @@ function NewImportPage() {
 
 	return (
 		<Page className='page-settings'>
-			<PageHeader title={t('Import_New_File')}>
+			<PageHeader title={t('Import_New_File')} onClickBack={() => router.navigate('/admin/import')}>
 				<ButtonGroup>
-					<Button icon='back' secondary onClick={handleBackToImportsButtonClick}>
-						{t('Back_to_imports')}
-					</Button>
 					{importer && (
 						<Button primary minHeight='x40' loading={isLoading} onClick={handleImportButtonClick}>
 							{t('Import')}
diff --git a/apps/meteor/client/views/admin/import/PrepareImportPage.tsx b/apps/meteor/client/views/admin/import/PrepareImportPage.tsx
index b6d378c60bd..39002b3c308 100644
--- a/apps/meteor/client/views/admin/import/PrepareImportPage.tsx
+++ b/apps/meteor/client/views/admin/import/PrepareImportPage.tsx
@@ -147,10 +147,6 @@ function PrepareImportPage() {
 		loadCurrentOperation();
 	}, [getCurrentImportOperation, getImportFileData, handleError, router, setMessageCount, setPreparing, setProgressRate, setStatus, t]);
 
-	const handleBackToImportsButtonClick = () => {
-		router.navigate('/admin/import');
-	};
-
 	const handleStartButtonClick = async () => {
 		setImporting(true);
 
@@ -180,11 +176,8 @@ function PrepareImportPage() {
 
 	return (
 		<Page>
-			<PageHeader title={t('Importing_Data')}>
+			<PageHeader title={t('Importing_Data')} onClickBack={() => router.navigate('/admin/import')}>
 				<ButtonGroup>
-					<Button icon='back' secondary onClick={handleBackToImportsButtonClick}>
-						{t('Back_to_imports')}
-					</Button>
 					<Button primary disabled={isImporting || handleMinimumImportData} onClick={handleStartButtonClick}>
 						{t('Importer_Prepare_Start_Import')}
 					</Button>
diff --git a/apps/meteor/client/views/admin/integrations/incoming/EditIncomingWebhook.tsx b/apps/meteor/client/views/admin/integrations/incoming/EditIncomingWebhook.tsx
index d76f4fb65da..87a29dcce5c 100644
--- a/apps/meteor/client/views/admin/integrations/incoming/EditIncomingWebhook.tsx
+++ b/apps/meteor/client/views/admin/integrations/incoming/EditIncomingWebhook.tsx
@@ -77,11 +77,8 @@ const EditIncomingWebhook = ({ webhookData }: { webhookData?: Serialized<IIncomi
 
 	return (
 		<Page flexDirection='column'>
-			<PageHeader title={t('Integration_Incoming_WebHook')}>
+			<PageHeader title={t('Integration_Incoming_WebHook')} onClickBack={() => router.navigate('/admin/integrations/webhook-incoming')}>
 				<ButtonGroup>
-					<Button icon='back' onClick={() => router.navigate('/admin/integrations/webhook-incoming')}>
-						{t('Back')}
-					</Button>
 					{webhookData?._id && (
 						<Button danger onClick={handleDeleteIntegration}>
 							{t('Delete')}
diff --git a/apps/meteor/client/views/admin/integrations/outgoing/EditOutgoingWebhook.tsx b/apps/meteor/client/views/admin/integrations/outgoing/EditOutgoingWebhook.tsx
index b96eb6f0ead..a8a3c1b8f50 100644
--- a/apps/meteor/client/views/admin/integrations/outgoing/EditOutgoingWebhook.tsx
+++ b/apps/meteor/client/views/admin/integrations/outgoing/EditOutgoingWebhook.tsx
@@ -100,11 +100,8 @@ const EditOutgoingWebhook = ({ webhookData }: { webhookData?: Serialized<IOutgoi
 
 	return (
 		<Page flexDirection='column'>
-			<PageHeader title={t('Integration_Outgoing_WebHook')}>
+			<PageHeader title={t('Integration_Outgoing_WebHook')} onClickBack={() => router.navigate('/admin/integrations/webhook-outgoing')}>
 				<ButtonGroup>
-					<Button icon='back' onClick={() => router.navigate('/admin/integrations/webhook-outgoing')}>
-						{t('Back')}
-					</Button>
 					{webhookData?._id && (
 						<Button onClick={() => router.navigate(`/admin/integrations/history/outgoing/${webhookData._id}`)}>{t('History')}</Button>
 					)}
diff --git a/apps/meteor/client/views/admin/integrations/outgoing/history/OutgoingWebhookHistoryPage.tsx b/apps/meteor/client/views/admin/integrations/outgoing/history/OutgoingWebhookHistoryPage.tsx
index cacc5757819..8b7b96d711f 100644
--- a/apps/meteor/client/views/admin/integrations/outgoing/history/OutgoingWebhookHistoryPage.tsx
+++ b/apps/meteor/client/views/admin/integrations/outgoing/history/OutgoingWebhookHistoryPage.tsx
@@ -106,11 +106,11 @@ const OutgoingWebhookHistoryPage = (props: ComponentProps<typeof Page>) => {
 
 	return (
 		<Page flexDirection='column' {...props}>
-			<PageHeader title={t('Integration_Outgoing_WebHook_History')}>
+			<PageHeader
+				title={t('Integration_Outgoing_WebHook_History')}
+				onClickBack={() => router.navigate(`/admin/integrations/edit/outgoing/${id}`)}
+			>
 				<ButtonGroup>
-					<Button icon='back' onClick={() => router.navigate(`/admin/integrations/edit/outgoing/${id}`)}>
-						{t('Back')}
-					</Button>
 					<Button icon='trash' danger onClick={handleClearHistory} disabled={total === 0}>
 						{t('clear_history')}
 					</Button>
diff --git a/apps/meteor/client/views/admin/oauthApps/OAuthAppsPage.tsx b/apps/meteor/client/views/admin/oauthApps/OAuthAppsPage.tsx
index c5cd7f5fc96..cc9e174948e 100644
--- a/apps/meteor/client/views/admin/oauthApps/OAuthAppsPage.tsx
+++ b/apps/meteor/client/views/admin/oauthApps/OAuthAppsPage.tsx
@@ -1,5 +1,5 @@
-import { Button } from '@rocket.chat/fuselage';
-import { useRouteParameter, useRoute, useTranslation } from '@rocket.chat/ui-contexts';
+import { Button, ButtonGroup } from '@rocket.chat/fuselage';
+import { useRouteParameter, useTranslation, useRouter } from '@rocket.chat/ui-contexts';
 import type { ReactElement } from 'react';
 import React from 'react';
 
@@ -10,8 +10,7 @@ import OAuthAppsTable from './OAuthAppsTable';
 
 const OAuthAppsPage = (): ReactElement => {
 	const t = useTranslation();
-
-	const router = useRoute('admin-oauth-apps');
+	const router = useRouter();
 
 	const context = useRouteParameter('context');
 	const id = useRouteParameter('id');
@@ -19,16 +18,13 @@ const OAuthAppsPage = (): ReactElement => {
 	return (
 		<Page flexDirection='row'>
 			<Page>
-				<PageHeader title={t('Third_party_login')}>
-					{context && (
-						<Button icon='back' alignSelf='flex-end' onClick={(): void => router.push({})}>
-							{t('Back')}
-						</Button>
-					)}
+				<PageHeader title={t('Third_party_login')} onClickBack={context ? () => router.navigate('/admin/third-party-login') : undefined}>
 					{!context && (
-						<Button primary alignSelf='flex-end' onClick={(): void => router.push({ context: 'new' })}>
-							{t('New_Application')}
-						</Button>
+						<ButtonGroup>
+							<Button primary onClick={() => router.navigate('/admin/third-party-login/new')}>
+								{t('New_Application')}
+							</Button>
+						</ButtonGroup>
 					)}
 				</PageHeader>
 				<PageContent>
diff --git a/apps/meteor/client/views/omnichannel/departments/EditDepartment.tsx b/apps/meteor/client/views/omnichannel/departments/EditDepartment.tsx
index 8b5c2cc80a6..0f64e41d242 100644
--- a/apps/meteor/client/views/omnichannel/departments/EditDepartment.tsx
+++ b/apps/meteor/client/views/omnichannel/departments/EditDepartment.tsx
@@ -17,7 +17,7 @@ import {
 	FieldHint,
 } from '@rocket.chat/fuselage';
 import { useDebouncedValue, useMutableCallback, useUniqueId } from '@rocket.chat/fuselage-hooks';
-import { useToastMessageDispatch, useRoute, useMethod, useEndpoint, useTranslation } from '@rocket.chat/ui-contexts';
+import { useToastMessageDispatch, useMethod, useEndpoint, useTranslation, useRouter } from '@rocket.chat/ui-contexts';
 import { useQueryClient } from '@tanstack/react-query';
 import React, { useMemo, useState } from 'react';
 import { Controller, useForm } from 'react-hook-form';
@@ -100,7 +100,7 @@ const getInitialValues = ({ department, agents, allowedToForwardData }: InitialV
 
 function EditDepartment({ data, id, title, allowedToForwardData }: EditDepartmentProps) {
 	const t = useTranslation();
-	const departmentsRoute = useRoute('omnichannel-departments');
+	const router = useRouter();
 	const queryClient = useQueryClient();
 
 	const { department, agents = [] } = data || {};
@@ -195,16 +195,12 @@ function EditDepartment({ data, id, title, allowedToForwardData }: EditDepartmen
 			}
 			queryClient.invalidateQueries(['/v1/livechat/department/:_id', id]);
 			dispatchToastMessage({ type: 'success', message: t('Saved') });
-			departmentsRoute.push({});
+			router.navigate('/omnichannel/departments');
 		} catch (error) {
 			dispatchToastMessage({ type: 'error', message: error });
 		}
 	});
 
-	const handleReturn = useMutableCallback(() => {
-		departmentsRoute.push({});
-	});
-
 	const isFormValid = isValid && isDirty;
 
 	const formId = useUniqueId();
@@ -222,11 +218,8 @@ function EditDepartment({ data, id, title, allowedToForwardData }: EditDepartmen
 	return (
 		<Page flexDirection='row'>
 			<Page>
-				<PageHeader title={title}>
+				<PageHeader title={title} onClickBack={() => router.navigate('/omnichannel/departments')}>
 					<ButtonGroup>
-						<Button icon='back' onClick={handleReturn}>
-							{t('Back')}
-						</Button>
 						<Button type='submit' form={formId} primary disabled={!isFormValid} loading={isSubmitting}>
 							{t('Save')}
 						</Button>
diff --git a/apps/meteor/ee/client/omnichannel/cannedResponses/CannedResponseEdit.tsx b/apps/meteor/ee/client/omnichannel/cannedResponses/CannedResponseEdit.tsx
index 0cdbcae396f..3c903d57151 100644
--- a/apps/meteor/ee/client/omnichannel/cannedResponses/CannedResponseEdit.tsx
+++ b/apps/meteor/ee/client/omnichannel/cannedResponses/CannedResponseEdit.tsx
@@ -66,17 +66,17 @@ const CannedResponseEdit = ({ cannedResponseData }: CannedResponseEditProps) =>
 
 	return (
 		<Page>
-			<PageHeader title={cannedResponseData?._id ? t('Edit_CannedResponse') : t('New_CannedResponse')}>
-				<ButtonGroup>
-					<Button icon='back' onClick={() => router.navigate('/omnichannel/canned-responses')}>
-						{t('Back')}
-					</Button>
-					{cannedResponseData?._id && (
+			<PageHeader
+				title={cannedResponseData?._id ? t('Edit_CannedResponse') : t('New_CannedResponse')}
+				onClickBack={() => router.navigate('/omnichannel/canned-responses')}
+			>
+				{cannedResponseData?._id && (
+					<ButtonGroup>
 						<Button danger onClick={() => handleDelete(cannedResponseData._id)}>
 							{t('Delete')}
 						</Button>
-					)}
-				</ButtonGroup>
+					</ButtonGroup>
+				)}
 			</PageHeader>
 			<PageScrollableContentWithShadow>
 				<FormProvider {...methods}>