From c44331e0d9b0e4e04d1ec64bea74b439a1125aa0 Mon Sep 17 00:00:00 2001
From: Douglas Gubert <douglas.gubert@gmail.com>
Date: Wed, 19 Mar 2025 21:08:15 -0300
Subject: [PATCH] fix: IPreRoomCreateModify not persisting changes made by apps
 (#35342)

---
 .changeset/pretty-dragons-remain.md                         | 6 ++++++
 .../apps-engine/src/server/managers/AppListenerManager.ts   | 3 ++-
 2 files changed, 8 insertions(+), 1 deletion(-)
 create mode 100644 .changeset/pretty-dragons-remain.md

diff --git a/.changeset/pretty-dragons-remain.md b/.changeset/pretty-dragons-remain.md
new file mode 100644
index 00000000000..aa022f9766e
--- /dev/null
+++ b/.changeset/pretty-dragons-remain.md
@@ -0,0 +1,6 @@
+---
+'@rocket.chat/apps-engine': patch
+'@rocket.chat/meteor': patch
+---
+
+Fixes an issue that prevents modifications from being persisted in the IPreRoomCreateModify
diff --git a/packages/apps-engine/src/server/managers/AppListenerManager.ts b/packages/apps-engine/src/server/managers/AppListenerManager.ts
index 2d6cd25e62a..2b862dab0ef 100644
--- a/packages/apps-engine/src/server/managers/AppListenerManager.ts
+++ b/packages/apps-engine/src/server/managers/AppListenerManager.ts
@@ -326,6 +326,7 @@ export class AppListenerManager {
         return !!(lockedEventList && lockedEventList.size);
     }
 
+    /* eslint-disable-next-line complexity */
     public async executeListener<I extends keyof IListenerExecutor>(int: I, data: IListenerExecutor[I]['args'][0]): Promise<IListenerExecutor[I]['result']> {
         if (this.isEventBlocked(int)) {
             throw new EssentialAppDisabledException('There is one or more apps that are essential to this event but are disabled');
@@ -794,7 +795,7 @@ export class AppListenerManager {
             }
         }
 
-        return data;
+        return room;
     }
 
     private async executePostRoomCreate(data: IRoom): Promise<void> {