[FIX] Wrong user in user info (#21451)

pull/19987/head^2
gabriellsh 5 years ago committed by GitHub
parent 8f7cf1dab9
commit d6ff6bddb8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 7
      client/views/admin/users/UsersPage.js
  2. 21
      client/views/room/MemberListRouter.js

@ -3,10 +3,10 @@ import React from 'react';
import Page from '../../../components/Page';
import VerticalBar from '../../../components/VerticalBar';
import { useRouteParameter, useRoute } from '../../../contexts/RouterContext';
import { useRoute, useCurrentRoute } from '../../../contexts/RouterContext';
import { useTranslation } from '../../../contexts/TranslationContext';
import { AddUser } from './AddUser';
import EditUserWithData from './EditUserWithData';
import EditUserWithData from './EditUser';
import { InviteUsers } from './InviteUsers';
import { UserInfoWithData } from './UserInfo';
import UsersTable from './UsersTable';
@ -28,8 +28,7 @@ function UsersPage() {
usersRoute.push({ context: 'invite' });
};
const context = useRouteParameter('context');
const id = useRouteParameter('id');
const [, { context, id }] = useCurrentRoute();
return (
<Page flexDirection='row'>

@ -6,6 +6,18 @@ import UserInfo from './contextualBar/UserInfo';
import { useRoom } from './providers/RoomProvider';
import { useTab, useTabBarClose, useTabContext } from './providers/ToolboxProvider';
const getUid = (room, ownUserId) => {
if (room.uids.length === 1) {
return room.uids[0];
}
const uid = room.uids.filter((uid) => uid !== ownUserId).shift();
// Self DMs used to be created with the userId duplicated.
// Sometimes rooms can have 2 equal uids, but it's a self DM.
return uid ?? room.uids[0];
};
const MemberListRouter = ({ rid }) => {
const username = useTabContext();
const room = useRoom();
@ -22,14 +34,7 @@ const MemberListRouter = ({ rid }) => {
return (
<UserInfo
width='100%'
{...(username
? { username }
: {
uid:
room.uids.length === 1
? room.uids[0]
: room.uids.filter((uid) => uid !== ownUserId).shift(),
})}
{...(username ? { username } : { uid: getUid(room, ownUserId) })}
onClose={onClickClose}
rid={rid}
/>

Loading…
Cancel
Save