fix(UsersTable): mark remote users' registration as "Federated" instead of "Pending" (#33873)

.changeset/empty-pans-love.md

@@ -0,0 +1,6 @@
+---
+"@rocket.chat/meteor": patch
+"@rocket.chat/i18n": patch
+---
+
+Fixes the incorrect registration status shown on admin users page for federated remote users.

apps/meteor/client/views/admin/users/UsersTable/UsersTableRow.tsx

@@ -42,10 +42,32 @@ const UsersTableRow = ({
 }: UsersTableRowProps): ReactElement => {
 	const { t } = useTranslation();
 
-	const { _id, emails, username = '', name = '', roles, status, active, avatarETag, lastLogin, type, freeSwitchExtension } = user;
+	const {
+		_id,
+		emails,
+		username = '',
+		name = '',
+		roles,
+		status,
+		active,
+		avatarETag,
+		lastLogin,
+		type,
+		freeSwitchExtension,
+		federated,
+	} = user;
+
 	const registrationStatusText = useMemo(() => {
 		const usersExcludedFromPending = ['bot', 'app'];
 
+		if (!active && lastLogin) {
+			return t('Deactivated');
+		}
+
+		if (federated) {
+			return t('Federated');
+		}
+
 		if (!lastLogin && !usersExcludedFromPending.includes(type)) {
 			return t('Pending');
 		}
@@ -53,11 +75,7 @@ const UsersTableRow = ({
 		if (active && lastLogin) {
 			return t('Active');
 		}
-
-		if (!active && lastLogin) {
-			return t('Deactivated');
-		}
-	}, [active, lastLogin, t, type]);
+	}, [active, lastLogin, t, type, federated]);
 
 	const roleNames = (roles || [])
 		.map((roleId) => (Roles.findOne(roleId, { fields: { name: 1 } }) as IRole | undefined)?.name)

packages/i18n/src/locales/en.i18n.json

@@ -2428,6 +2428,7 @@
   "Federation_Matrix_serve_well_known_Alert": "Keep this off if using DNS srv records for federation, or use a reverse proxy to return static JSON if federation traffic is heavy. <a target=\"_blank\" href=\"https://matrix-org.github.io/synapse/latest/federate.html\">Read mode</a>.",
   "Federation_Matrix_check_configuration": "Verify configuration",
   "Federation_Matrix_configuration_status": "Configuration status",
+  "Federated": "Federated",
   "Field": "Field",
   "Field_removed": "Field removed",
   "Field_required": "Field required",