refactor: Ditch `Meteor.user` in favor of `Meteor.userAsync` - 1x (#28601)

Co-authored-by: Rodrigo Nascimento <234261+rodrigok@users.noreply.github.com>

apps/meteor/app/2fa/server/methods/checkCodesRemaining.ts

@@ -9,12 +9,12 @@ declare module '@rocket.chat/ui-contexts' {
 }
 
 Meteor.methods<ServerMethods>({
-	'2fa:checkCodesRemaining'() {
+	async '2fa:checkCodesRemaining'() {
 		if (!Meteor.userId()) {
 			throw new Meteor.Error('not-authorized');
 		}
 
-		const user = Meteor.user();
+		const user = await Meteor.userAsync();
 
 		if (!user) {
 			throw new Meteor.Error('error-invalid-user', 'Invalid user', {

apps/meteor/app/2fa/server/methods/disable.ts

@@ -12,13 +12,13 @@ declare module '@rocket.chat/ui-contexts' {
 }
 
 Meteor.methods<ServerMethods>({
-	'2fa:disable'(code) {
+	async '2fa:disable'(code) {
 		const userId = Meteor.userId();
 		if (!userId) {
 			throw new Meteor.Error('not-authorized');
 		}
 
-		const user = Meteor.user();
+		const user = await Meteor.userAsync();
 
 		if (!user) {
 			throw new Meteor.Error('error-invalid-user', 'Invalid user', {

apps/meteor/app/2fa/server/methods/enable.ts

@@ -12,13 +12,13 @@ declare module '@rocket.chat/ui-contexts' {
 }
 
 Meteor.methods<ServerMethods>({
-	'2fa:enable'() {
+	async '2fa:enable'() {
 		const userId = Meteor.userId();
 		if (!userId) {
 			throw new Meteor.Error('not-authorized');
 		}
 
-		const user = Meteor.user();
+		const user = await Meteor.userAsync();
 
 		if (!user?.username) {
 			throw new Meteor.Error('error-invalid-user', 'Invalid user', {

apps/meteor/app/2fa/server/methods/regenerateCodes.ts

@@ -12,13 +12,13 @@ declare module '@rocket.chat/ui-contexts' {
 }
 
 Meteor.methods<ServerMethods>({
-	'2fa:regenerateCodes'(userToken) {
+	async '2fa:regenerateCodes'(userToken) {
 		const userId = Meteor.userId();
 		if (!userId) {
 			throw new Meteor.Error('not-authorized');
 		}
 
-		const user = Meteor.user();
+		const user = await Meteor.userAsync();
 		if (!user) {
 			throw new Meteor.Error('error-invalid-user', 'Invalid user', {
 				method: '2fa:regenerateCodes',

apps/meteor/app/2fa/server/methods/validateTempToken.ts

@@ -12,13 +12,13 @@ declare module '@rocket.chat/ui-contexts' {
 }
 
 Meteor.methods<ServerMethods>({
-	'2fa:validateTempToken'(userToken) {
+	async '2fa:validateTempToken'(userToken) {
 		const userId = Meteor.userId();
 		if (!userId) {
 			throw new Meteor.Error('not-authorized');
 		}
 
-		const user = Meteor.user();
+		const user = await Meteor.userAsync();
 		if (!user) {
 			throw new Meteor.Error('error-invalid-user', 'Invalid user', {
 				method: '2fa:validateTempToken',

apps/meteor/app/channel-settings/server/methods/saveRoomSettings.ts

@@ -448,7 +448,7 @@ async function saveRoomSettings(
 		});
 	}
 
-	const user = Meteor.user() as (IUser & Required<Pick<IUser, 'username' | 'name'>>) | null;
+	const user = (await Meteor.userAsync()) as (IUser & Required<Pick<IUser, 'username' | 'name'>>) | null;
 	if (!user) {
 		throw new Meteor.Error('error-invalid-user', 'Invalid user', {
 			method: 'saveRoomSettings',

apps/meteor/app/crowd/server/methods.ts

@@ -16,7 +16,7 @@ declare module '@rocket.chat/ui-contexts' {
 
 Meteor.methods<ServerMethods>({
 	async crowd_test_connection() {
-		const user = Meteor.user();
+		const user = await Meteor.userAsync();
 		if (!user) {
 			throw new Meteor.Error('error-invalid-user', 'Invalid user', {
 				method: 'crowd_test_connection',
@@ -50,7 +50,7 @@ Meteor.methods<ServerMethods>({
 		}
 	},
 	async crowd_sync_users() {
-		const user = Meteor.user();
+		const user = await Meteor.userAsync();
 		if (settings.get('CROWD_Enable') !== true) {
 			throw new Meteor.Error('crowd_disabled');
 		}

apps/meteor/app/discussion/server/methods/createDiscussion.ts

@@ -212,6 +212,6 @@ Meteor.methods<ServerMethods>({
 			throw new Meteor.Error('error-action-not-allowed', 'You are not allowed to create a discussion', { method: 'createDiscussion' });
 		}
 
-		return create({ prid, pmid, t_name: discussionName, reply, users, user: Meteor.user() as IUser, encrypted });
+		return create({ prid, pmid, t_name: discussionName, reply, users, user: (await Meteor.userAsync()) as IUser, encrypted });
 	},
 });

apps/meteor/app/emoji-custom/server/methods/listEmojiCustom.ts

@@ -17,7 +17,7 @@ Meteor.methods<ServerMethods>({
 	async listEmojiCustom(options = {}) {
 		methodDeprecationLogger.warn('listEmojiCustom will be removed in future versions of Rocket.Chat');
 
-		const user = Meteor.user();
+		const user = await Meteor.userAsync();
 
 		if (!user) {
 			throw new Meteor.Error('error-invalid-user', 'Invalid user', {

apps/meteor/app/file-upload/server/methods/sendFileMessage.ts

@@ -128,7 +128,7 @@ declare module '@rocket.chat/ui-contexts' {
 
 Meteor.methods<ServerMethods>({
 	async sendFileMessage(roomId, _store, file, msgData = {}) {
-		const user = Meteor.user() as IUser | undefined;
+		const user = (await Meteor.userAsync()) as IUser | undefined;
 		if (!user) {
 			throw new Meteor.Error('error-invalid-user', 'Invalid user', {
 				method: 'sendFileMessage',

apps/meteor/app/lib/server/functions/archiveRoom.ts

@@ -3,10 +3,10 @@ import { Meteor } from 'meteor/meteor';
 import { Rooms, Messages, Subscriptions } from '../../../models/server';
 import { callbacks } from '../../../../lib/callbacks';
 
-export const archiveRoom = function (rid: string): void {
+export const archiveRoom = async function (rid: string): Promise<void> {
 	Rooms.archiveById(rid);
 	Subscriptions.archiveByRoomId(rid);
-	Messages.createRoomArchivedByRoomIdAndUser(rid, Meteor.user());
+	Messages.createRoomArchivedByRoomIdAndUser(rid, await Meteor.userAsync());
 
-	callbacks.run('afterRoomArchived', Rooms.findOneById(rid), Meteor.user());
+	callbacks.run('afterRoomArchived', Rooms.findOneById(rid), await Meteor.userAsync());
 };

apps/meteor/app/lib/server/functions/unarchiveRoom.ts

@@ -2,8 +2,8 @@ import { Meteor } from 'meteor/meteor';
 
 import { Rooms, Messages, Subscriptions } from '../../../models/server';
 
-export const unarchiveRoom = function (rid: string): void {
+export const unarchiveRoom = async function (rid: string): Promise<void> {
 	Rooms.unarchiveById(rid);
 	Subscriptions.unarchiveByRoomId(rid);
-	Messages.createRoomUnarchivedByRoomIdAndUser(rid, Meteor.user());
+	Messages.createRoomUnarchivedByRoomIdAndUser(rid, await Meteor.userAsync());
 };

apps/meteor/app/lib/server/methods/addUsersToRoom.ts

@@ -75,7 +75,7 @@ Meteor.methods<ServerMethods>({
 		}
 
 		// Validate each user, then add to room
-		const user = (Meteor.user() as IUser | null) ?? undefined;
+		const user = ((await Meteor.userAsync()) as IUser | null) ?? undefined;
 		if (isRoomFederated(room)) {
 			callbacks.run('federation.onAddUsersToARoom', { invitees: data.users, inviter: user }, room);
 			return true;

apps/meteor/app/lib/server/methods/archiveRoom.ts

@@ -11,7 +11,7 @@ import { RoomMemberActions } from '../../../../definition/IRoomTypeConfig';
 declare module '@rocket.chat/ui-contexts' {
 	// eslint-disable-next-line @typescript-eslint/naming-convention
 	interface ServerMethods {
-		archiveRoom(rid: string): void;
+		archiveRoom(rid: string): Promise<void>;
 	}
 }
 

apps/meteor/app/lib/server/methods/checkUsernameAvailability.ts

@@ -20,7 +20,7 @@ Meteor.methods<ServerMethods>({
 
 		check(username, String);
 
-		const user = Meteor.user();
+		const user = await Meteor.userAsync();
 
 		if (!user) {
 			throw new Meteor.Error('error-invalid-user', 'Invalid user', { method: 'setUsername' });

apps/meteor/app/lib/server/methods/createChannel.ts

@@ -26,7 +26,7 @@ Meteor.methods<ServerMethods>({
 
 		const uid = Meteor.userId();
 
-		const user = Meteor.user();
+		const user = await Meteor.userAsync();
 
 		if (!uid || !user?.username) {
 			throw new Meteor.Error('error-invalid-user', 'Invalid user', { method: 'createChannel' });

apps/meteor/app/lib/server/methods/unarchiveRoom.ts

@@ -9,7 +9,7 @@ import { unarchiveRoom } from '../functions';
 declare module '@rocket.chat/ui-contexts' {
 	// eslint-disable-next-line @typescript-eslint/naming-convention
 	interface ServerMethods {
-		unarchiveRoom(rid: string): void;
+		unarchiveRoom(rid: string): Promise<void>;
 	}
 }
 

apps/meteor/app/slackbridge/server/SlackAdapter.js

@@ -1099,13 +1099,13 @@ export default class SlackAdapter {
 			case 'channel_archive':
 			case 'group_archive':
 				if (!isImporting) {
-					archiveRoom(rocketChannel);
+					await archiveRoom(rocketChannel);
 				}
 				return;
 			case 'channel_unarchive':
 			case 'group_unarchive':
 				if (!isImporting) {
-					unarchiveRoom(rocketChannel);
+					await unarchiveRoom(rocketChannel);
 				}
 				return;
 			case 'file_share':