fix: marketplace doc link wrong redirect (#28466)

Co-authored-by: Tiago Evangelista Pinto <17487063+tiagoevanp@users.noreply.github.com>
pull/28588/head
Henrique Guimarães Ribeiro 3 years ago committed by GitHub
parent 1fbb6f8515
commit fa30fac0b2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 9
      apps/meteor/client/components/Sidebar/SidebarGenericItem.tsx
  2. 3
      apps/meteor/client/components/Sidebar/SidebarNavigationItem.tsx

@ -17,7 +17,14 @@ type SidebarGenericItemProps = {
};
const SidebarGenericItem = ({ href, active, externalUrl, children, ...props }: SidebarGenericItemProps): ReactElement => (
<SidebarItem selected={active} clickable is='a' href={href} {...(externalUrl && { target: '_blank' })} {...props}>
<SidebarItem
selected={active}
clickable
is='a'
href={href}
{...(externalUrl && { target: '_blank', rel: 'noopener noreferrer' })}
{...props}
>
<Box display='flex' flexDirection='row' alignItems='center' pb='x8'>
{children}
</Box>

@ -31,7 +31,8 @@ const SidebarNavigationItem: FC<SidebarNavigationItemProps> = ({
badge: Badge,
}) => {
const params = useMemo(() => ({ group: pathGroup }), [pathGroup]);
const path = useRoutePath(pathSection, params);
const routePath = useRoutePath(pathSection, params);
const path = externalUrl ? pathSection : routePath;
const isActive = !!path && currentPath?.includes(path as string);
if (permissionGranted === false || (typeof permissionGranted === 'function' && !permissionGranted())) {

Loading…
Cancel
Save