[FIX] Update check not able to be disabled (#18339)

* Only run the update check when opting to register the server.
Doing it this way enables people to easily disable the update
check just like they can sending data to Rocket.Chat services.

* Add a new setting to enable/disable the update checker

Co-authored-by: Aaron Ogle <geekgonecrazy@users.noreply.github.com>

app/version-check/server/addSettings.js

@@ -6,5 +6,13 @@ settings.addGroup('General', function() {
 			type: 'string',
 			readonly: true,
 		});
+
+		this.add('Update_EnableChecker', true, {
+			type: 'boolean',
+			enableQuery: {
+				_id: 'Register_Server',
+				value: true,
+			},
+		});
 	});
 });

app/version-check/server/index.js

@@ -1,6 +1,7 @@
 import { Meteor } from 'meteor/meteor';
 import { SyncedCron } from 'meteor/littledata:synced-cron';
 
+import { settings } from '../../settings';
 import checkVersionUpdate from './functions/checkVersionUpdate';
 import './methods/banner_dismiss';
 import './addSettings';
@@ -11,18 +12,30 @@ if (SyncedCron.nextScheduledAtDate(jobName)) {
 	SyncedCron.remove(jobName);
 }
 
-SyncedCron.add({
-	name: jobName,
-	schedule: (parser) => parser.text('at 2:00 am'),
-	job() {
-		checkVersionUpdate();
-	},
-});
+const addVersionCheckJob = () => {
+	SyncedCron.add({
+		name: jobName,
+		schedule: (parser) => parser.text('at 2:00 am'),
+		job() {
+			checkVersionUpdate();
+		},
+	});
+};
+
 
 Meteor.startup(() => {
 	checkVersionUpdate();
 });
 
-// Send email to admins
-// Save latest alert
-// ENV var to disable the check for update for our cloud
+settings.get('Register_Server', (key, value) => {
+	if (value && SyncedCron.nextScheduledAtDate(jobName)) {
+		return;
+	}
+
+	if (value && settings.get('Update_EnableChecker')) {
+		addVersionCheckJob();
+		return;
+	}
+
+	SyncedCron.remove(jobName);
+});

packages/rocketchat-i18n/i18n/en.i18n.json

@@ -3646,6 +3646,7 @@
   "Unstar_Message": "Remove Star",
   "Update": "Update",
   "Update_LatestAvailableVersion": "Update Latest Available Version",
+  "Update_EnableChecker": "Enable the Update Checker",
   "Update_to_version": "Update to __version__",
   "Update_your_RocketChat": "Update your Rocket.Chat",
   "Updated_at": "Updated at",