39 Commits (develop)

Author	SHA1	Message	Date
Tasso Evangelista	3e428054ff	chore(ui-client): Move some views (#37757)	3 weeks ago
gabriellsh	f3dc2c1815	chore: Move `GenericTable` to `ui-client` package (#37830)	3 weeks ago
Diego Sampaio	22b63f0d2f	chore: remove old federation (#37059) ... Co-authored-by: Guilherme Gazzo <guilherme@gazzo.xyz>	4 months ago
Tasso Evangelista	8e2c989105	chore: Upgrade React (#32288)	12 months ago
Tasso Evangelista	0517a05675	refactor: Invalid values as React nodes (#34901)	1 year ago
Hugo Costa	ee5756a9fa	chore: Upgrade `@tanstack/query` to v5 (#33898) ... Co-authored-by: Tasso <tasso.evangelista@rocket.chat>	1 year ago
Tasso Evangelista	9af2c11d64	refactor: JSX automatic runtime (#34498)	1 year ago
Guilherme Gazzo	b2d864c568	chore: update eslint plugins (#33879)	1 year ago
Tasso Evangelista	06189eb7ad	refactor: Normalize the usage of the `useSetting` hook (#33779) ... Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>	1 year ago
Douglas Fabris	bec7cf62fd	chore: Removes `FilterByText` internal state (#33735) ... Co-authored-by: Tasso <tasso.evangelista@rocket.chat>	1 year ago
Tasso Evangelista	d8ed08f74a	refactor(i18n): Use i18next‘s t-function in more modules (#33732)	1 year ago
Ricardo Garim	a23e699859	chore!: make get directory stop to use query param (#33563)	1 year ago
Tasso Evangelista	de596579c0	refactor(i18n): Use i18next‘s t-function (#33601)	1 year ago
Tasso Evangelista	73808aad3a	Revert "refactor(i18n): Increase the adoption of `react-i18next` - Phase 1" (#33485)	1 year ago
Tasso Evangelista	af202c7a62	Revert "refactor(i18n): Increase the adoption of `react-i18next` - Phase 1" (#33485)	1 year ago
Tasso Evangelista	98b6a20901	refactor(i18n): Increase the adoption of `react-i18next` - Phase 1 (#33175)	1 year ago
Douglas Fabris	2c72a26a62	chore: `FilterByText` component sanitization (#32957)	1 year ago
Tiago Evangelista Pinto	1e833d5b7c	chore: Introduce `ui-avatar` package to monorepo (#31482) ... Co-authored-by: Douglas Fabris <27704687+dougfabris@users.noreply.github.com>	2 years ago
Douglas Fabris	3f4b430c7e	chore: Replace `IconButton` in favor of `Button` on `PageHeader` (#31171)	2 years ago
Douglas Fabris	dd5fd6d2c8	feat: Skip to main content shortcut and `useDocumentTitle` (#30680) ... Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>	2 years ago
Júlia Jaeger Foresti	a19d5d54b2	chore: Color contrast changes (#30089)	2 years ago
Guilherme Gazzo	39322413fb	chore: use pixels for margins and paddings (#30023) ... Co-authored-by: dougfabris <devfabris@gmail.com>	2 years ago
Tasso Evangelista	287878c1ee	chore(lint): Reinforce ESLint for React (#29857)	3 years ago
Tasso Evangelista	4da8801830	chore: Use FlowRoute through a facade (#29507)	3 years ago
Douglas Fabris	f7d2e27eec	chore: `Table` in favor of `GenericTable` (#29628)	3 years ago
Douglas Fabris	742eac7268	chore: Pages empty state consistency (#29439)	3 years ago
Tasso Evangelista	646f970d9a	refactor(client): Dead code and spurious exports (#28654)	3 years ago
Rodrigo Nascimento	e44c9102d3	refactor: Remove optional return of room coordinator (#28592)	3 years ago
Douglas Fabris	decefab53c	Chore: Refactor Directory Tables (#27646)	3 years ago
Diego Sampaio	b0a848a4f3	[BREAK] Update Meteor to 2.9 and NodeJS to 14.21.1 (#27639) ... Co-authored-by: Tasso Evangelista <tasso.evangelista@rocket.chat>	3 years ago
Lucas Andrade	8f4e06e401	Chore: Convert UserTable on Directory to TS (#27534) ... Co-authored-by: Douglas Fabris <27704687+dougfabris@users.noreply.github.com>	3 years ago
Tasso Evangelista	649aa72ddf	Chore: Update ESlint rules of client code (#27427) ... Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>	3 years ago
Júlia Jaeger Foresti	5c5d57545e	Chore: Convert client/views/directory/hooks to ts (#26936)	3 years ago
Júlia Jaeger Foresti	ddb0b686d7	Chore: Convert client/views/directory/RoomTags to ts (#26937)	3 years ago
Júlia Jaeger Foresti	d408c31046	[NEW] Colors Palette - Buttons (#25626) ... <!-- This is a pull request template, you do not need to uncomment or remove the comments, they won't show up in the PR text. --> <!-- Your Pull Request name should start with one of the following tags [NEW] For new features [IMPROVE] For an improvement (performance or little improvements) in existing features [FIX] For bug fixes that affect the end-user [BREAK] For pull requests including breaking changes Chore: For small tasks Doc: For documentation --> <!-- Checklist!!! If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code. - I have read the Contributing Guide - https://github.com/RocketChat/Rocket.Chat/blob/develop/.github/CONTRIBUTING.md#contributing-to-rocketchat doc - I have signed the CLA - https://cla-assistant.io/RocketChat/Rocket.Chat - Lint and unit tests pass locally with my changes - I have added tests that prove my fix is effective or that my feature works (if applicable) - I have added necessary documentation (if applicable) - Any dependent changes have been merged and published in downstream modules --> ## Proposed changes (including videos or screenshots) <!-- CHANGELOG --> <!-- Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue below. This description will appear in the release notes if we accept the contribution. --> <!-- END CHANGELOG --> ## Issue(s) <!-- Link the issues being closed by or related to this PR. For example, you can use #594 if this PR closes issue number 594 --> ## Steps to test or reproduce <!-- Mention how you would reproduce the bug if not mentioned on the issue page already. Also mention which screens are going to have the changes if applicable --> ## Further comments <!-- If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc... --> Co-authored-by: Guilherme Gazzo <5263975+ggazzo@users.noreply.github.com>	4 years ago
Ben Wiederhake	5a37518e42	[FIX] Client-generated sort parameters in channel directory (#25768) ... ## Proposed changes (including videos or screenshots) - In the web-client, sorting the channel directory by "Last Message" raises the error "Invalid sort parameter provided". I don't think a screenshot is necessary, but if you'd like one anyway, here it is:  ## Issue(s) Closes #25695 ## Steps to test or reproduce - Open the web client, i.e. navigate your browser to `https://rocketchat.$DOMAIN/home` - Click the "Directory" button in the top left, (or just navigate directly to `https://rocketchat.$DOMAIN/directory/channels`) - In the table header, click on "Last message" once - In the table header, click on "Last message" again Expected behavior: Clicking "Last message" turns on and then toggles sorting by the date of the last message, either first ascending and then descending, or the other way around. Actual behavior: The first click sorts the messages in ascending order (good!), the second click shows a red warning box "FIXME", the table content disappears, and is replaced by throbbing grey placeholders. ### "Good" request (ascending order): `https://rocketchat.domain.org/api/v1/directory?query=%7B%22type%22%3A%22channels%22%2C%22text%22%3A%22%22%2C%22workspace%22%3A%22local%22%7D&sort=%7B%22lastMessage%22%3A1%7D&count=25` More easily readable GET parameters: ``` query | {"type":"channels","text":"","workspace":"local"} sort | {"lastMessage":1} count | 25 ``` Response: ``` {"result":[{"_id":"AAAAAAAAAAAAAAAAA","name":"foobar","fname":"foobar","t":"c","usersCount":10,"ts":"2019-01-01T00:00:00.000Z","default":false,"lastMessage":{"_id":"AAAAAAAAAAAAAAAAA","rid":"AAAAAAAAAAAAAAAAA","msg":"Hello, World!","ts":"2019-01-01T00:00:00.000Z","u":{"_id":"AAAAAAAAAAAAAAAAA","username":"normaluser","name":"normaluser"},"unread":true,"_updatedAt":"2019-01-01T00:00:00.000Z","urls":[],"mentions":[],"channels":[]},"description":"Obviously, this JSON response is heavily censored."}],"count":25,"offset":0,"total":52,"success":true} ``` (Obviously, this JSON response is heavily censored, but you get the gist: It was successful.) ### "Bad" request (descending order): `https://rocketchat.domain.org/api/v1/directory?query=%7B%22type%22%3A%22channels%22%2C%22text%22%3A%22%22%2C%22workspace%22%3A%22local%22%7D&sort=%7B%22lastMessage%22%3A0%7D&count=25` More easily readable GET parameters: ``` query | {"type":"channels","text":"","workspace":"local"} sort | {"lastMessage":0} count | 25 ``` Response: ``` {"success":false,"error":"Invalid sort parameter provided: \"{\"lastMessage\":0}\" [error-invalid-sort]","errorType":"error-invalid-sort","details":{"helperMethod":"parseJsonQuery"}} ``` ## Further comments Version on the server where I noticed this: `https://rocketchat.$DOMAIN/api/info` returns `{"version":"4.8","success":true}`. According to the "Releases" page, this version appeared 5 days ago, so I believe this is up to date. ### The journey to here For some reason, the descending order uses the wrong magic number "0", and the server can't interpret that. However, this *used* to work, so I'm not very sure about this. The error message appears in the source code of the entire organization exactly once: 31ae30f30a/apps/meteor/app/api/server/helpers/parseJsonQuery.ts (L42) So I'll guess that this is the line of code that generated this particular message. A few lines above we see that the server only knows 1 and -1 as magic numbers for the sorting: 31ae30f30a/apps/meteor/app/api/server/helpers/parseJsonQuery.ts (L35) This matches the observed bug: The browser sends 1 (which works) and 0 (which doesn't work). Generally, it seems that the web client actually uses the strings "asc" and "desc" internally, which are hard to mix up. So I assume that it's the conversion of that is broken somehow. Exactly this seems to be the case here: 31ae30f30a/apps/meteor/client/views/directory/hooks.js (L11) The code around it produces exactly the kind of query seen in the network log, and can also produce the buggy parameter `sort: 0`. This either fixes bug #25695, or a different bug of the same kind. I am not sure how to add tests for this, can someone do this for me or show me where to start? I'm actually just an end-user and "accidentally" found the fix for the bug while writing the bug report ^^' EDIT: Rebased for convenience, and to re-check CI.	4 years ago
Guilherme Gazzo	611c0b31fb	Chore: RestApiClient as Package (#25469) ... <!-- This is a pull request template, you do not need to uncomment or remove the comments, they won't show up in the PR text. --> <!-- Your Pull Request name should start with one of the following tags [NEW] For new features [IMPROVE] For an improvement (performance or little improvements) in existing features [FIX] For bug fixes that affect the end-user [BREAK] For pull requests including breaking changes Chore: For small tasks Doc: For documentation --> <!-- Checklist!!! If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code. - I have read the Contributing Guide - https://github.com/RocketChat/Rocket.Chat/blob/develop/.github/CONTRIBUTING.md#contributing-to-rocketchat doc - I have signed the CLA - https://cla-assistant.io/RocketChat/Rocket.Chat - Lint and unit tests pass locally with my changes - I have added tests that prove my fix is effective or that my feature works (if applicable) - I have added necessary documentation (if applicable) - Any dependent changes have been merged and published in downstream modules --> ## Proposed changes (including videos or screenshots) <!-- CHANGELOG --> <!-- Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue below. This description will appear in the release notes if we accept the contribution. --> <!-- END CHANGELOG --> ## Issue(s) <!-- Link the issues being closed by or related to this PR. For example, you can use #594 if this PR closes issue number 594 --> ## Steps to test or reproduce <!-- Mention how you would reproduce the bug if not mentioned on the issue page already. Also mention which screens are going to have the changes if applicable --> ## Further comments <!-- If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc... --> Co-authored-by: Tasso Evangelista <2263066+tassoevan@users.noreply.github.com>	4 years ago
Tasso Evangelista	cb0c4063f6	Chore: Dedicated package for UI contexts (#25432)	4 years ago
Guilherme Gazzo	08af753264	Chore: TS migration SortList (#25167)	4 years ago
Diego Sampaio	961c06014e	First move to monorepo	4 years ago