The communications platform that puts data protection first.

hacktoberfest collaboration foss javascript meteor real-time webrtc mit slack chat free

History

Hugo Costa dfd1d77674 [FIX] VOIP CallContext snapshot infinite loop (#25947 ) <!-- This is a pull request template, you do not need to uncomment or remove the comments, they won't show up in the PR text. --> <!-- Your Pull Request name should start with one of the following tags [NEW] For new features [IMPROVE] For an improvement (performance or little improvements) in existing features [FIX] For bug fixes that affect the end-user [BREAK] For pull requests including breaking changes Chore: For small tasks Doc: For documentation --> <!-- Checklist!!! If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code. - I have read the Contributing Guide - https://github.com/RocketChat/Rocket.Chat/blob/develop/.github/CONTRIBUTING.md#contributing-to-rocketchat doc - I have signed the CLA - https://cla-assistant.io/RocketChat/Rocket.Chat - Lint and unit tests pass locally with my changes - I have added tests that prove my fix is effective or that my feature works (if applicable) - I have added necessary documentation (if applicable) - Any dependent changes have been merged and published in downstream modules --> ## Proposed changes (including videos or screenshots) <!-- CHANGELOG --> The application was crashing due to an error on the `useCallerInfo()` hook. The error was: ![image](https://user-images.githubusercontent.com/20212776/174823914-4832e5dd-c91a-4ae4-9d1f-1b960bcd372c.png) ![image](https://user-images.githubusercontent.com/20212776/174823982-cb543fe0-663f-4530-bb94-0720653ca897.png) To prevent this issue to happen it was added a cached and out-of-scope snapshot variable to the hook using `useSyncExternalStore` <!-- Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue below. This description will appear in the release notes if we accept the contribution. --> <!-- END CHANGELOG --> ## Issue(s) <!-- Link the issues being closed by or related to this PR. For example, you can use #594 if this PR closes issue number 594 --> ## Steps to test or reproduce 1. Open rocket.chat server 2. Enable Omnichannel 3. Enable Voip 4. Refresh de page ## Further comments <!-- If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc... -->		4 years ago
..
UIKit/hooks	Chore: Dedicated package for UI contexts (#25432 )	4 years ago
components	Chore: Remove Imperative Modal from context (#25911 )	4 years ago
contexts	[FIX] VOIP CallContext snapshot infinite loop (#25947 )	4 years ago
definitions	Chore: Broken Storybook (#25714 )	4 years ago
hooks	Chore: Replace `useSubscription` with `useSyncExternalStore` (#25909 )	4 years ago
lib	Chore: Replace `useSubscription` with `useSyncExternalStore` (#25909 )	4 years ago
methods	…
polyfills	…
providers	Chore: Remove Imperative Modal from context (#25911 )	4 years ago
sidebar	Chore: Replace `useSubscription` with `useSyncExternalStore` (#25909 )	4 years ago
startup	Chore: RouteGroup for My Account sidebar (#25632 )	4 years ago
stories	Chore: Convert MemoizedSetting, Setting, Section (#25572 )	4 years ago
templateHelpers	Chore: move definitions to packages (#25085 )	4 years ago
views	Regression: Unable to edit user details via admin panel (#25923 )	4 years ago
.eslintrc.js	Regression: eslint not running on packages (#25305 )	4 years ago
README.md	…
head.html	…
importPackages.ts	[BREAK] Remove Blockstack authentication (#25649 )	4 years ago
main.ts	Chore: RouteGroup for My Account sidebar (#25632 )	4 years ago
templates.ts	[FIX] Thread Message Preview (#25709 )	4 years ago

README.md

How does the folder structure work in the frontend?

The folder structure should follow rocketchat's html 'semantics' like:

    main   -> room
                -> header
                    ...
                -> contextualbar
                    roominfo
                        ...
            -> sidebar
                -> Header
                    -> search
                    -> actions
                        ...
                -> list
                    ...
                -> footer
                    ...

Each folder is composed by:

File
index.jsx
ContainerComponent.jsx
contexts	(optional)
providers	(optional)
components	(optional)
hooks	(optional)
libs	(optional)

We strongly suggest that you start developing your components/hooks/libs inside the folder where they will be directly used. If you ever find that you will use them in more than one place, then you should "promote" the code to an upper level, where it can be commonly accessed by all others

we have being moving code from blaze to react, but sometimes we will need render under blaze enviroment, to do that use createTemplateForComponent