From 00a07c855de70745ba757508f90893525f113a17 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C5=A0imon=20Podlipsk=C3=BD?= Date: Wed, 27 Mar 2019 15:18:15 +0100 Subject: [PATCH] Fix: Table Panel and string values & numeric formatting (#16249) --- public/app/plugins/panel/table/renderer.ts | 2 +- public/app/plugins/panel/table/specs/renderer.test.ts | 7 ++++++- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/public/app/plugins/panel/table/renderer.ts b/public/app/plugins/panel/table/renderer.ts index 9f01a1c6a3d..59cb0941b4c 100644 --- a/public/app/plugins/panel/table/renderer.ts +++ b/public/app/plugins/panel/table/renderer.ts @@ -177,7 +177,7 @@ export class TableRenderer { return '-'; } - if (_.isString(v) || _.isArray(v)) { + if (isNaN(v) || _.isArray(v)) { return this.defaultCellFormatter(v, column.style); } diff --git a/public/app/plugins/panel/table/specs/renderer.test.ts b/public/app/plugins/panel/table/specs/renderer.test.ts index ca5a036d98f..8c68ebbf9d7 100644 --- a/public/app/plugins/panel/table/specs/renderer.test.ts +++ b/public/app/plugins/panel/table/specs/renderer.test.ts @@ -224,7 +224,12 @@ describe('when rendering table', () => { expect(html).toBe('1.230 s'); }); - it('number style should ignore string values', () => { + it('number column should format numeric string values', () => { + const html = renderer.renderCell(1, 0, '1230'); + expect(html).toBe('1.230 s'); + }); + + it('number style should ignore string non-numeric values', () => { const html = renderer.renderCell(1, 0, 'asd'); expect(html).toBe('asd'); });