@ -223,7 +223,7 @@ func (m *migration) SQL(dialect migrator.Dialect) string {
return "code migration"
}
//nolint: gocyclo
// nolint: gocyclo
func ( m * migration ) Exec ( sess * xorm . Session , mg * migrator . Migrator ) error {
m . sess = sess
m . mg = mg
@ -276,6 +276,11 @@ func (m *migration) Exec(sess *xorm.Session, mg *migrator.Migrator) error {
}
}
folderHelper := folderHelper {
sess : sess ,
mg : mg ,
}
var folder * dashboard
switch {
case dash . HasAcl :
@ -284,21 +289,21 @@ func (m *migration) Exec(sess *xorm.Session, mg *migrator.Migrator) error {
if ! ok {
mg . Logger . Info ( "create a new folder for alerts that belongs to dashboard because it has custom permissions" , "org" , dash . OrgId , "dashboard_uid" , dash . Uid , "folder" , folderName )
// create folder and assign the permissions of the dashboard (included default and inherited)
f , err = m . createFolder ( dash . OrgId , folderName )
f , err = folderHelper . createFolder ( dash . OrgId , folderName )
if err != nil {
return MigrationError {
Err : fmt . Errorf ( "failed to create folder: %w" , err ) ,
AlertId : da . Id ,
}
}
permissions , err := m . getACL ( dash . OrgId , dash . Id )
permissions , err := folderHelper . getACL ( dash . OrgId , dash . Id )
if err != nil {
return MigrationError {
Err : fmt . Errorf ( "failed to get dashboard %d under organisation %d permissions: %w" , dash . Id , dash . OrgId , err ) ,
AlertId : da . Id ,
}
}
err = m . setACL ( f . OrgId , f . Id , permissions )
err = folderHelper . setACL ( f . OrgId , f . Id , permissions )
if err != nil {
return MigrationError {
Err : fmt . Errorf ( "failed to set folder %d under organisation %d permissions: %w" , folder . Id , folder . OrgId , err ) ,
@ -310,7 +315,7 @@ func (m *migration) Exec(sess *xorm.Session, mg *migrator.Migrator) error {
folder = f
case dash . FolderId > 0 :
// get folder if exists
f , err := m . getFolder ( dash , da )
f , err := folderHelper . getFolder ( dash , da )
if err != nil {
return MigrationError {
Err : err ,
@ -322,7 +327,7 @@ func (m *migration) Exec(sess *xorm.Session, mg *migrator.Migrator) error {
f , ok := folderCache [ GENERAL_FOLDER ]
if ! ok {
// get or create general folder
f , err = m . getOrCreateGeneralFolder ( dash . OrgId )
f , err = folderHelper . getOrCreateGeneralFolder ( dash . OrgId )
if err != nil {
return MigrationError {
Err : fmt . Errorf ( "failed to get or create general folder under organisation %d: %w" , dash . OrgId , err ) ,
@ -753,3 +758,58 @@ func getAlertFolderNameFromDashboard(dash *dashboard) string {
}
return fmt . Sprintf ( DASHBOARD_FOLDER , title , dash . Uid ) // include UID to the name to avoid collision
}
// CreateDefaultFoldersForAlertingMigration creates a folder dedicated for alerting if no folders exist
func CreateDefaultFoldersForAlertingMigration ( mg * migrator . Migrator ) {
if ! mg . Cfg . UnifiedAlerting . IsEnabled ( ) {
return
}
mg . AddMigration ( "create default alerting folders" , & createDefaultFoldersForAlertingMigration { } )
}
type createDefaultFoldersForAlertingMigration struct {
migrator . MigrationBase
}
func ( c createDefaultFoldersForAlertingMigration ) Exec ( sess * xorm . Session , migrator * migrator . Migrator ) error {
helper := folderHelper {
sess : sess ,
mg : migrator ,
}
var rows [ ] struct {
Id int64
Name string
}
if err := sess . Table ( "org" ) . Cols ( "id" , "name" ) . Find ( & rows ) ; err != nil {
return fmt . Errorf ( "failed to read the list of organizations: %w" , err )
}
orgsWithFolders , err := helper . getOrgsIDThatHaveFolders ( )
if err != nil {
return fmt . Errorf ( "failed to list organizations that have at least one folder: %w" , err )
}
for _ , row := range rows {
// if there's at least one folder in the org or if alerting is disabled for that org, skip adding the default folder
if _ , ok := orgsWithFolders [ row . Id ] ; ok {
migrator . Logger . Debug ( "Skip adding default alerting folder because organization already has at least one folder" , "org_id" , row . Id )
continue
}
if _ , ok := migrator . Cfg . UnifiedAlerting . DisabledOrgs [ row . Id ] ; ok {
migrator . Logger . Debug ( "Skip adding default alerting folder because alerting is disabled for the organization " , "org_id" , row . Id )
continue
}
folder , err := helper . createGeneralFolder ( row . Id )
if err != nil {
return fmt . Errorf ( "failed to create the default alerting folder for organization %s (ID: %d): %w" , row . Name , row . Id , err )
}
migrator . Logger . Info ( "created the default folder for alerting" , "org_id" , row . Id , "folder_name" , folder . Title , "folder_uid" , folder . Uid )
}
return nil
}
func ( c createDefaultFoldersForAlertingMigration ) SQL ( migrator . Dialect ) string {
return "code migration"
}
Yuriy Tseretyan
4 years ago
committed by