From 0b40c8e51e01134f327780b0bb8ac487ce253bbc Mon Sep 17 00:00:00 2001
From: Will Browne <wbrowne@users.noreply.github.com>
Date: Mon, 4 Jul 2022 13:03:50 +0200
Subject: [PATCH] Plugins: Add missing asserts for Plugin Errors field (#51702)

* make sure to check plugin errors

* remove unused test
---
 pkg/plugins/manager/loader/loader_test.go | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/pkg/plugins/manager/loader/loader_test.go b/pkg/plugins/manager/loader/loader_test.go
index b7f399c06f3..76eca25cd26 100644
--- a/pkg/plugins/manager/loader/loader_test.go
+++ b/pkg/plugins/manager/loader/loader_test.go
@@ -531,8 +531,8 @@ func TestLoader_Load_MultiplePlugins(t *testing.T) {
 					},
 				},
 				pluginErrors: map[string]*plugins.Error{
-					"test": {
-						PluginID:  "test",
+					"test-panel": {
+						PluginID:  "test-panel",
 						ErrorCode: "signatureMissing",
 					},
 				},
@@ -556,6 +556,11 @@ func TestLoader_Load_MultiplePlugins(t *testing.T) {
 				if !cmp.Equal(got, tt.want, compareOpts) {
 					t.Fatalf("Result mismatch (-want +got):\n%s", cmp.Diff(got, tt.want, compareOpts))
 				}
+				pluginErrs := l.PluginErrors()
+				require.Equal(t, len(tt.pluginErrors), len(pluginErrs))
+				for _, pluginErr := range pluginErrs {
+					require.Equal(t, tt.pluginErrors[pluginErr.PluginID], pluginErr)
+				}
 			})
 		}
 	})