Explore: Remove deprecated `query` option from `splitOpen` (#83973)

* Chore: remove deplrecated queries option from splitOpen

* make queries option required

* use left pane queries when splitting an existing pane
pull/84200/head
Giordano Ricci 1 year ago committed by GitHub
parent 9c292d2c3f
commit 0c6b0188c8
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
  1. 4
      packages/grafana-data/src/types/explore.ts
  2. 5
      public/app/features/explore/state/main.ts

@ -58,9 +58,7 @@ export interface ExploreLogsPanelState {
export interface SplitOpenOptions<T extends AnyQuery = AnyQuery> {
datasourceUid: string;
/** @deprecated Will be removed in a future version. Use queries instead. */
query?: T;
queries?: T[];
queries: T[];
range?: TimeRange;
panelsState?: ExplorePanelsState;
correlationHelperData?: ExploreCorrelationHelperData;

@ -61,7 +61,8 @@ export const setPaneState = createAction<SetPaneStateActionPayload>('explore/set
export const clearPanes = createAction('explore/clearPanes');
/**
* Ensure Explore doesn't exceed supported number of panes and initializes the new pane.
* Creates a new Explore pane.
* If 2 panes already exist, the last one (right) is closed before creating a new one.
*/
export const splitOpen = createAsyncThunk(
'explore/splitOpen',
@ -69,7 +70,7 @@ export const splitOpen = createAsyncThunk(
// we currently support showing only 2 panes in explore, so if this action is dispatched we know it has been dispatched from the "first" pane.
const originState = Object.values(getState().explore.panes)[0];
const queries = options?.queries ?? (options?.query ? [options?.query] : originState?.queries || []);
const queries = options?.queries ?? originState?.queries ?? [];
Object.keys(getState().explore.panes).forEach((paneId, index) => {
// Only 2 panes are supported. Remove panes before create a new one.

Loading…
Cancel
Save