From 13b23fd5121fb0067b612497fe1335b3033b0753 Mon Sep 17 00:00:00 2001
From: Jo <joao.guerreiro@grafana.com>
Date: Fri, 15 Jul 2022 07:10:20 +0000
Subject: [PATCH] Auth: Lockdown non-editables in frontend when external auth
 is configured (#52160)

* Auth: Lockdown user profile edit if external synced

* Auth: use builtin isExternal

* Auth: When user is synced, orgs will be overriden on next login
---
 public/app/features/admin/UserOrgs.tsx        |  3 ++-
 .../features/profile/UserProfileEditForm.tsx  | 22 ++++++++++++-------
 2 files changed, 16 insertions(+), 9 deletions(-)

diff --git a/public/app/features/admin/UserOrgs.tsx b/public/app/features/admin/UserOrgs.tsx
index b85247e1248..4472ea04f6e 100644
--- a/public/app/features/admin/UserOrgs.tsx
+++ b/public/app/features/admin/UserOrgs.tsx
@@ -60,7 +60,8 @@ export class UserOrgs extends PureComponent<Props, State> {
     const addToOrgContainerClass = css`
       margin-top: 0.8rem;
     `;
-    const canAddToOrg = contextSrv.hasPermission(AccessControlAction.OrgUsersAdd);
+
+    const canAddToOrg = contextSrv.hasPermission(AccessControlAction.OrgUsersAdd) && !isExternalUser;
     return (
       <>
         <h3 className="page-heading">Organizations</h3>
diff --git a/public/app/features/profile/UserProfileEditForm.tsx b/public/app/features/profile/UserProfileEditForm.tsx
index c5748eb515f..c4a95cfdf3d 100644
--- a/public/app/features/profile/UserProfileEditForm.tsx
+++ b/public/app/features/profile/UserProfileEditForm.tsx
@@ -21,16 +21,22 @@ export const UserProfileEditForm: FC<Props> = ({ user, isSavingUser, updateProfi
     updateProfile(data);
   };
 
+  // check if authLabels is longer than 0 otherwise false
+  const isExternalUser: boolean = (user && user.isExternal) ?? false;
+  const authSource = isExternalUser && user && user.authLabels ? user.authLabels[0] : '';
+  const lockMessage = authSource ? ` (Synced via ${authSource})` : '';
+  const disabledEdit = disableLoginForm || isExternalUser;
+
   return (
     <Form onSubmit={onSubmitProfileUpdate} validateOn="onBlur">
       {({ register, errors }) => {
         return (
           <FieldSet label={<Trans id="user-profile.title">Edit profile</Trans>}>
             <Field
-              label={t({ id: 'user-profile.fields.name-label', message: 'Name' })}
+              label={t({ id: 'user-profile.fields.name-label', message: 'Name' }) + lockMessage}
               invalid={!!errors.name}
               error={<Trans id="user-profile.fields.name-error">Name is required</Trans>}
-              disabled={disableLoginForm}
+              disabled={disabledEdit}
             >
               <Input
                 {...register('name', { required: true })}
@@ -42,10 +48,10 @@ export const UserProfileEditForm: FC<Props> = ({ user, isSavingUser, updateProfi
             </Field>
 
             <Field
-              label={t({ id: 'user-profile.fields.email-label', message: 'Email' })}
+              label={t({ id: 'user-profile.fields.email-label', message: 'Email' }) + lockMessage}
               invalid={!!errors.email}
               error={<Trans id="user-profile.fields.email-error">Email is required</Trans>}
-              disabled={disableLoginForm}
+              disabled={disabledEdit}
             >
               <Input
                 {...register('email', { required: true })}
@@ -57,14 +63,14 @@ export const UserProfileEditForm: FC<Props> = ({ user, isSavingUser, updateProfi
             </Field>
 
             <Field
-              label={t({ id: 'user-profile.fields.username-label', message: 'Username' })}
-              disabled={disableLoginForm}
+              label={t({ id: 'user-profile.fields.username-label', message: 'Username' }) + lockMessage}
+              disabled={disabledEdit}
             >
               <Input
                 {...register('login')}
                 id="edit-user-profile-username"
                 defaultValue={user?.login ?? ''}
-                placeholder={t({ id: 'user-profile.fields.username-label', message: 'Username' })}
+                placeholder={t({ id: 'user-profile.fields.username-label', message: 'Username' }) + lockMessage}
                 suffix={<InputSuffix />}
               />
             </Field>
@@ -72,7 +78,7 @@ export const UserProfileEditForm: FC<Props> = ({ user, isSavingUser, updateProfi
             <div className="gf-form-button-row">
               <Button
                 variant="primary"
-                disabled={isSavingUser}
+                disabled={isSavingUser || disabledEdit}
                 data-testid={selectors.components.UserProfile.profileSaveButton}
                 type="submit"
               >