From 15a4ff992bd925f5714bc4e73fa9766a995b5711 Mon Sep 17 00:00:00 2001 From: Sven Grossmann Date: Thu, 29 Aug 2024 15:55:59 +0200 Subject: [PATCH] Explore Logs: Add feature flags (#92670) --- .../feature-toggles/index.md | 3 ++ .../src/types/featureToggles.gen.ts | 3 ++ pkg/services/featuremgmt/registry.go | 21 ++++++++++ pkg/services/featuremgmt/toggles_gen.csv | 3 ++ pkg/services/featuremgmt/toggles_gen.go | 12 ++++++ pkg/services/featuremgmt/toggles_gen.json | 39 +++++++++++++++++++ 6 files changed, 81 insertions(+) diff --git a/docs/sources/setup-grafana/configure-grafana/feature-toggles/index.md b/docs/sources/setup-grafana/configure-grafana/feature-toggles/index.md index 2bdb2556376..66328509bd7 100644 --- a/docs/sources/setup-grafana/configure-grafana/feature-toggles/index.md +++ b/docs/sources/setup-grafana/configure-grafana/feature-toggles/index.md @@ -195,6 +195,9 @@ Experimental features might be changed or removed without prior notice. | `adhocFilterOneOf` | Exposes a new 'one of' operator for ad-hoc filters. This operator allows users to filter by multiple values in a single filter. | | `lokiSendDashboardPanelNames` | Send dashboard and panel names to Loki when querying | | `singleTopNav` | Unifies the top search bar and breadcrumb bar into one | +| `exploreLogsShardSplitting` | Used in Explore Logs to split queries into multiple queries based on the number of shards | +| `exploreLogsAggregatedMetrics` | Used in Explore Logs to query by aggregated metrics | +| `exploreLogsLimitedTimeRange` | Used in Explore Logs to limit the time range | ## Development feature toggles diff --git a/packages/grafana-data/src/types/featureToggles.gen.ts b/packages/grafana-data/src/types/featureToggles.gen.ts index ff1ed22a3a4..f0933f11f05 100644 --- a/packages/grafana-data/src/types/featureToggles.gen.ts +++ b/packages/grafana-data/src/types/featureToggles.gen.ts @@ -204,4 +204,7 @@ export interface FeatureToggles { adhocFilterOneOf?: boolean; lokiSendDashboardPanelNames?: boolean; singleTopNav?: boolean; + exploreLogsShardSplitting?: boolean; + exploreLogsAggregatedMetrics?: boolean; + exploreLogsLimitedTimeRange?: boolean; } diff --git a/pkg/services/featuremgmt/registry.go b/pkg/services/featuremgmt/registry.go index 8aa6529b815..d6c8d621af0 100644 --- a/pkg/services/featuremgmt/registry.go +++ b/pkg/services/featuremgmt/registry.go @@ -1404,6 +1404,27 @@ var ( FrontendOnly: true, Owner: grafanaFrontendPlatformSquad, }, + { + Name: "exploreLogsShardSplitting", + Description: "Used in Explore Logs to split queries into multiple queries based on the number of shards", + Stage: FeatureStageExperimental, + FrontendOnly: true, + Owner: grafanaObservabilityLogsSquad, + }, + { + Name: "exploreLogsAggregatedMetrics", + Description: "Used in Explore Logs to query by aggregated metrics", + Stage: FeatureStageExperimental, + FrontendOnly: true, + Owner: grafanaObservabilityLogsSquad, + }, + { + Name: "exploreLogsLimitedTimeRange", + Description: "Used in Explore Logs to limit the time range", + Stage: FeatureStageExperimental, + FrontendOnly: true, + Owner: grafanaObservabilityLogsSquad, + }, } ) diff --git a/pkg/services/featuremgmt/toggles_gen.csv b/pkg/services/featuremgmt/toggles_gen.csv index 506cb90beeb..9dfc93c661f 100644 --- a/pkg/services/featuremgmt/toggles_gen.csv +++ b/pkg/services/featuremgmt/toggles_gen.csv @@ -185,3 +185,6 @@ dataplaneAggregator,experimental,@grafana/grafana-app-platform-squad,false,true, adhocFilterOneOf,experimental,@grafana/dashboards-squad,false,false,false lokiSendDashboardPanelNames,experimental,@grafana/observability-logs,false,false,false singleTopNav,experimental,@grafana/grafana-frontend-platform,false,false,true +exploreLogsShardSplitting,experimental,@grafana/observability-logs,false,false,true +exploreLogsAggregatedMetrics,experimental,@grafana/observability-logs,false,false,true +exploreLogsLimitedTimeRange,experimental,@grafana/observability-logs,false,false,true diff --git a/pkg/services/featuremgmt/toggles_gen.go b/pkg/services/featuremgmt/toggles_gen.go index 084e1280a96..4b5c4ac2d81 100644 --- a/pkg/services/featuremgmt/toggles_gen.go +++ b/pkg/services/featuremgmt/toggles_gen.go @@ -750,4 +750,16 @@ const ( // FlagSingleTopNav // Unifies the top search bar and breadcrumb bar into one FlagSingleTopNav = "singleTopNav" + + // FlagExploreLogsShardSplitting + // Used in Explore Logs to split queries into multiple queries based on the number of shards + FlagExploreLogsShardSplitting = "exploreLogsShardSplitting" + + // FlagExploreLogsAggregatedMetrics + // Used in Explore Logs to query by aggregated metrics + FlagExploreLogsAggregatedMetrics = "exploreLogsAggregatedMetrics" + + // FlagExploreLogsLimitedTimeRange + // Used in Explore Logs to limit the time range + FlagExploreLogsLimitedTimeRange = "exploreLogsLimitedTimeRange" ) diff --git a/pkg/services/featuremgmt/toggles_gen.json b/pkg/services/featuremgmt/toggles_gen.json index 7f056a0d2b8..0178520d186 100644 --- a/pkg/services/featuremgmt/toggles_gen.json +++ b/pkg/services/featuremgmt/toggles_gen.json @@ -1046,6 +1046,45 @@ "allowSelfServe": true } }, + { + "metadata": { + "name": "exploreLogsAggregatedMetrics", + "resourceVersion": "1724938092041", + "creationTimestamp": "2024-08-29T13:28:12Z" + }, + "spec": { + "description": "Used in Explore Logs to query by aggregated metrics", + "stage": "experimental", + "codeowner": "@grafana/observability-logs", + "frontend": true + } + }, + { + "metadata": { + "name": "exploreLogsLimitedTimeRange", + "resourceVersion": "1724938092041", + "creationTimestamp": "2024-08-29T13:28:12Z" + }, + "spec": { + "description": "Used in Explore Logs to limit the time range", + "stage": "experimental", + "codeowner": "@grafana/observability-logs", + "frontend": true + } + }, + { + "metadata": { + "name": "exploreLogsShardSplitting", + "resourceVersion": "1724938092041", + "creationTimestamp": "2024-08-29T13:28:12Z" + }, + "spec": { + "description": "Used in Explore Logs to split queries into multiple queries based on the number of shards", + "stage": "experimental", + "codeowner": "@grafana/observability-logs", + "frontend": true + } + }, { "metadata": { "name": "exploreMetrics",