apitech
/
grafana
mirror of https://github.com/grafana/grafana
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Feature toggles: Remove redshiftAsyncQueryDataSupport and athenaAsyncQueryDataSupport toggles (#84653)

Browse Source
pull/84833/head
Ida Štambuk 2 years ago committed by GitHub
parent 339a2ba4e9
commit 18eac9df9e
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
6 changed files with 4 additions and 33 deletions
Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL
Show Stats Download Patch File Download Diff File
  1. 2
      docs/sources/setup-grafana/configure-grafana/feature-toggles/index.md
  2. 2
      packages/grafana-data/src/types/featureToggles.gen.ts
  3. 17
      pkg/services/featuremgmt/registry.go
  4. 2
      pkg/services/featuremgmt/toggles_gen.csv
  5. 8
      pkg/services/featuremgmt/toggles_gen.go
  6. 6
      pkg/services/featuremgmt/toggles_gen.json

2
docs/sources/setup-grafana/configure-grafana/feature-toggles/index.md
Unescape View File

@ -27,8 +27,6 @@ Some features are enabled by default. You can disable these feature by setting t
| `correlations` | Correlations page | |
| `exploreContentOutline` | Content outline sidebar | Yes |
| `cloudWatchCrossAccountQuerying` | Enables cross-account querying in CloudWatch datasources | Yes |
| `redshiftAsyncQueryDataSupport` | Enable async query data support for Redshift | Yes |
| `athenaAsyncQueryDataSupport` | Enable async query data support for Athena | Yes |
| `nestedFolderPicker` | Enables the new folder picker to work with nested folders. Requires the nestedFolders feature toggle | Yes |
| `logsContextDatasourceUi` | Allow datasource to provide custom UI for context view | Yes |
| `lokiQuerySplitting` | Split large interval queries into subqueries with smaller time intervals | Yes |

2
packages/grafana-data/src/types/featureToggles.gen.ts
Unescape View File

@ -48,8 +48,6 @@ export interface FeatureToggles {
grpcServer?: boolean;
unifiedStorage?: boolean;
cloudWatchCrossAccountQuerying?: boolean;
redshiftAsyncQueryDataSupport?: boolean;
athenaAsyncQueryDataSupport?: boolean;
showDashboardValidationWarnings?: boolean;
mysqlAnsiQuotes?: boolean;
accessControlOnCall?: boolean;

17
pkg/services/featuremgmt/registry.go
Unescape View File

@ -233,23 +233,6 @@ var (
Owner: awsDatasourcesSquad,
AllowSelfServe: true,
},
{
Name: "redshiftAsyncQueryDataSupport",
Description: "Enable async query data support for Redshift",
Stage: FeatureStageGeneralAvailability,
Expression: "true", // enabled by default
Owner: awsDatasourcesSquad,
AllowSelfServe: false,
},
{
Name: "athenaAsyncQueryDataSupport",
Description: "Enable async query data support for Athena",
Stage: FeatureStageGeneralAvailability,
Expression: "true", // enabled by default
FrontendOnly: true,
Owner: awsDatasourcesSquad,
AllowSelfServe: false,
},
{
Name: "showDashboardValidationWarnings",
Description: "Show warnings when dashboards do not validate against the schema",

2
pkg/services/featuremgmt/toggles_gen.csv
Unescape View File

@ -29,8 +29,6 @@ returnToPrevious,preview,@grafana/grafana-frontend-platform,false,false,true
grpcServer,preview,@grafana/grafana-app-platform-squad,false,false,false
unifiedStorage,experimental,@grafana/grafana-app-platform-squad,true,true,false
cloudWatchCrossAccountQuerying,GA,@grafana/aws-datasources,false,false,false
redshiftAsyncQueryDataSupport,GA,@grafana/aws-datasources,false,false,false
athenaAsyncQueryDataSupport,GA,@grafana/aws-datasources,false,false,true
showDashboardValidationWarnings,experimental,@grafana/dashboards-squad,false,false,false
mysqlAnsiQuotes,experimental,@grafana/backend-platform,false,false,false
accessControlOnCall,preview,@grafana/identity-access-team,false,false,false

1 Name Stage Owner requiresDevMode RequiresRestart FrontendOnly
29 grpcServer preview @grafana/grafana-app-platform-squad false false false
30 unifiedStorage experimental @grafana/grafana-app-platform-squad true true false
31 cloudWatchCrossAccountQuerying GA @grafana/aws-datasources false false false
redshiftAsyncQueryDataSupport GA @grafana/aws-datasources false false false
athenaAsyncQueryDataSupport GA @grafana/aws-datasources false false true
32 showDashboardValidationWarnings experimental @grafana/dashboards-squad false false false
33 mysqlAnsiQuotes experimental @grafana/backend-platform false false false
34 accessControlOnCall preview @grafana/identity-access-team false false false

8
pkg/services/featuremgmt/toggles_gen.go
Unescape View File

@ -127,14 +127,6 @@ const (
// Enables cross-account querying in CloudWatch datasources
FlagCloudWatchCrossAccountQuerying = "cloudWatchCrossAccountQuerying"
// FlagRedshiftAsyncQueryDataSupport
// Enable async query data support for Redshift
FlagRedshiftAsyncQueryDataSupport = "redshiftAsyncQueryDataSupport"
// FlagAthenaAsyncQueryDataSupport
// Enable async query data support for Athena
FlagAthenaAsyncQueryDataSupport = "athenaAsyncQueryDataSupport"
// FlagShowDashboardValidationWarnings
// Show warnings when dashboards do not validate against the schema
FlagShowDashboardValidationWarnings = "showDashboardValidationWarnings"

6
pkg/services/featuremgmt/toggles_gen.json
Unescape View File

@ -506,7 +506,8 @@
"metadata": {
"name": "redshiftAsyncQueryDataSupport",
"resourceVersion": "1709648236447",
"creationTimestamp": "2024-03-05T14:17:16Z"
"creationTimestamp": "2024-03-05T14:17:16Z",
"deletionTimestamp": "2024-03-18T12:15:18Z"
},
"spec": {
"description": "Enable async query data support for Redshift",
@ -1055,7 +1056,8 @@
"metadata": {
"name": "athenaAsyncQueryDataSupport",
"resourceVersion": "1709648236447",
"creationTimestamp": "2024-03-05T14:17:16Z"
"creationTimestamp": "2024-03-05T14:17:16Z",
"deletionTimestamp": "2024-03-18T12:15:18Z"
},
"spec": {
"description": "Enable async query data support for Athena",

Write Preview
Loading…
Cancel
Save