diff --git a/packages/grafana-ui/src/components/AlphaNotice/AlphaNotice.tsx b/packages/grafana-ui/src/components/AlphaNotice/AlphaNotice.tsx index cc362a41f49..3a712eb66ee 100644 --- a/packages/grafana-ui/src/components/AlphaNotice/AlphaNotice.tsx +++ b/packages/grafana-ui/src/components/AlphaNotice/AlphaNotice.tsx @@ -2,6 +2,7 @@ import React, { FC, useContext } from 'react'; import { css, cx } from 'emotion'; import { ThemeContext } from '../../index'; import { PluginState } from '@grafana/data'; +import { Icon } from '../Icon/Icon'; interface Props { state?: PluginState; @@ -30,7 +31,7 @@ export const AlphaNotice: FC = ({ state, text, className }) => { return (
- {state} + {state}
); }; diff --git a/packages/grafana-ui/src/components/Button/Button.story.tsx b/packages/grafana-ui/src/components/Button/Button.story.tsx index 106dc4aa7bc..3c9a42932f4 100644 --- a/packages/grafana-ui/src/components/Button/Button.story.tsx +++ b/packages/grafana-ui/src/components/Button/Button.story.tsx @@ -28,7 +28,7 @@ export const simple = () => { const icon = getIconKnob(); return ( - ); diff --git a/packages/grafana-ui/src/components/ButtonCascader/ButtonCascader.tsx b/packages/grafana-ui/src/components/ButtonCascader/ButtonCascader.tsx index e6a166bc7b3..76282e1e0b4 100644 --- a/packages/grafana-ui/src/components/ButtonCascader/ButtonCascader.tsx +++ b/packages/grafana-ui/src/components/ButtonCascader/ButtonCascader.tsx @@ -40,7 +40,7 @@ export const ButtonCascader: React.FC = props => { expandIcon={null} > ); diff --git a/packages/grafana-ui/src/components/Cascader/Cascader.tsx b/packages/grafana-ui/src/components/Cascader/Cascader.tsx index 5eb4b08c757..00834df5e2b 100644 --- a/packages/grafana-ui/src/components/Cascader/Cascader.tsx +++ b/packages/grafana-ui/src/components/Cascader/Cascader.tsx @@ -212,7 +212,13 @@ export class Cascader extends React.PureComponent value={activeLabel} onKeyDown={this.onInputKeyDown} onChange={() => {}} - suffix={focusCascade ? : } + suffix={ + focusCascade ? ( + + ) : ( + + ) + } /> diff --git a/packages/grafana-ui/src/components/ContextMenu/ContextMenu.tsx b/packages/grafana-ui/src/components/ContextMenu/ContextMenu.tsx index a69a7fb4a82..2f85d15d336 100644 --- a/packages/grafana-ui/src/components/ContextMenu/ContextMenu.tsx +++ b/packages/grafana-ui/src/components/ContextMenu/ContextMenu.tsx @@ -5,6 +5,8 @@ import { selectThemeVariant, ThemeContext } from '../../index'; import { GrafanaTheme } from '@grafana/data'; import { stylesFactory } from '../../themes/stylesFactory'; import { Portal, List } from '../index'; +import { Icon } from '../Icon/Icon'; +import { IconName } from '../../types'; import { LinkTarget } from '@grafana/data'; export interface ContextMenuItem { @@ -140,13 +142,8 @@ const getContextMenuStyles = stylesFactory((theme: GrafanaTheme) => { `, icon: css` opacity: 0.7; - width: 12px; - height: 12px; - display: inline-block; margin-right: 10px; color: ${theme.colors.linkDisabled}; - position: relative; - top: 4px; `, }; }); @@ -226,7 +223,7 @@ const ContextMenuItem: React.FC = React.memo( } }} > - {icon && } {label} + {icon && } {label} ); diff --git a/packages/grafana-ui/src/components/DataLinks/DataLinkEditor.tsx b/packages/grafana-ui/src/components/DataLinks/DataLinkEditor.tsx index d95ce24a526..f622f12ede3 100644 --- a/packages/grafana-ui/src/components/DataLinks/DataLinkEditor.tsx +++ b/packages/grafana-ui/src/components/DataLinks/DataLinkEditor.tsx @@ -5,6 +5,7 @@ import { Switch } from '../Switch/Switch'; import { css } from 'emotion'; import { ThemeContext, stylesFactory } from '../../themes/index'; import { DataLinkInput } from './DataLinkInput'; +import { Icon } from '../Icon/Icon'; interface DataLinkEditorProps { index: number; @@ -60,7 +61,7 @@ export const DataLinkEditor: React.FC = React.memo( /> = ({ header, onBlur, onCha onBlur={onBlur} /> ); diff --git a/packages/grafana-ui/src/components/DataSourceSettings/DataSourceHttpSettings.tsx b/packages/grafana-ui/src/components/DataSourceSettings/DataSourceHttpSettings.tsx index 646a04c158c..e6ec09478db 100644 --- a/packages/grafana-ui/src/components/DataSourceSettings/DataSourceHttpSettings.tsx +++ b/packages/grafana-ui/src/components/DataSourceSettings/DataSourceHttpSettings.tsx @@ -10,6 +10,7 @@ import { HttpSettingsProps } from './types'; import { CustomHeadersSettings } from './CustomHeadersSettings'; import { Select } from '../Forms/Legacy/Select/Select'; import { Input } from '../Forms/Legacy/Input/Input'; +import { Icon } from '../Icon/Icon'; import { FormField } from '../FormField/FormField'; import { FormLabel } from '../FormLabel/FormLabel'; import { Switch } from '../Switch/Switch'; @@ -139,7 +140,7 @@ export const DataSourceHttpSettings: React.FC = props => { onClick={() => setIsAccessHelpVisible(isVisible => !isVisible)} > Help  - + diff --git a/packages/grafana-ui/src/components/Drawer/Drawer.tsx b/packages/grafana-ui/src/components/Drawer/Drawer.tsx index ead948eb347..9fb7d53ea29 100644 --- a/packages/grafana-ui/src/components/Drawer/Drawer.tsx +++ b/packages/grafana-ui/src/components/Drawer/Drawer.tsx @@ -3,6 +3,7 @@ import { GrafanaTheme } from '@grafana/data'; import RcDrawer from 'rc-drawer'; import { css } from 'emotion'; import CustomScrollbar from '../CustomScrollbar/CustomScrollbar'; +import { Icon } from '../Icon/Icon'; import { stylesFactory, useTheme } from '../../themes'; export interface Props { @@ -93,7 +94,7 @@ export const Drawer: FC = ({
{title}
- +
)} diff --git a/packages/grafana-ui/src/components/FormLabel/FormLabel.tsx b/packages/grafana-ui/src/components/FormLabel/FormLabel.tsx index ca3fd9bf4f5..19cfdf6e615 100644 --- a/packages/grafana-ui/src/components/FormLabel/FormLabel.tsx +++ b/packages/grafana-ui/src/components/FormLabel/FormLabel.tsx @@ -34,7 +34,7 @@ export const FormLabel: FunctionComponent = ({ {tooltip && (
- +
)} diff --git a/packages/grafana-ui/src/components/Forms/FieldValidationMessage.tsx b/packages/grafana-ui/src/components/Forms/FieldValidationMessage.tsx index f1c57a41651..6b6dc427979 100644 --- a/packages/grafana-ui/src/components/Forms/FieldValidationMessage.tsx +++ b/packages/grafana-ui/src/components/Forms/FieldValidationMessage.tsx @@ -2,6 +2,7 @@ import React from 'react'; import { useTheme, stylesFactory } from '../../themes'; import { GrafanaTheme } from '@grafana/data'; import { css, cx } from 'emotion'; +import { Icon } from '../Icon/Icon'; export interface FieldValidationMessageProps { children: string; @@ -45,7 +46,7 @@ export const FieldValidationMessage: React.FC = ({ return (
- + {children}
); diff --git a/packages/grafana-ui/src/components/Forms/Legacy/Select/ButtonSelect.story.internal.tsx b/packages/grafana-ui/src/components/Forms/Legacy/Select/ButtonSelect.story.internal.tsx index 9dff759ed59..e1575baac79 100644 --- a/packages/grafana-ui/src/components/Forms/Legacy/Select/ButtonSelect.story.internal.tsx +++ b/packages/grafana-ui/src/components/Forms/Legacy/Select/ButtonSelect.story.internal.tsx @@ -32,7 +32,7 @@ ButtonSelectStories.add('default', () => { }} label={value.label ? value.label : ''} className="refresh-select" - iconClass={text('iconClass', 'fa fa-clock-o fa-fw')} + iconClass={text('iconClass', 'clock-nine')} /> ); }} diff --git a/packages/grafana-ui/src/components/Forms/Legacy/Select/ButtonSelect.tsx b/packages/grafana-ui/src/components/Forms/Legacy/Select/ButtonSelect.tsx index 4379b35d457..da4d801529f 100644 --- a/packages/grafana-ui/src/components/Forms/Legacy/Select/ButtonSelect.tsx +++ b/packages/grafana-ui/src/components/Forms/Legacy/Select/ButtonSelect.tsx @@ -2,6 +2,7 @@ import React, { PureComponent, ReactElement } from 'react'; import Select from './Select'; import { PopoverContent } from '../../../Tooltip/Tooltip'; import { Icon } from '../../../Icon/Icon'; +import { IconName } from '../../../../types'; import { SelectableValue } from '@grafana/data'; interface ButtonComponentProps { @@ -22,7 +23,7 @@ const ButtonComponent = (buttonProps: ButtonComponentProps) => (props: any) => { tabIndex={0} // necessary to get onBlur to work https://developer.mozilla.org/en-US/docs/Web/HTML/Element/button#Clicking_and_focus >
- {iconClass && } + {iconClass && } {label ? label : ''} {!props.menuIsOpen && } {props.menuIsOpen && } diff --git a/packages/grafana-ui/src/components/Forms/Legacy/Select/IndicatorsContainer.tsx b/packages/grafana-ui/src/components/Forms/Legacy/Select/IndicatorsContainer.tsx index 260fe6ebbdf..08f78bd11e2 100644 --- a/packages/grafana-ui/src/components/Forms/Legacy/Select/IndicatorsContainer.tsx +++ b/packages/grafana-ui/src/components/Forms/Legacy/Select/IndicatorsContainer.tsx @@ -1,4 +1,5 @@ import React from 'react'; +import { Icon } from '../../../Icon/Icon'; // Ignoring because I couldn't get @types/react-select work wih Torkel's fork // @ts-ignore @@ -8,9 +9,7 @@ export const IndicatorsContainer = (props: any) => { const isOpen = props.selectProps.menuIsOpen; return ( - + ); }; diff --git a/packages/grafana-ui/src/components/Forms/Legacy/Select/SelectOption.tsx b/packages/grafana-ui/src/components/Forms/Legacy/Select/SelectOption.tsx index b3606797918..1d7b64c7d49 100644 --- a/packages/grafana-ui/src/components/Forms/Legacy/Select/SelectOption.tsx +++ b/packages/grafana-ui/src/components/Forms/Legacy/Select/SelectOption.tsx @@ -1,4 +1,5 @@ import React from 'react'; +import { Icon } from '../../../Icon/Icon'; // Ignoring because I couldn't get @types/react-select work wih Torkel's fork // @ts-ignore @@ -24,7 +25,7 @@ export const SelectOption = (props: ExtendedOptionProps) => {
{children}
{data.description &&
{data.description}
}
- {isSelected &&