Fix: JSON parsing in backend_srv (#45598)

* fix(plugins/state): console log errors during install / uninstall

* fix(backend_srv): catch JSON parse errors

Sometimes it can happen that a backend API responses says that it's
returning with a JSON content-type, however it actually returns an invalid
JSON (e.g. an empty body) - in which case the backendSrv() request errors out.
pull/44980/head
Levente Balogh 4 years ago committed by GitHub
parent e44ea3d589
commit 1e21184f65
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 7
      public/app/core/utils/fetch.ts
  2. 4
      public/app/features/plugins/admin/state/actions.ts

@ -105,7 +105,12 @@ export async function parseResponseBody<T>(
return response.blob() as any;
case 'json':
return response.json();
try {
return await response.json();
} catch (err) {
console.warn(`${response.url} returned an invalid JSON -`, err);
return {} as unknown as T;
}
case 'text':
return response.text() as any;

@ -73,6 +73,8 @@ export const install = createAsyncThunk(
return { id, changes } as Update<CatalogPlugin>;
} catch (e) {
console.error(e);
return thunkApi.rejectWithValue('Unknown error.');
}
}
@ -90,6 +92,8 @@ export const uninstall = createAsyncThunk(`${STATE_PREFIX}/uninstall`, async (id
changes: { isInstalled: false, installedVersion: undefined },
} as Update<CatalogPlugin>;
} catch (e) {
console.error(e);
return thunkApi.rejectWithValue('Unknown error.');
}
});

Loading…
Cancel
Save