From 2aae202f9287b37217dc45f8cd4643abdcdbd3b3 Mon Sep 17 00:00:00 2001 From: kay delaney <45561153+kaydelaney@users.noreply.github.com> Date: Tue, 17 Jun 2025 14:50:34 +0100 Subject: [PATCH] Library Panels: Mark library panel RBAC as GA & enable by default (#106833) --- .../configure-grafana/feature-toggles/index.md | 1 + .../grafana-data/src/types/featureToggles.gen.ts | 1 + pkg/services/featuremgmt/registry.go | 3 ++- pkg/services/featuremgmt/toggles_gen.csv | 2 +- pkg/services/featuremgmt/toggles_gen.json | 12 ++++++++---- 5 files changed, 13 insertions(+), 6 deletions(-) diff --git a/docs/sources/setup-grafana/configure-grafana/feature-toggles/index.md b/docs/sources/setup-grafana/configure-grafana/feature-toggles/index.md index 9e5a06d7cc8..912efa648d2 100644 --- a/docs/sources/setup-grafana/configure-grafana/feature-toggles/index.md +++ b/docs/sources/setup-grafana/configure-grafana/feature-toggles/index.md @@ -42,6 +42,7 @@ Most [generally available](https://grafana.com/docs/release-life-cycle/#general- | `awsAsyncQueryCaching` | Enable caching for async queries for Redshift and Athena. Requires that the datasource has caching and async query support enabled | Yes | | `angularDeprecationUI` | Display Angular warnings in dashboards and panels | Yes | | `dashgpt` | Enable AI powered features in dashboards | Yes | +| `libraryPanelRBAC` | Enables RBAC support for library panels | Yes | | `externalCorePlugins` | Allow core plugins to be loaded as external | Yes | | `panelMonitoring` | Enables panel monitoring through logs and measurements | Yes | | `formatString` | Enable format string transformer | Yes | diff --git a/packages/grafana-data/src/types/featureToggles.gen.ts b/packages/grafana-data/src/types/featureToggles.gen.ts index f8d2aa164f8..abba4ca2c7e 100644 --- a/packages/grafana-data/src/types/featureToggles.gen.ts +++ b/packages/grafana-data/src/types/featureToggles.gen.ts @@ -262,6 +262,7 @@ export interface FeatureToggles { sseGroupByDatasource?: boolean; /** * Enables RBAC support for library panels + * @default true */ libraryPanelRBAC?: boolean; /** diff --git a/pkg/services/featuremgmt/registry.go b/pkg/services/featuremgmt/registry.go index 170bafef157..ece77ff06fa 100644 --- a/pkg/services/featuremgmt/registry.go +++ b/pkg/services/featuremgmt/registry.go @@ -430,10 +430,11 @@ var ( { Name: "libraryPanelRBAC", Description: "Enables RBAC support for library panels", - Stage: FeatureStageExperimental, + Stage: FeatureStageGeneralAvailability, FrontendOnly: false, Owner: grafanaDashboardsSquad, RequiresRestart: true, + Expression: "true", }, { Name: "lokiRunQueriesInParallel", diff --git a/pkg/services/featuremgmt/toggles_gen.csv b/pkg/services/featuremgmt/toggles_gen.csv index b1c0b4d990e..fde28104831 100644 --- a/pkg/services/featuremgmt/toggles_gen.csv +++ b/pkg/services/featuremgmt/toggles_gen.csv @@ -55,7 +55,7 @@ dashgpt,GA,@grafana/dashboards-squad,false,false,true aiGeneratedDashboardChanges,experimental,@grafana/dashboards-squad,false,false,true reportingRetries,preview,@grafana/sharing-squad,false,true,false sseGroupByDatasource,experimental,@grafana/observability-metrics,false,false,false -libraryPanelRBAC,experimental,@grafana/dashboards-squad,false,true,false +libraryPanelRBAC,GA,@grafana/dashboards-squad,false,true,false lokiRunQueriesInParallel,privatePreview,@grafana/observability-logs,false,false,false externalCorePlugins,GA,@grafana/plugins-platform-backend,false,false,false externalServiceAccounts,preview,@grafana/identity-access-team,false,false,false diff --git a/pkg/services/featuremgmt/toggles_gen.json b/pkg/services/featuremgmt/toggles_gen.json index cfc730e72a2..40997549ea6 100644 --- a/pkg/services/featuremgmt/toggles_gen.json +++ b/pkg/services/featuremgmt/toggles_gen.json @@ -1850,14 +1850,18 @@ { "metadata": { "name": "libraryPanelRBAC", - "resourceVersion": "1743693517832", - "creationTimestamp": "2023-10-11T23:30:50Z" + "resourceVersion": "1750162291839", + "creationTimestamp": "2023-10-11T23:30:50Z", + "annotations": { + "grafana.app/updatedTimestamp": "2025-06-17 12:11:31.83962 +0000 UTC" + } }, "spec": { "description": "Enables RBAC support for library panels", - "stage": "experimental", + "stage": "GA", "codeowner": "@grafana/dashboards-squad", - "requiresRestart": true + "requiresRestart": true, + "expression": "true" } }, {