Datasources: Pass down the edit-form errors (#69830)

feat: pass the error to the event handler
pull/71538/head
Levente Balogh 2 years ago committed by GitHub
parent 32ff712e98
commit 324b33146a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 6
      public/app/features/datasources/components/EditDataSource.tsx
  2. 4
      public/app/features/datasources/tracking.ts

@ -130,10 +130,10 @@ export function EditDataSourceView({
try {
await onUpdate({ ...dataSource });
trackDsConfigUpdated('success');
trackDsConfigUpdated({ item: 'success' });
appEvents.publish(new DataSourceUpdatedSuccessfully());
} catch (err) {
trackDsConfigUpdated('fail');
} catch (error) {
trackDsConfigUpdated({ item: 'fail', error });
return;
}

@ -83,6 +83,6 @@ export const trackDsConfigClicked = (item: string) => {
reportInteraction('connections_datasources_settings_clicked', { item });
};
export const trackDsConfigUpdated = (item: string) => {
reportInteraction('connections_datasources_ds_configured', { item });
export const trackDsConfigUpdated = (props: { item: string; error?: unknown }) => {
reportInteraction('connections_datasources_ds_configured', props);
};

Loading…
Cancel
Save