Move error log in social.go inside err != nil (#27804)

5 years ago · 334cb41a99
parent 69ba7bff82
commit 334cb41a99
1 changed files with 1 additions and 1 deletions
--- a/pkg/login/social/social.go
+++ b/pkg/login/social/social.go
@ -258,8 +258,8 @@ func GetOAuthHttpClient(name string) (*http.Client, error) {

 	if info.TlsClientCert != "" || info.TlsClientKey != "" {
 		cert, err := tls.LoadX509KeyPair(info.TlsClientCert, info.TlsClientKey)
-		logger.Error("Failed to setup TlsClientCert", "oauth", name, "error", err)
 		if err != nil {
+			logger.Error("Failed to setup TlsClientCert", "oauth", name, "error", err)
 			return nil, fmt.Errorf("Failed to setup TlsClientCert")
 		}