From 37c6a0b3cb3ad9ff25a5ece31d7cbddfdd4551a4 Mon Sep 17 00:00:00 2001
From: Seyaji <67058118+Seyaji@users.noreply.github.com>
Date: Tue, 28 Jun 2022 11:20:37 +0100
Subject: [PATCH] Chore: Convert AccordianReferences test to RTL (#51274)

* Convert AccordianReferences test to RTL

* Convert AccordianReferences test to RTL

* Convert AccordianReferences test to RTL

* Convert AccordianReferences tests to RTL

* Convert AccordianReferences test to RTL

* fix betterer

* Convert AccordianReferences test to RTL

Co-authored-by: Ashley Harrison <ashley.harrison@grafana.com>
---
 .betterer.results                             |  3 -
 .../SpanDetail/AccordianReferences.test.js    | 63 +++++++------------
 2 files changed, 23 insertions(+), 43 deletions(-)

diff --git a/.betterer.results b/.betterer.results
index e397f28d6ad..3054eb7cbd1 100644
--- a/.betterer.results
+++ b/.betterer.results
@@ -44,9 +44,6 @@ exports[`no enzyme tests`] = {
     "packages/jaeger-ui-components/src/TraceTimelineViewer/ListView/index.test.js:1734982398": [
       [14, 26, 13, "RegExp match", "2409514259"]
     ],
-    "packages/jaeger-ui-components/src/TraceTimelineViewer/SpanDetail/AccordianReferences.test.js:2025513694": [
-      [14, 19, 13, "RegExp match", "2409514259"]
-    ],
     "packages/jaeger-ui-components/src/TraceTimelineViewer/SpanDetail/KeyValuesTable.test.js:3813002651": [
       [14, 19, 13, "RegExp match", "2409514259"]
     ],
diff --git a/packages/jaeger-ui-components/src/TraceTimelineViewer/SpanDetail/AccordianReferences.test.js b/packages/jaeger-ui-components/src/TraceTimelineViewer/SpanDetail/AccordianReferences.test.js
index 88003e8a888..e0ea5d8c38c 100644
--- a/packages/jaeger-ui-components/src/TraceTimelineViewer/SpanDetail/AccordianReferences.test.js
+++ b/packages/jaeger-ui-components/src/TraceTimelineViewer/SpanDetail/AccordianReferences.test.js
@@ -12,11 +12,9 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-import { shallow } from 'enzyme';
+import { render, screen } from '@testing-library/react';
 import React from 'react';
 
-import ReferenceLink from '../../url/ReferenceLink';
-
 import AccordianReferences, { References } from './AccordianReferences';
 
 const traceID = 'trace1';
@@ -54,60 +52,45 @@ const references = [
   },
 ];
 
-describe('<AccordianReferences>', () => {
-  let wrapper;
+const link = { href: 'link' };
 
+const setup = (propOverrides) => {
   const props = {
     compact: false,
     data: references,
     highContrast: false,
     isOpen: false,
     onToggle: jest.fn(),
-    createFocusSpanLink: jest.fn(),
+    createFocusSpanLink: () => link,
+    ...propOverrides,
   };
 
-  beforeEach(() => {
-    wrapper = shallow(<AccordianReferences {...props} />);
-  });
+  return render(<AccordianReferences {...props} />);
+};
 
+describe('AccordianReferences tests', () => {
   it('renders without exploding', () => {
-    expect(wrapper).toBeDefined();
-    expect(wrapper.exists()).toBe(true);
+    expect(() => setup()).not.toThrow();
   });
 
-  it('renders the content when it is expanded', () => {
-    wrapper.setProps({ isOpen: true });
-    const content = wrapper.find(References);
-    expect(content.length).toBe(1);
-    expect(content.prop('data')).toBe(references);
+  it('renders the correct number of references', () => {
+    setup();
+
+    expect(screen.getByRole('switch', { name: 'References (3)' })).toBeInTheDocument();
   });
-});
 
-describe('<References>', () => {
-  let wrapper;
+  it('content doesnt show when not expanded', () => {
+    setup({ isOpen: false });
 
-  const props = {
-    data: references,
-    createFocusSpanLink: jest.fn(),
-  };
-
-  beforeEach(() => {
-    wrapper = shallow(<References {...props} />);
+    expect(screen.queryByRole('link', { name: /^View\sLinked/ })).not.toBeInTheDocument();
+    expect(screen.queryAllByRole('link', { name: /^service\d\sop\d/ })).toHaveLength(0);
   });
 
-  it('render references list', () => {
-    const refLinks = wrapper.find(ReferenceLink);
-    expect(refLinks.length).toBe(references.length);
-    refLinks.forEach((refLink, i) => {
-      const span = references[i].span;
-      const serviceName = refLink.find('span.span-svc-name').text();
-      if (span && span.traceID === traceID) {
-        const endpointName = refLink.find('small.endpoint-name').text();
-        expect(serviceName).toBe(span.process.serviceName);
-        expect(endpointName).toBe(span.operationName);
-      } else {
-        expect(serviceName).toBe('View Linked Span ');
-      }
-    });
+  it('renders the content when it is expanded', () => {
+    setup({ isOpen: true });
+
+    expect(screen.getByRole('switch', { name: 'References (3)' })).toBeInTheDocument();
+    expect(screen.getAllByRole('link', { name: /^service\d\sop\d/ })).toHaveLength(2);
+    expect(screen.getByRole('link', { name: /^View\sLinked/ })).toBeInTheDocument();
   });
 });