apply security patch: release-11.4.4/366-202504020732.patch

commit 91f4f149c8eecf0a3b6d3a6fa6b5611879665123
Author: Andres Martinez Gotor <andres.martinez@grafana.com>
Date:   Mon Mar 31 12:15:52 2025 +0200

    Sanitize paths before evaluating access to route
release-11.4.4+security-01
github-actions[bot] 2 months ago
parent 0c7510b5a9
commit 39c44e2afb
  1. 10
      pkg/api/pluginproxy/ds_proxy.go
  2. 8
      pkg/api/pluginproxy/ds_proxy_test.go

@ -299,7 +299,15 @@ func (proxy *DataSourceProxy) validateRequest() error {
}
// route match
if !strings.HasPrefix(proxy.proxyPath, route.Path) {
r1, err := util.CleanRelativePath(proxy.proxyPath)
if err != nil {
return err
}
r2, err := util.CleanRelativePath(route.Path)
if err != nil {
return err
}
if !strings.HasPrefix(r1, r2) {
continue
}

@ -258,6 +258,14 @@ func TestDataSourceProxy_routeRule(t *testing.T) {
err = proxy.validateRequest()
require.NoError(t, err)
})
t.Run("path with slashes and user is editor", func(t *testing.T) {
ctx, _ := setUp()
proxy, err := setupDSProxyTest(t, ctx, ds, routes, "//api//admin")
require.NoError(t, err)
err = proxy.validateRequest()
require.Error(t, err)
})
})
t.Run("plugin route with RBAC protection user is allowed", func(t *testing.T) {

Loading…
Cancel
Save