diff --git a/public/app/core/components/NavBar/NavBarItem.tsx b/public/app/core/components/NavBar/NavBarItem.tsx index 974d1d4a04a..84648fb38d2 100644 --- a/public/app/core/components/NavBar/NavBarItem.tsx +++ b/public/app/core/components/NavBar/NavBarItem.tsx @@ -35,7 +35,7 @@ const NavBarItem = ({ .filter((item) => !item.hideFromMenu) .map((i) => ({ ...i, menuItemType: NavMenuItemType.Item })); const adjustHeightForBorder = filteredItems.length === 0; - const styles = getStyles(theme, adjustHeightForBorder, isActive, reverseMenuDirection); + const styles = getStyles(theme, adjustHeightForBorder, isActive); const section: NavModelItem = { ...link, children: filteredItems, @@ -115,12 +115,7 @@ const NavBarItem = ({ export default NavBarItem; -const getStyles = ( - theme: GrafanaTheme2, - adjustHeightForBorder: boolean, - isActive?: boolean, - reverseMenuDirection?: boolean -) => ({ +const getStyles = (theme: GrafanaTheme2, adjustHeightForBorder: boolean, isActive?: boolean) => ({ ...getNavBarItemWithoutMenuStyles(theme, isActive), header: css` color: ${theme.colors.text.primary}; @@ -134,12 +129,4 @@ const getStyles = ( item: css` color: ${theme.colors.text.primary}; `, - subtitle: css` - border-${reverseMenuDirection ? 'bottom' : 'top'}: 1px solid ${theme.colors.border.weak}; - color: ${theme.colors.text.secondary}; - font-size: ${theme.typography.bodySmall.fontSize}; - font-weight: ${theme.typography.bodySmall.fontWeight}; - padding: ${theme.spacing(1)} ${theme.spacing(2)} ${theme.spacing(1)}; - white-space: nowrap; - `, }); diff --git a/public/app/core/components/NavBar/NavBarItemMenu.tsx b/public/app/core/components/NavBar/NavBarItemMenu.tsx index 7b3e9659247..000b996dc0e 100644 --- a/public/app/core/components/NavBar/NavBarItemMenu.tsx +++ b/public/app/core/components/NavBar/NavBarItemMenu.tsx @@ -25,7 +25,7 @@ export function NavBarItemMenu(props: NavBarItemMenuProps): ReactElement | null }; const { menuHasFocus, menuProps: contextMenuProps = {} } = contextProps; const theme = useTheme2(); - const styles = getStyles(theme, adjustHeightForBorder, reverseMenuDirection); + const styles = getStyles(theme, reverseMenuDirection); const state = useTreeState({ ...rest, disabledKeys }); const ref = useRef(null); const { menuProps } = useMenu(completeProps, { ...state }, ref); @@ -54,38 +54,26 @@ export function NavBarItemMenu(props: NavBarItemMenuProps): ReactElement | null ); - const subTitleComponent = ( -
  • -
    {menuSubTitle}
    + const itemComponents = items.map((item) => ( + + )); + + const subTitleComponent = menuSubTitle && ( +
  • + {menuSubTitle}
  • ); + const menu = [sectionComponent, itemComponents, subTitleComponent]; + return ( -