Fix click-based selection of typeahead suggestion

In short, the underlying problem appears to be the `onChange()` handler
being triggered after handling the blur event. Since the contents have
not actually changed this forces the typeahead state to reset which
undesirably puts a stop to propagating the selected suggestion back up
to get set.

Related: #13604
pull/13773/head
Michael Huynh 7 years ago
parent bf1a0585ed
commit 3bb0b0a551
No known key found for this signature in database
GPG Key ID: 760127DAE4EDD351
  1. 3
      public/app/features/explore/QueryField.tsx

@ -198,7 +198,7 @@ class QueryField extends React.PureComponent<TypeaheadFieldProps, TypeaheadField
if (textChanged && value.selection.isCollapsed) {
// Need one paint to allow DOM-based typeahead rules to work
window.requestAnimationFrame(this.handleTypeahead);
} else {
} else if (!this.resetTimer) {
this.resetTypeahead();
}
};
@ -402,6 +402,7 @@ class QueryField extends React.PureComponent<TypeaheadFieldProps, TypeaheadField
typeaheadPrefix: '',
typeaheadContext: null,
});
this.resetTimer = null;
};
handleBlur = () => {

Loading…
Cancel
Save