diff --git a/pkg/registry/apis/secret/encryption/manager/manager_test.go b/pkg/registry/apis/secret/encryption/manager/manager_test.go index e6b5b05ca9b..75eeab5e8d2 100644 --- a/pkg/registry/apis/secret/encryption/manager/manager_test.go +++ b/pkg/registry/apis/secret/encryption/manager/manager_test.go @@ -75,7 +75,7 @@ func TestEncryptionService_EnvelopeEncryption(t *testing.T) { func TestEncryptionService_DataKeys(t *testing.T) { // Initialize data key storage with a fake db testDB := sqlstore.NewTestStore(t, sqlstore.WithMigrator(migrator.New())) - features := featuremgmt.WithFeatures(featuremgmt.FlagGrafanaAPIServerWithExperimentalAPIs, featuremgmt.FlagSecretsManagementAppPlatform) + features := featuremgmt.WithFeatures(featuremgmt.FlagSecretsManagementAppPlatform) tracer := noop.NewTracerProvider().Tracer("test") store, err := encryptionstorage.ProvideDataKeyStorage(database.ProvideDatabase(testDB, tracer), tracer, features, nil) require.NoError(t, err) @@ -180,7 +180,7 @@ func TestEncryptionService_UseCurrentProvider(t *testing.T) { }, } - features := featuremgmt.WithFeatures(featuremgmt.FlagGrafanaAPIServerWithExperimentalAPIs, featuremgmt.FlagSecretsManagementAppPlatform) + features := featuremgmt.WithFeatures(featuremgmt.FlagSecretsManagementAppPlatform) testDB := sqlstore.NewTestStore(t, sqlstore.WithMigrator(migrator.New())) tracer := noop.NewTracerProvider().Tracer("test") encryptionStore, err := encryptionstorage.ProvideDataKeyStorage(database.ProvideDatabase(testDB, tracer), tracer, features, nil) @@ -365,7 +365,7 @@ func TestIntegration_SecretsService(t *testing.T) { testDB := sqlstore.NewTestStore(t, sqlstore.WithMigrator(migrator.New())) tracer := noop.NewTracerProvider().Tracer("test") - features := featuremgmt.WithFeatures(featuremgmt.FlagGrafanaAPIServerWithExperimentalAPIs, featuremgmt.FlagSecretsManagementAppPlatform) + features := featuremgmt.WithFeatures(featuremgmt.FlagSecretsManagementAppPlatform) defaultKey := "SdlklWklckeLS" cfg := &setting.Cfg{ diff --git a/pkg/registry/apis/secret/encryption/manager/test_helpers.go b/pkg/registry/apis/secret/encryption/manager/test_helpers.go index a3958b5df7c..535db771f5d 100644 --- a/pkg/registry/apis/secret/encryption/manager/test_helpers.go +++ b/pkg/registry/apis/secret/encryption/manager/test_helpers.go @@ -23,7 +23,7 @@ func setupTestService(tb testing.TB) *EncryptionManager { tracer := noop.NewTracerProvider().Tracer("test") database := database.ProvideDatabase(testDB, tracer) - features := featuremgmt.WithFeatures(featuremgmt.FlagGrafanaAPIServerWithExperimentalAPIs, featuremgmt.FlagSecretsManagementAppPlatform) + features := featuremgmt.WithFeatures(featuremgmt.FlagSecretsManagementAppPlatform) defaultKey := "SdlklWklckeLS" cfg := &setting.Cfg{ SecretsManagement: setting.SecretsManagerSettings{ diff --git a/pkg/registry/apis/secret/register.go b/pkg/registry/apis/secret/register.go index f43b164f6b4..89ad9cd9f4e 100644 --- a/pkg/registry/apis/secret/register.go +++ b/pkg/registry/apis/secret/register.go @@ -19,7 +19,7 @@ func RegisterDependencies( secretDBMigrator contracts.SecretDBMigrator, accessControlService accesscontrol.Service, ) (*DependencyRegisterer, error) { - if !features.IsEnabledGlobally(featuremgmt.FlagGrafanaAPIServerWithExperimentalAPIs) || !features.IsEnabledGlobally(featuremgmt.FlagSecretsManagementAppPlatform) { + if !features.IsEnabledGlobally(featuremgmt.FlagSecretsManagementAppPlatform) { return nil, nil } diff --git a/pkg/registry/apis/secret/secretkeeper/secretkeeper_test.go b/pkg/registry/apis/secret/secretkeeper/secretkeeper_test.go index f202babab8d..a0d3a739523 100644 --- a/pkg/registry/apis/secret/secretkeeper/secretkeeper_test.go +++ b/pkg/registry/apis/secret/secretkeeper/secretkeeper_test.go @@ -47,7 +47,7 @@ func setupTestService(t *testing.T, cfg *setting.Cfg) (*OSSKeeperService, error) testDB := sqlstore.NewTestStore(t, sqlstore.WithMigrator(migrator.New())) tracer := noop.NewTracerProvider().Tracer("test") database := database.ProvideDatabase(testDB, tracer) - features := featuremgmt.WithFeatures(featuremgmt.FlagGrafanaAPIServerWithExperimentalAPIs, featuremgmt.FlagSecretsManagementAppPlatform) + features := featuremgmt.WithFeatures(featuremgmt.FlagSecretsManagementAppPlatform) dataKeyStore, err := encryptionstorage.ProvideDataKeyStorage(database, tracer, features, nil) require.NoError(t, err) diff --git a/pkg/registry/apis/secret/testutils/testutils.go b/pkg/registry/apis/secret/testutils/testutils.go index 3c189390c7a..bc2309231a4 100644 --- a/pkg/registry/apis/secret/testutils/testutils.go +++ b/pkg/registry/apis/secret/testutils/testutils.go @@ -64,7 +64,7 @@ func Setup(t *testing.T, opts ...func(*SetupConfig)) Sut { database := database.ProvideDatabase(testDB, tracer) - features := featuremgmt.WithFeatures(featuremgmt.FlagGrafanaAPIServerWithExperimentalAPIs, featuremgmt.FlagSecretsManagementAppPlatform) + features := featuremgmt.WithFeatures(featuremgmt.FlagSecretsManagementAppPlatform) keeperMetadataStorage, err := metadata.ProvideKeeperMetadataStorage(database, tracer, features, nil) require.NoError(t, err) diff --git a/pkg/storage/secret/encryption/data_key_store.go b/pkg/storage/secret/encryption/data_key_store.go index 78c2bf63910..08fc1875491 100644 --- a/pkg/storage/secret/encryption/data_key_store.go +++ b/pkg/storage/secret/encryption/data_key_store.go @@ -29,8 +29,7 @@ func ProvideDataKeyStorage( features featuremgmt.FeatureToggles, registerer prometheus.Registerer, ) (contracts.DataKeyStorage, error) { - if !features.IsEnabledGlobally(featuremgmt.FlagGrafanaAPIServerWithExperimentalAPIs) || - !features.IsEnabledGlobally(featuremgmt.FlagSecretsManagementAppPlatform) { + if !features.IsEnabledGlobally(featuremgmt.FlagSecretsManagementAppPlatform) { return &encryptionStoreImpl{}, nil } diff --git a/pkg/storage/secret/encryption/data_key_store_test.go b/pkg/storage/secret/encryption/data_key_store_test.go index 4f2d52d3387..89b38ceac61 100644 --- a/pkg/storage/secret/encryption/data_key_store_test.go +++ b/pkg/storage/secret/encryption/data_key_store_test.go @@ -30,7 +30,7 @@ func TestEncryptionStoreImpl_DataKeyLifecycle(t *testing.T) { // Initialize data key storage with a fake db testDB := sqlstore.NewTestStore(t, sqlstore.WithMigrator(migrator.New())) tracer := noop.NewTracerProvider().Tracer("test") - features := featuremgmt.WithFeatures(featuremgmt.FlagGrafanaAPIServerWithExperimentalAPIs, featuremgmt.FlagSecretsManagementAppPlatform) + features := featuremgmt.WithFeatures(featuremgmt.FlagSecretsManagementAppPlatform) store, err := ProvideDataKeyStorage(database.ProvideDatabase(testDB, tracer), tracer, features, nil) require.NoError(t, err) diff --git a/pkg/storage/secret/encryption/encrypted_value_store.go b/pkg/storage/secret/encryption/encrypted_value_store.go index f681a93a887..44cb5dd1d07 100644 --- a/pkg/storage/secret/encryption/encrypted_value_store.go +++ b/pkg/storage/secret/encryption/encrypted_value_store.go @@ -26,8 +26,7 @@ func ProvideEncryptedValueStorage( tracer trace.Tracer, features featuremgmt.FeatureToggles, ) (contracts.EncryptedValueStorage, error) { - if !features.IsEnabledGlobally(featuremgmt.FlagGrafanaAPIServerWithExperimentalAPIs) || - !features.IsEnabledGlobally(featuremgmt.FlagSecretsManagementAppPlatform) { + if !features.IsEnabledGlobally(featuremgmt.FlagSecretsManagementAppPlatform) { return &encryptedValStorage{}, nil } diff --git a/pkg/storage/secret/metadata/decrypt_store.go b/pkg/storage/secret/metadata/decrypt_store.go index d2aea92f54b..3b1b7973438 100644 --- a/pkg/storage/secret/metadata/decrypt_store.go +++ b/pkg/storage/secret/metadata/decrypt_store.go @@ -30,8 +30,7 @@ func ProvideDecryptStorage( decryptAuthorizer contracts.DecryptAuthorizer, reg prometheus.Registerer, ) (contracts.DecryptStorage, error) { - if !features.IsEnabledGlobally(featuremgmt.FlagGrafanaAPIServerWithExperimentalAPIs) || - !features.IsEnabledGlobally(featuremgmt.FlagSecretsManagementAppPlatform) { + if !features.IsEnabledGlobally(featuremgmt.FlagSecretsManagementAppPlatform) { return &decryptStorage{}, nil } diff --git a/pkg/storage/secret/metadata/keeper_store.go b/pkg/storage/secret/metadata/keeper_store.go index 6b4e73fc2bd..656ac404577 100644 --- a/pkg/storage/secret/metadata/keeper_store.go +++ b/pkg/storage/secret/metadata/keeper_store.go @@ -33,8 +33,7 @@ func ProvideKeeperMetadataStorage( features featuremgmt.FeatureToggles, reg prometheus.Registerer, ) (contracts.KeeperMetadataStorage, error) { - if !features.IsEnabledGlobally(featuremgmt.FlagGrafanaAPIServerWithExperimentalAPIs) || - !features.IsEnabledGlobally(featuremgmt.FlagSecretsManagementAppPlatform) { + if !features.IsEnabledGlobally(featuremgmt.FlagSecretsManagementAppPlatform) { return &keeperMetadataStorage{}, nil } diff --git a/pkg/storage/secret/metadata/keeper_store_test.go b/pkg/storage/secret/metadata/keeper_store_test.go index 02f2207b61f..4d61422b15f 100644 --- a/pkg/storage/secret/metadata/keeper_store_test.go +++ b/pkg/storage/secret/metadata/keeper_store_test.go @@ -333,7 +333,7 @@ func initStorage(t *testing.T) contracts.KeeperMetadataStorage { testDB := sqlstore.NewTestStore(t, sqlstore.WithMigrator(migrator.New())) tracer := noop.NewTracerProvider().Tracer("test") db := database.ProvideDatabase(testDB, tracer) - features := featuremgmt.WithFeatures(featuremgmt.FlagGrafanaAPIServerWithExperimentalAPIs, featuremgmt.FlagSecretsManagementAppPlatform) + features := featuremgmt.WithFeatures(featuremgmt.FlagSecretsManagementAppPlatform) // Initialize the keeper storage keeperMetadataStorage, err := metadata.ProvideKeeperMetadataStorage(db, tracer, features, nil) diff --git a/pkg/storage/secret/metadata/secure_value_store.go b/pkg/storage/secret/metadata/secure_value_store.go index 829a48481a7..56af9617790 100644 --- a/pkg/storage/secret/metadata/secure_value_store.go +++ b/pkg/storage/secret/metadata/secure_value_store.go @@ -25,8 +25,7 @@ func ProvideSecureValueMetadataStorage( features featuremgmt.FeatureToggles, reg prometheus.Registerer, ) (contracts.SecureValueMetadataStorage, error) { - if !features.IsEnabledGlobally(featuremgmt.FlagGrafanaAPIServerWithExperimentalAPIs) || - !features.IsEnabledGlobally(featuremgmt.FlagSecretsManagementAppPlatform) { + if !features.IsEnabledGlobally(featuremgmt.FlagSecretsManagementAppPlatform) { return &secureValueMetadataStorage{}, nil } diff --git a/pkg/storage/secret/metadata/secure_value_store_test.go b/pkg/storage/secret/metadata/secure_value_store_test.go index 4014d497264..1668ddfa9a5 100644 --- a/pkg/storage/secret/metadata/secure_value_store_test.go +++ b/pkg/storage/secret/metadata/secure_value_store_test.go @@ -42,7 +42,7 @@ func Test_SecureValueMetadataStorage_CreateAndRead(t *testing.T) { tracer := noop.NewTracerProvider().Tracer("test") db := database.ProvideDatabase(testDB, tracer) - features := featuremgmt.WithFeatures(featuremgmt.FlagGrafanaAPIServerWithExperimentalAPIs, featuremgmt.FlagSecretsManagementAppPlatform) + features := featuremgmt.WithFeatures(featuremgmt.FlagSecretsManagementAppPlatform) // Initialize the secure value storage secureValueStorage, err := metadata.ProvideSecureValueMetadataStorage(db, tracer, features, nil)