From 45c361e307ebad316d634e950f29f21240f6579d Mon Sep 17 00:00:00 2001 From: kay delaney <45561153+kaydelaney@users.noreply.github.com> Date: Wed, 28 May 2025 12:10:28 +0100 Subject: [PATCH] Dashboards/E2E: Remove unnecessary `e2e.pages.Dashboards.visit()` invocations (#106070) --- e2e/dashboard-new-layouts/dashboards-add-panel.spec.ts | 1 - .../dashboards-edit-adhoc-variables.spec.ts | 2 -- .../dashboards-edit-panel-title-description.spec.ts | 1 - .../dashboards-edit-panel-transparent-bg.spec.ts | 1 - .../dashboards-edit-query-variables.spec.ts | 2 -- .../dashboards-edit-variables.spec.ts | 8 -------- e2e/dashboard-new-layouts/dashboards-move-panel.spec.ts | 1 - e2e/dashboard-new-layouts/dashboards-remove-panel.spec.ts | 2 -- .../dashboards-title-description.spec.ts | 1 - 9 files changed, 19 deletions(-) diff --git a/e2e/dashboard-new-layouts/dashboards-add-panel.spec.ts b/e2e/dashboard-new-layouts/dashboards-add-panel.spec.ts index 2c653deda74..9997351cfdd 100644 --- a/e2e/dashboard-new-layouts/dashboards-add-panel.spec.ts +++ b/e2e/dashboard-new-layouts/dashboards-add-panel.spec.ts @@ -9,7 +9,6 @@ describe('Dashboard panels', () => { }); it('can add a new panel', () => { - e2e.pages.Dashboards.visit(); e2e.flows.openDashboard({ uid: `${PAGE_UNDER_TEST}?orgId=1` }); cy.contains(DASHBOARD_NAME).should('be.visible'); diff --git a/e2e/dashboard-new-layouts/dashboards-edit-adhoc-variables.spec.ts b/e2e/dashboard-new-layouts/dashboards-edit-adhoc-variables.spec.ts index 6a35cedbe9a..f7350331978 100644 --- a/e2e/dashboard-new-layouts/dashboards-edit-adhoc-variables.spec.ts +++ b/e2e/dashboard-new-layouts/dashboards-edit-adhoc-variables.spec.ts @@ -11,8 +11,6 @@ describe('Dashboard edit - Ad hoc variables', () => { }); it('can add a new adhoc variable', () => { - e2e.pages.Dashboards.visit(); - e2e.flows.openDashboard({ uid: `${PAGE_UNDER_TEST}?orgId=1` }); cy.contains(DASHBOARD_NAME).should('be.visible'); diff --git a/e2e/dashboard-new-layouts/dashboards-edit-panel-title-description.spec.ts b/e2e/dashboard-new-layouts/dashboards-edit-panel-title-description.spec.ts index 3b522db3c8d..a7122c53902 100644 --- a/e2e/dashboard-new-layouts/dashboards-edit-panel-title-description.spec.ts +++ b/e2e/dashboard-new-layouts/dashboards-edit-panel-title-description.spec.ts @@ -10,7 +10,6 @@ describe('Dashboard', () => { }); it('can edit panel title and description', () => { - e2e.pages.Dashboards.visit(); e2e.flows.openDashboard({ uid: `${PAGE_UNDER_TEST}?orgId=1` }); e2e.flows.scenes.toggleEditMode(); diff --git a/e2e/dashboard-new-layouts/dashboards-edit-panel-transparent-bg.spec.ts b/e2e/dashboard-new-layouts/dashboards-edit-panel-transparent-bg.spec.ts index 7e7bb717b75..ca6c5df485b 100644 --- a/e2e/dashboard-new-layouts/dashboards-edit-panel-transparent-bg.spec.ts +++ b/e2e/dashboard-new-layouts/dashboards-edit-panel-transparent-bg.spec.ts @@ -8,7 +8,6 @@ describe('Dashboard', () => { }); it('can toggle transparent background switch', () => { - e2e.pages.Dashboards.visit(); e2e.flows.openDashboard({ uid: `${PAGE_UNDER_TEST}?orgId=1` }); e2e.flows.scenes.toggleEditMode(); diff --git a/e2e/dashboard-new-layouts/dashboards-edit-query-variables.spec.ts b/e2e/dashboard-new-layouts/dashboards-edit-query-variables.spec.ts index 86843243ad4..47e445a3421 100644 --- a/e2e/dashboard-new-layouts/dashboards-edit-query-variables.spec.ts +++ b/e2e/dashboard-new-layouts/dashboards-edit-query-variables.spec.ts @@ -11,8 +11,6 @@ describe('Dashboard edit - Query variable', () => { }); it('can add a new query variable', () => { - e2e.pages.Dashboards.visit(); - e2e.flows.openDashboard({ uid: `${PAGE_UNDER_TEST}?orgId=1` }); cy.contains(DASHBOARD_NAME).should('be.visible'); diff --git a/e2e/dashboard-new-layouts/dashboards-edit-variables.spec.ts b/e2e/dashboard-new-layouts/dashboards-edit-variables.spec.ts index 40b1d1c7261..37737b65c6a 100644 --- a/e2e/dashboard-new-layouts/dashboards-edit-variables.spec.ts +++ b/e2e/dashboard-new-layouts/dashboards-edit-variables.spec.ts @@ -11,8 +11,6 @@ describe('Dashboard edit - variables', () => { }); it('can add a new custom variable', () => { - e2e.pages.Dashboards.visit(); - e2e.flows.openDashboard({ uid: `${PAGE_UNDER_TEST}?orgId=1` }); cy.contains(DASHBOARD_NAME).should('be.visible'); @@ -41,8 +39,6 @@ describe('Dashboard edit - variables', () => { }); it('can add a new constant variable', () => { - e2e.pages.Dashboards.visit(); - e2e.flows.openDashboard({ uid: `${PAGE_UNDER_TEST}?orgId=1` }); cy.contains(DASHBOARD_NAME).should('be.visible'); @@ -73,8 +69,6 @@ describe('Dashboard edit - variables', () => { }); it('can add a new textbox variable', () => { - e2e.pages.Dashboards.visit(); - e2e.flows.openDashboard({ uid: `${PAGE_UNDER_TEST}?orgId=1` }); cy.contains(DASHBOARD_NAME).should('be.visible'); @@ -109,8 +103,6 @@ describe('Dashboard edit - variables', () => { }); it('can add a new interval variable', () => { - e2e.pages.Dashboards.visit(); - e2e.flows.openDashboard({ uid: `${PAGE_UNDER_TEST}?orgId=1` }); cy.contains(DASHBOARD_NAME).should('be.visible'); diff --git a/e2e/dashboard-new-layouts/dashboards-move-panel.spec.ts b/e2e/dashboard-new-layouts/dashboards-move-panel.spec.ts index 43cdf132b18..81d6dc749b1 100644 --- a/e2e/dashboard-new-layouts/dashboards-move-panel.spec.ts +++ b/e2e/dashboard-new-layouts/dashboards-move-panel.spec.ts @@ -8,7 +8,6 @@ describe('Dashboard', () => { }); it('can drag and drop panels', () => { - e2e.pages.Dashboards.visit(); e2e.flows.openDashboard({ uid: `${PAGE_UNDER_TEST}?orgId=1` }); e2e.flows.scenes.toggleEditMode(); diff --git a/e2e/dashboard-new-layouts/dashboards-remove-panel.spec.ts b/e2e/dashboard-new-layouts/dashboards-remove-panel.spec.ts index 6bdd01601d4..7256a4f4740 100644 --- a/e2e/dashboard-new-layouts/dashboards-remove-panel.spec.ts +++ b/e2e/dashboard-new-layouts/dashboards-remove-panel.spec.ts @@ -8,7 +8,6 @@ describe('Dashboard panels', () => { }); it('can remove a panel', () => { - e2e.pages.Dashboards.visit(); e2e.flows.openDashboard({ uid: `${PAGE_UNDER_TEST}?orgId=1` }); e2e.flows.scenes.toggleEditMode(); @@ -22,7 +21,6 @@ describe('Dashboard panels', () => { }); it('can remove several panels at once', () => { - e2e.pages.Dashboards.visit(); e2e.flows.openDashboard({ uid: `${PAGE_UNDER_TEST}?orgId=1` }); e2e.flows.scenes.toggleEditMode(); diff --git a/e2e/dashboard-new-layouts/dashboards-title-description.spec.ts b/e2e/dashboard-new-layouts/dashboards-title-description.spec.ts index 0d82fb9f086..2ae8eb28f3e 100644 --- a/e2e/dashboard-new-layouts/dashboards-title-description.spec.ts +++ b/e2e/dashboard-new-layouts/dashboards-title-description.spec.ts @@ -8,7 +8,6 @@ describe('Dashboard', () => { }); it('can change dashboard description and title', () => { - e2e.pages.Dashboards.visit(); e2e.flows.openDashboard({ uid: `${PAGE_UNDER_TEST}?orgId=1` }); e2e.flows.scenes.toggleEditMode();