Toolkit: wrap plugin signing stub with error checking (#22626)

pull/22522/head
Ryan McKinley 5 years ago committed by GitHub
parent aa7e6cf55f
commit 46fcf9bf08
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 3
      packages/grafana-toolkit/src/cli/tasks/manifest.ts
  2. 6
      packages/grafana-toolkit/src/cli/tasks/plugin.ci.ts

@ -39,7 +39,8 @@ const manifestRunner: TaskRunner<ManifestOptions> = async ({ folder }) => {
// Call a signing service
const GRAFANA_API_KEY = process.env.GRAFANA_API_KEY;
if (GRAFANA_API_KEY) {
const plugin = require('plugin.json');
const pluginPath = path.join(folder, 'plugin.json');
const plugin = require(pluginPath);
const url = `https://grafana.com/api/plugins/${plugin.id}/sign`;
console.log(`TODO: sign and save: ${url}`);
}

@ -168,7 +168,11 @@ const packagePluginRunner: TaskRunner<PluginCIOptions> = async () => {
});
// Write a manifest.txt file in the dist folder
await execTask(manifestTask)({ folder: distContentDir });
try {
await execTask(manifestTask)({ folder: distContentDir });
} catch (err) {
console.warn(`Error signing manifest: ${distContentDir}`, err);
}
console.log('Building ZIP');
let zipName = pluginInfo.id + '-' + pluginInfo.info.version + '.zip';

Loading…
Cancel
Save