diff --git a/pkg/metrics/metrics.go b/pkg/metrics/metrics.go index 50034564530..e3cca119cbb 100644 --- a/pkg/metrics/metrics.go +++ b/pkg/metrics/metrics.go @@ -102,7 +102,7 @@ func init() { M_Http_Request_Summary = prometheus.NewSummaryVec( prometheus.SummaryOpts{ - Name: "http_request_duration", + Name: "http_request_duration_milleseconds", Help: "http request summary", }, []string{"handler", "statuscode", "method"}, @@ -127,19 +127,19 @@ func init() { }) M_Api_Dashboard_Save = prometheus.NewSummary(prometheus.SummaryOpts{ - Name: "api_dashboard_save", + Name: "api_dashboard_save_milleseconds", Help: "summary for dashboard save duration", Namespace: exporterName, }) M_Api_Dashboard_Get = prometheus.NewSummary(prometheus.SummaryOpts{ - Name: "api_dashboard_get", + Name: "api_dashboard_get_milleseconds", Help: "summary for dashboard get duration", Namespace: exporterName, }) M_Api_Dashboard_Search = prometheus.NewSummary(prometheus.SummaryOpts{ - Name: "api_dashboard_search", + Name: "api_dashboard_search_milleseconds", Help: "summary for dashboard search duration", Namespace: exporterName, }) @@ -223,13 +223,13 @@ func init() { }) M_DataSource_ProxyReq_Timer = prometheus.NewSummary(prometheus.SummaryOpts{ - Name: "api_dataproxy_request_all", + Name: "api_dataproxy_request_all_milleseconds", Help: "summary for dashboard search duration", Namespace: exporterName, }) M_Alerting_Execution_Time = prometheus.NewSummary(prometheus.SummaryOpts{ - Name: "alerting_execution_time_seconds", + Name: "alerting_execution_time_milliseconds", Help: "summary of alert exeuction duration", Namespace: exporterName, }) diff --git a/pkg/middleware/request_metrics.go b/pkg/middleware/request_metrics.go index 60e2d331ce6..f2d71c0a0fe 100644 --- a/pkg/middleware/request_metrics.go +++ b/pkg/middleware/request_metrics.go @@ -21,7 +21,8 @@ func RequestMetrics(handler string) macaron.Handler { code := sanitizeCode(status) method := sanitizeMethod(req.Method) metrics.M_Http_Request_Total.WithLabelValues(handler, code, method).Inc() - metrics.M_Http_Request_Summary.WithLabelValues(handler, code, method).Observe(time.Since(now).Seconds()) + duration := time.Since(now).Nanoseconds() / int64(time.Millisecond) + metrics.M_Http_Request_Summary.WithLabelValues(handler, code, method).Observe(float64(duration)) if strings.HasPrefix(req.RequestURI, "/api/datasources/proxy") { countProxyRequests(status) diff --git a/pkg/services/alerting/eval_handler.go b/pkg/services/alerting/eval_handler.go index bf7d4bd0284..5c2861b9154 100644 --- a/pkg/services/alerting/eval_handler.go +++ b/pkg/services/alerting/eval_handler.go @@ -63,8 +63,8 @@ func (e *DefaultEvalHandler) Eval(context *EvalContext) { context.EndTime = time.Now() context.Rule.State = e.getNewState(context) - elapsedTime := context.EndTime.Sub(context.StartTime).Seconds() - metrics.M_Alerting_Execution_Time.Observe(elapsedTime) + elapsedTime := context.EndTime.Sub(context.StartTime).Nanoseconds() / int64(time.Millisecond) + metrics.M_Alerting_Execution_Time.Observe(float64(elapsedTime)) } // This should be move into evalContext once its been refactored.