Alerting: Fix response is not returned for invalid Duration in Provisioning API (#58046)

3 years ago · 4c581b5f85
parent 909d0f4ced
commit 4c581b5f85
1 changed files with 1 additions and 1 deletions
--- a/pkg/services/ngalert/api/api_provisioning.go
+++ b/pkg/services/ngalert/api/api_provisioning.go
@ -257,7 +257,7 @@ func (srv *ProvisioningSrv) RoutePostAlertRule(c *models.ReqContext, ar definiti
 	upstreamModel, err := ar.UpstreamModel()
 	upstreamModel.OrgID = c.OrgID
 	if err != nil {
-		ErrResp(http.StatusBadRequest, err, "")
+		return ErrResp(http.StatusBadRequest, err, "")
 	}
 	createdAlertRule, err := srv.alertRules.CreateAlertRule(c.Req.Context(), upstreamModel, alerting_models.ProvenanceAPI, c.UserID)
 	if errors.Is(err, alerting_models.ErrAlertRuleFailedValidation) {