don't show dashboards or starred items in navbar when unauthenticated (#53051)

pkg/api/index.go

@@ -169,35 +169,37 @@ func (hs *HTTPServer) getNavTree(c *models.ReqContext, hasEditPerm bool, prefs *
 	hasAccess := ac.HasAccess(hs.AccessControl, c)
 	navTree := []*dtos.NavLink{}
 
-	starredItemsLinks, err := hs.buildStarredItemsNavLinks(c, prefs)
-	if err != nil {
-		return nil, err
-	}
+	if hasAccess(ac.ReqSignedIn, ac.EvalPermission(dashboards.ActionDashboardsRead)) {
+		starredItemsLinks, err := hs.buildStarredItemsNavLinks(c, prefs)
+		if err != nil {
+			return nil, err
+		}
 
-	navTree = append(navTree, &dtos.NavLink{
-		Text:           "Starred",
-		Id:             "starred",
-		Icon:           "star",
-		SortWeight:     dtos.WeightSavedItems,
-		Section:        dtos.NavSectionCore,
-		Children:       starredItemsLinks,
-		EmptyMessageId: "starred-empty",
-	})
+		navTree = append(navTree, &dtos.NavLink{
+			Text:           "Starred",
+			Id:             "starred",
+			Icon:           "star",
+			SortWeight:     dtos.WeightSavedItems,
+			Section:        dtos.NavSectionCore,
+			Children:       starredItemsLinks,
+			EmptyMessageId: "starred-empty",
+		})
 
-	dashboardChildLinks := hs.buildDashboardNavLinks(c, hasEditPerm)
+		dashboardChildLinks := hs.buildDashboardNavLinks(c, hasEditPerm)
 
-	dashboardsUrl := "/dashboards"
+		dashboardsUrl := "/dashboards"
 
-	navTree = append(navTree, &dtos.NavLink{
-		Text:       "Dashboards",
-		Id:         "dashboards",
-		SubTitle:   "Manage dashboards and folders",
-		Icon:       "apps",
-		Url:        hs.Cfg.AppSubURL + dashboardsUrl,
-		SortWeight: dtos.WeightDashboard,
-		Section:    dtos.NavSectionCore,
-		Children:   dashboardChildLinks,
-	})
+		navTree = append(navTree, &dtos.NavLink{
+			Text:       "Dashboards",
+			Id:         "dashboards",
+			SubTitle:   "Manage dashboards and folders",
+			Icon:       "apps",
+			Url:        hs.Cfg.AppSubURL + dashboardsUrl,
+			SortWeight: dtos.WeightDashboard,
+			Section:    dtos.NavSectionCore,
+			Children:   dashboardChildLinks,
+		})
+	}
 
 	canExplore := func(context *models.ReqContext) bool {
 		return c.OrgRole == models.ROLE_ADMIN || c.OrgRole == models.ROLE_EDITOR || setting.ViewersCanEdit

public/app/core/components/NavBar/NavBar.tsx

@@ -64,7 +64,7 @@ export const NavBar = React.memo(() => {
     {
       id: 'home',
       text: 'Home',
-      url: config.appSubUrl || '/',
+      url: config.bootData.user.isSignedIn ? config.appSubUrl || '/' : '/login',
       icon: 'grafana',
     },
     menuOpen