From 5218497a3ed1e36414502de0a72cb3ef7642c788 Mon Sep 17 00:00:00 2001 From: Josh Hunt Date: Mon, 15 Feb 2021 10:15:34 +0000 Subject: [PATCH] Chore: report eslint no-explicit-any errors to metrics (#31182) * Chore: report eslint no-explicit-any errors to metrics * double quote --- scripts/ci-frontend-metrics.sh | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/scripts/ci-frontend-metrics.sh b/scripts/ci-frontend-metrics.sh index f56bb03c909..f183a540cf3 100755 --- a/scripts/ci-frontend-metrics.sh +++ b/scripts/ci-frontend-metrics.sh @@ -1,19 +1,23 @@ #!/bin/bash set -e -ERROR_COUNT="$(./node_modules/.bin/tsc --project tsconfig.json --noEmit --strict true | grep -oP 'Found \K(\d+)')" +ERROR_COUNT="$(yarn run tsc --project tsconfig.json --noEmit --strict true | grep -oP 'Found \K(\d+)')" DIRECTIVES="$(grep -r -o directive public/app/ | wc -l)" CONTROLLERS="$(grep -r -oP 'class .*Ctrl' public/app/ | wc -l)" STORIES_COUNT="$(find ./packages/grafana-ui/src/components -name "*.story.tsx" | wc -l)" MDX_COUNT="$(find ./packages/grafana-ui/src/components -name "*.mdx" | wc -l)" LEGACY_FORMS="$(grep -r -oP 'LegacyForms;' public/app | wc -l)" +STRICT_LINT_RESULTS="$(yarn run eslint --rule '@typescript-eslint/no-explicit-any: ["error"]' --format unix ./public/ || true)" +STRICT_LINT_EXPLICIT_ANY="$(echo "${STRICT_LINT_RESULTS}" | grep -o "no-explicit-any" | wc -l)" + echo -e "Typescript errors: $ERROR_COUNT" echo -e "Directives: $DIRECTIVES" echo -e "Controllers: $CONTROLLERS" echo -e "Stories: $STORIES_COUNT" echo -e "Documented stories: $MDX_COUNT" echo -e "Legacy forms: $LEGACY_FORMS" +echo -e "TS Explicit any: $STRICT_LINT_EXPLICIT_ANY" echo "Metrics: { \"grafana.ci-code.strictErrors\": \"${ERROR_COUNT}\", @@ -21,5 +25,6 @@ echo "Metrics: { \"grafana.ci-code.controllers\": \"${CONTROLLERS}\", \"grafana.ci-code.grafana-ui.stories\": \"${STORIES_COUNT}\", \"grafana.ci-code.grafana-ui.mdx\": \"${MDX_COUNT}\", - \"grafana.ci-code.legacyForms\": \"${LEGACY_FORMS}\" + \"grafana.ci-code.legacyForms\": \"${LEGACY_FORMS}\", + \"grafana.ci-code.strictLint.noExplicitAny\": \"${STRICT_LINT_EXPLICIT_ANY}\" }"