From 5d5999561ade53e5abe79f228214e22630fce852 Mon Sep 17 00:00:00 2001 From: bergquist Date: Mon, 25 Apr 2016 08:46:15 +0200 Subject: [PATCH] test(dashboard): add failing test for deleting dashboards --- pkg/services/sqlstore/alerting.go | 2 ++ pkg/services/sqlstore/dashboard_test.go | 14 ++++++++++++++ 2 files changed, 16 insertions(+) diff --git a/pkg/services/sqlstore/alerting.go b/pkg/services/sqlstore/alerting.go index 06e41e11734..95503a7c9cd 100644 --- a/pkg/services/sqlstore/alerting.go +++ b/pkg/services/sqlstore/alerting.go @@ -11,6 +11,8 @@ func init() { } func SaveAlerts(cmd *m.SaveAlertsCommand) error { + //this function should be refactored + fmt.Printf("Saving alerts for dashboard %v\n", cmd.DashboardId) alerts, err := GetAlertsByDashboardId(cmd.DashboardId) diff --git a/pkg/services/sqlstore/dashboard_test.go b/pkg/services/sqlstore/dashboard_test.go index 609639f7788..a055500592b 100644 --- a/pkg/services/sqlstore/dashboard_test.go +++ b/pkg/services/sqlstore/dashboard_test.go @@ -5,6 +5,7 @@ import ( . "github.com/smartystreets/goconvey/convey" + "github.com/gosimple/slug" "github.com/grafana/grafana/pkg/components/simplejson" m "github.com/grafana/grafana/pkg/models" "github.com/grafana/grafana/pkg/services/search" @@ -55,6 +56,19 @@ func TestDashboardDataAccess(t *testing.T) { So(query.Result.Slug, ShouldEqual, "test-dash-23") }) + Convey("Should be able to delete dashboard", func() { + insertTestDashboard("delete me", 1, "delete this") + + dashboardSlug := slug.Make("delete me") + + err := DeleteDashboard(&m.DeleteDashboardCommand{ + Slug: dashboardSlug, + OrgId: 1, + }) + + So(err, ShouldBeNil) + }) + Convey("Should return error if no dashboard is updated", func() { cmd := m.SaveDashboardCommand{ OrgId: 1,