diff --git a/packages/grafana-data/src/utils/datemath.ts b/packages/grafana-data/src/utils/datemath.ts index 3b033e9cc6d..5b614606f7c 100644 --- a/packages/grafana-data/src/utils/datemath.ts +++ b/packages/grafana-data/src/utils/datemath.ts @@ -5,18 +5,6 @@ import { TimeZone } from '../types'; const units: DurationUnit[] = ['y', 'M', 'w', 'd', 'h', 'm', 's']; -export function isMathString(text: string | DateTime | Date): boolean { - if (!text) { - return false; - } - - if (typeof text === 'string' && (text.substring(0, 3) === 'now' || text.includes('||'))) { - return true; - } else { - return false; - } -} - /** * Parses different types input to a moment instance. There is a specific formatting language that can be used * if text arg is string. See unit tests for examples. diff --git a/packages/grafana-ui/src/components/TimePicker/TimePicker.tsx b/packages/grafana-ui/src/components/TimePicker/TimePicker.tsx index 646a99a90bd..d69877fd968 100644 --- a/packages/grafana-ui/src/components/TimePicker/TimePicker.tsx +++ b/packages/grafana-ui/src/components/TimePicker/TimePicker.tsx @@ -14,7 +14,6 @@ import { rawToTimeRange } from './time'; // Types import { TimeRange, TimeOption, TimeZone, TIME_FORMAT, SelectableValue } from '@grafana/data'; -import { isMathString } from '@grafana/data/src/utils/datemath'; export interface Props { value: TimeRange; @@ -124,21 +123,13 @@ export class TimePicker extends PureComponent { const { isCustomOpen } = this.state; const options = this.mapTimeOptionsToSelectableValues(selectTimeOptions); const currentOption = options.find(item => isTimeOptionEqualToTimeRange(item.value, value)); - - const isUTC = timeZone === 'utc'; - const adjustedTo = isUTC ? value.to.utc() : value.to.local(); - const adjustedFrom = isUTC ? value.from.utc() : value.from.local(); - const adjustedTimeRange = { - to: isMathString(value.raw.to) ? value.raw.to : adjustedTo, - from: isMathString(value.raw.from) ? value.raw.from : adjustedFrom, - }; - const rangeString = rangeUtil.describeTimeRange(adjustedTimeRange); + const rangeString = rangeUtil.describeTimeRange(value.raw); const label = ( <> {isCustomOpen && Custom time range} {!isCustomOpen && {rangeString}} - {isUTC && UTC} + {timeZone === 'utc' && UTC} ); const isAbsolute = isDateTime(value.raw.to); diff --git a/public/app/features/dashboard/components/DashNav/DashNavTimeControls.tsx b/public/app/features/dashboard/components/DashNav/DashNavTimeControls.tsx index bdb8f810d6b..a872f1ba432 100644 --- a/public/app/features/dashboard/components/DashNav/DashNavTimeControls.tsx +++ b/public/app/features/dashboard/components/DashNav/DashNavTimeControls.tsx @@ -1,6 +1,6 @@ // Libaries import React, { Component } from 'react'; -import { toUtc, dateMath } from '@grafana/data'; +import { toUtc } from '@grafana/data'; // Types import { DashboardModel } from '../../state'; @@ -61,11 +61,9 @@ export class DashNavTimeControls extends Component { const panel = dashboard.timepicker; const hasDelay = panel.nowDelay && timeRange.raw.to === 'now'; - const adjustedFrom = dateMath.isMathString(timeRange.raw.from) ? timeRange.raw.from : timeRange.from; - const adjustedTo = dateMath.isMathString(timeRange.raw.to) ? timeRange.raw.to : timeRange.to; const nextRange = { - from: adjustedFrom, - to: hasDelay ? 'now-' + panel.nowDelay : adjustedTo, + from: timeRange.raw.from, + to: hasDelay ? 'now-' + panel.nowDelay : timeRange.raw.to, }; this.timeSrv.setTime(nextRange);