Alerting: Set ExecErrState to Normal for imported Prometheus rules (#103556)

pull/103558/head^2
Alexander Akhmetov 1 month ago committed by GitHub
parent 6d28544ef4
commit 66006928b8
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
  1. 2
      pkg/services/ngalert/prom/convert.go
  2. 3
      pkg/services/ngalert/prom/convert_test.go

@ -72,7 +72,7 @@ var (
defaultConfig = Config{
FromTimeRange: &defaultTimeRange,
EvaluationOffset: &defaultEvaluationOffset,
ExecErrState: models.ErrorErrState,
ExecErrState: models.OkErrState,
NoDataState: models.OK,
KeepOriginalRuleDefinition: util.Pointer(true),
}

@ -354,6 +354,9 @@ func TestPrometheusRulesToGrafana(t *testing.T) {
require.Equal(t, models.Duration(10*time.Minute+evalOffset), grafanaRule.Data[0].RelativeTimeRange.From)
require.Equal(t, util.Pointer(1), grafanaRule.MissingSeriesEvalsToResolve)
require.Equal(t, models.OkErrState, grafanaRule.ExecErrState)
require.Equal(t, models.OK, grafanaRule.NoDataState)
originalRuleDefinition, err := yaml.Marshal(promRule)
require.NoError(t, err)
require.Equal(t, string(originalRuleDefinition), grafanaRule.Metadata.PrometheusStyleRule.OriginalRuleDefinition)

Loading…
Cancel
Save