Merge pull request #15793 from grafana/hugoh/bug-can-not-use-testdatasource-in-v6

Update datasource in componentDidUpdate so that datasource is correct in state
pull/15803/head
Torkel Ödegaard 6 years ago committed by GitHub
commit 6da87a17ef
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 12
      public/app/features/datasources/settings/DataSourceSettingsPage.tsx

@ -64,6 +64,14 @@ export class DataSourceSettingsPage extends PureComponent<Props, State> {
await loadDataSource(pageId);
}
componentDidUpdate(prevProps: Props) {
const { dataSource } = this.props;
if (prevProps.dataSource !== dataSource) {
this.setState({ dataSource });
}
}
onSubmit = async (evt: React.FormEvent<HTMLFormElement>) => {
evt.preventDefault();
@ -95,9 +103,7 @@ export class DataSourceSettingsPage extends PureComponent<Props, State> {
};
onModelChange = (dataSource: DataSourceSettings) => {
this.setState({
dataSource: dataSource,
});
this.setState({ dataSource });
};
isReadOnly() {

Loading…
Cancel
Save