mirror of https://github.com/grafana/grafana
Alerting: Validate contact point configuration during migration to Unified Alerting (#40717)
* Alerting: Validate contact point configuration during the migration This minimises the chances of generating broken configuration as part of the migration. Originally, we wanted to generate it and not produce a hard stop in Grafana but this strategy has the chance to avoid delivering notifications for our users. We now think it's better to hard stop the migration and let the user take care of resolving the configuration manually.pull/40719/head^2
gotjosh
4 years ago
committed by
GitHub
parent
998ba06f39
commit
74fb491b6a
@ -0,0 +1,32 @@ |
||||
package channels |
||||
|
||||
import ( |
||||
"github.com/grafana/grafana/pkg/infra/log" |
||||
"github.com/grafana/grafana/pkg/models" |
||||
) |
||||
|
||||
// Base is the base implementation of a notifier. It contains the common fields across all notifier types.
|
||||
type Base struct { |
||||
Name string |
||||
Type string |
||||
UID string |
||||
IsDefault bool |
||||
DisableResolveMessage bool |
||||
|
||||
log log.Logger |
||||
} |
||||
|
||||
func (n *Base) GetDisableResolveMessage() bool { |
||||
return n.DisableResolveMessage |
||||
} |
||||
|
||||
func NewBase(model *models.AlertNotification) *Base { |
||||
return &Base{ |
||||
UID: model.Uid, |
||||
Name: model.Name, |
||||
IsDefault: model.IsDefault, |
||||
Type: model.Type, |
||||
DisableResolveMessage: model.DisableResolveMessage, |
||||
log: log.New("alerting.notifier." + model.Name), |
||||
} |
||||
} |
||||
@ -0,0 +1,23 @@ |
||||
package ualert |
||||
|
||||
import ( |
||||
"testing" |
||||
|
||||
"github.com/grafana/grafana/pkg/infra/log" |
||||
"github.com/grafana/grafana/pkg/services/sqlstore/migrator" |
||||
) |
||||
|
||||
// newTestMigration generates an empty migration to use in tests.
|
||||
func newTestMigration(t *testing.T) *migration { |
||||
t.Helper() |
||||
|
||||
return &migration{ |
||||
mg: &migrator.Migrator{ |
||||
|
||||
Logger: log.New("test"), |
||||
}, |
||||
migratedChannelsPerOrg: make(map[int64]map[*notificationChannel]struct{}), |
||||
portedChannelGroupsPerOrg: make(map[int64]map[string]string), |
||||
seenChannelUIDs: make(map[string]struct{}), |
||||
} |
||||
} |
||||
Loading…
Reference in new issue